Received-SPF: pass (google.com: domain of linux-kernel+bounces-50126-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <0b94b25a-9ffa-41a5-b931-ad84e1892d36@amd.com>
Date: Fri, 2 Feb 2024 10:20:58 -0600
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] drm/amd/display: add panel_power_savings sysfs entry
 to eDP connectors
Content-Language: en-US
To: Hamza Mahfooz <hamza.mahfooz@amd.com>, amd-gfx@lists.freedesktop.org
Cc: Harry Wentland <harry.wentland@amd.com>, Leo Li <sunpeng.li@amd.com>,
 Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
 Alex Deucher <alexander.deucher@amd.com>,
 =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>,
 "Pan, Xinhui" <Xinhui.Pan@amd.com>, David Airlie <airlied@gmail.com>,
 Daniel Vetter <daniel@ffwll.ch>, Alex Hung <alex.hung@amd.com>,
 Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>,
 Wayne Lin <wayne.lin@amd.com>, dri-devel@lists.freedesktop.org,
 linux-kernel@vger.kernel.org
References: <20240202152837.7388-1-hamza.mahfooz@amd.com>
From: Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <20240202152837.7388-1-hamza.mahfooz@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dVpkTGNHZ0tUTWFMb0RJVVlYUkUzUGZkVjlkWVdoMmYwVERkbTh6S2gzd2Q4?=
 =?utf-8?B?K1hYMGRnSVZSaksyNE5NczZmY3ZCa0xscklGck9yRmtWaitaNDlMU21MOE8z?=
 =?utf-8?B?YkNCVUdaL25KRmE4c0grZnUvT08zUldGQ0dOMkxsb1JyQmxuU2FjdW4xa0Fu?=
 =?utf-8?B?bS9xRTR3eldVVjgydG9raFVNZGY0cU1SeWMvWWEzVndzQnZxR1NqZzVId01a?=
 =?utf-8?B?dHVvYmNqck9QTEVEclZHalppU0t1cHhMb0RBdnBZV2UwRHlUSE5tUGRZQkl5?=
 =?utf-8?B?U0szUmFwZ1IrRk1obU9lclhwelR4NWlOcWowSFZZMk05SnZ2U0FEaTB0b01Y?=
 =?utf-8?B?ZWJXVWFqdlk1QjFHdDIxdW9adEZkNUN2enk4dUVHcnNZa2s4c3VzbDhZUjFw?=
 =?utf-8?B?b1FoUlBkdzJwOGo1K2ZZU2FwUkZ5QXhqcEhVWDdHTnl6dXNIUW0zaVJ6ZHls?=
 =?utf-8?B?QUhsWFFNQS9BTHhBOHRJR2c4MWpYYStQYUlyMDJkYUJCYytUZ1VTdk9uL3dI?=
 =?utf-8?B?aHJkSXc3cTlISElvYTVxaUh4MnVoMlQ4YjhqVTdsOVVPSS85RFNXSHViVzY2?=
 =?utf-8?B?eGh4U2lROFF0dDY2NmtpN0dHK1BFdlVPcW1YbDUrY0p2UmVHV1RwSVhTQjBM?=
 =?utf-8?B?Y3BhSTh5WSsyb3VKc3VyeitVNWg3MG9LT2xHYW0xSTJZNEgzOXNNMkk0VENa?=
 =?utf-8?B?amN4a2UrSFI4M29WUjh5RnhCK0VlczZlbmlNZWN6T0Fhd0RzUU9LcTBQK21O?=
 =?utf-8?B?MytSblhPc2N6eGNkSUQ0VitQY1F0ZGJ5eTBSZTI0ZW9uMWV1czNLcS9Sd0hp?=
 =?utf-8?B?aHY3QWtSUXhnc2o0Nzk1bG5DV2s2Z0dpbU5KZWlCalRodzMvQVA1QXh4R2Jz?=
 =?utf-8?B?K1c0MEpyT0U2anpkZnpadlArWi9EZDltYmpNTEFYWWlMRUF3bjlidVhRckdH?=
 =?utf-8?B?Y3phYVpuaFFLaW1ubUQxWDJpZkJlcnorUkN1UW9SRnRqWHdMVzFsdU1HUXVU?=
 =?utf-8?B?N3RhdFB4L2EzWnZwdXgwdEwzblVKOVJNbWozdUkzanhkN2pqTnhua21hVXpx?=
 =?utf-8?B?UVhNQms4dHJ5K291UnRrNGpaci9ETXVZRHFlYitudnpmanc1Yy9lVnJqdUls?=
 =?utf-8?B?eWdBSmlhbElINFBJTjd4Z25pODBvMTdRZ3UxUDFKQzBkM0plckxaS2hhK0NT?=
 =?utf-8?B?bmZoQ0ZRcmkrTktpc01YU1o0Z056WEdvQnY3d2Q2SmZmTnRMRUc0aGJUWVdH?=
 =?utf-8?B?MGg1WDRtazRaN1RjZm9lbStrdXA4YVJlSWxOeDlhVUpJUzY4QThsSDBtWmtN?=
 =?utf-8?B?cDFsZjlWcjZJeHJycFRYSEJDdnRwaXNHdXk1OW93TXcwZU9XSEVNM1pYV1Fp?=
 =?utf-8?B?cVFrdmVRdHBQN2lja3dhYVAzMWNoaG5uT296R2tpalZ2WmhDenF4cEJzUzhB?=
 =?utf-8?B?TFEyZkgvVm5lNGw2bGhkc0ZIRExHamlkR1RkdWgzSThsMm1IRzRjdDJoZlRt?=
 =?utf-8?B?ZURoTHArWWFQUFo4U3FIeHRGSDF1bDdPU3RHSkZCUkV5ZkFkZlh5eVlsMGZ5?=
 =?utf-8?B?ZVFtL1RNeEtzOFhiMG02bUMvZFVJSXFQN3ZvZnMzaldScnp4bUhpOFV6TW56?=
 =?utf-8?B?akdTK2pOcHpORzlaRTgyMU5oZ1ZGK2xNckR0S0toU0tTekNsVU9ONTRFbmtj?=
 =?utf-8?B?MXdoZ1RJbGFEQmZjL1R3aHVoMnE5dTNQWjBzUE4zeHF1MjVaR2hyZ3g5OUFE?=
 =?utf-8?B?dk5mZDBISEhQT2JKb0FqRVZ4akdwUHo5NFZMSVdtYXkvdGlEK3lvY0tPY2x3?=
 =?utf-8?B?ZkE1c2p3OVV3bjEwRUE3aXRkQjA1cmhuT3kzWFpvSXZCMmx4T0x2OWI1S3Jn?=
 =?utf-8?B?bjQxdWZ1cUhrYXRxNFA4VUxuQ1dBNkdBQW1aRWI5Z1NLVnRRUm13NlViVEFl?=
 =?utf-8?B?OXF1RkV5c3h1Tlcrb1ZWOEN2aE5NOVoxb2Y3ZVN5YVZVZ0FCZU5iNGJIalJI?=
 =?utf-8?B?NnlDK1ZHQ2g4Q1FoOS96TFZ6amxRWjE3Q0FzbDhSVzBtd2NJYWw5MllXc01W?=
 =?utf-8?B?TVlkMDVJTWtNZjNieWh5dzVVNVpZdjdmbnJZZURHT3RwR28xV3ExekphYVVh?=
 =?utf-8?Q?3r3hIrbiaL5UpuglyXTt86r+C?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 22b5e6b4-e07f-4487-138e-08dc240af245
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2024 16:21:01.4260
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OIvzMHeLoHfYxHGuOEtBvh7SvTpnDDadGrfb9e7vaeCuQnZSqkASgYXGun0HfAtUjcYqHul3XAixDfU9nYryWA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB5644

On 2/2/2024 09:28, Hamza Mahfooz wrote:
> We want programs besides the compositor to be able to enable or disable
> panel power saving features. However, since they are currently only
> configurable through DRM properties, that isn't possible. So, to remedy
> that issue introduce a new "panel_power_savings" sysfs attribute.
> 
> Cc: Mario Limonciello <mario.limonciello@amd.com>
> Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>

Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
Tested-by: Mario Limonciello <mario.limonciello@amd.com>

> ---
> v2: hide ABM_LEVEL_IMMEDIATE_DISABLE in the read case, force an atomic
>      commit when setting the value, call sysfs_remove_group() in
>      amdgpu_dm_connector_unregister() and add some documentation.
> ---
>   .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 76 +++++++++++++++++++
>   1 file changed, 76 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 8590c9f1dda6..3c62489d03dc 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -6436,10 +6436,79 @@ int amdgpu_dm_connector_atomic_get_property(struct drm_connector *connector,
>   	return ret;
>   }
>   
> +/**
> + * DOC: panel power savings
> + *
> + * The display manager allows you to set your desired **panel power savings**
> + * level (between 0-4, with 0 representing off), e.g. using the following::
> + *
> + *   # echo 3 > /sys/class/drm/card0-eDP-1/amdgpu/panel_power_savings
> + *
> + * Modifying this value can have implications on color accuracy, so tread
> + * carefully.
> + */
> +
> +static ssize_t panel_power_savings_show(struct device *device,
> +					struct device_attribute *attr,
> +					char *buf)
> +{
> +	struct drm_connector *connector = dev_get_drvdata(device);
> +	struct drm_device *dev = connector->dev;
> +	u8 val;
> +
> +	drm_modeset_lock(&dev->mode_config.connection_mutex, NULL);
> +	val = to_dm_connector_state(connector->state)->abm_level ==
> +		ABM_LEVEL_IMMEDIATE_DISABLE ? 0 :
> +		to_dm_connector_state(connector->state)->abm_level;
> +	drm_modeset_unlock(&dev->mode_config.connection_mutex);
> +
> +	return sysfs_emit(buf, "%u\n", val);
> +}
> +
> +static ssize_t panel_power_savings_store(struct device *device,
> +					 struct device_attribute *attr,
> +					 const char *buf, size_t count)
> +{
> +	struct drm_connector *connector = dev_get_drvdata(device);
> +	struct drm_device *dev = connector->dev;
> +	long val;
> +	int ret;
> +
> +	ret = kstrtol(buf, 0, &val);
> +
> +	if (ret)
> +		return ret;
> +
> +	if (val < 0 || val > 4)
> +		return -EINVAL;
> +
> +	drm_modeset_lock(&dev->mode_config.connection_mutex, NULL);
> +	to_dm_connector_state(connector->state)->abm_level = val ?:
> +		ABM_LEVEL_IMMEDIATE_DISABLE;
> +	drm_modeset_unlock(&dev->mode_config.connection_mutex);
> +
> +	drm_kms_helper_hotplug_event(dev);
> +
> +	return count;
> +}
> +
> +static DEVICE_ATTR_RW(panel_power_savings);
> +
> +static struct attribute *amdgpu_attrs[] = {
> +	&dev_attr_panel_power_savings.attr,
> +	NULL
> +};
> +
> +static const struct attribute_group amdgpu_group = {
> +	.name = "amdgpu",
> +	.attrs = amdgpu_attrs
> +};
> +
>   static void amdgpu_dm_connector_unregister(struct drm_connector *connector)
>   {
>   	struct amdgpu_dm_connector *amdgpu_dm_connector = to_amdgpu_dm_connector(connector);
>   
> +	sysfs_remove_group(&connector->kdev->kobj, &amdgpu_group);
>   	drm_dp_aux_unregister(&amdgpu_dm_connector->dm_dp_aux.aux);
>   }
>   
> @@ -6541,6 +6610,13 @@ amdgpu_dm_connector_late_register(struct drm_connector *connector)
>   		to_amdgpu_dm_connector(connector);
>   	int r;
>   
> +	if (connector->connector_type == DRM_MODE_CONNECTOR_eDP) {
> +		r = sysfs_create_group(&connector->kdev->kobj,
> +				       &amdgpu_group);
> +		if (r)
> +			return r;
> +	}
> +
>   	amdgpu_dm_register_backlight_device(amdgpu_dm_connector);
>   
>   	if ((connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort) ||