Received-SPF: pass (google.com: domain of linux-kernel+bounces-50199-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Fri, 2 Feb 2024 18:04:12 +0100
From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Nishanth Menon <nm@ti.com>
Cc: Andrew Davis <afd@ti.com>, Tero Kristo <kristo@kernel.org>, 
	Santosh Shilimkar <ssantosh@kernel.org>, Rob Herring <robh+dt@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, 
	Vignesh Raghavendra <vigneshr@ti.com>, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, 
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH 03/12] power: reset: Add TI-SCI reboot driver
Message-ID: <xdrdaasaosjagr35ftb56yszwlrcf5bzpsnui5crut2ii7nu7n@apxciqrwluwr>
References: <20240131221957.213717-1-afd@ti.com>
 <20240131221957.213717-4-afd@ti.com>
 <20240201211534.dv6qu7ila54vqykn@cheating>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="pzni7lzp76a4ycxf"
Content-Disposition: inline
In-Reply-To: <20240201211534.dv6qu7ila54vqykn@cheating>


--pzni7lzp76a4ycxf
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Thu, Feb 01, 2024 at 03:15:34PM -0600, Nishanth Menon wrote:
> On 16:19-20240131, Andrew Davis wrote:
> > This reboot driver calls into firmware using TI-SCI to reboot the syste=
m.
> > We register the handler with low priority as we want PSCI to remain the
> > main way these devices are rebooted. This driver acts as a fallback if
> > PSCI is not able to reboot the system.
> >=20
> > Signed-off-by: Andrew Davis <afd@ti.com>
> > ---
> >  MAINTAINERS                         |  1 +
> >  drivers/power/reset/Kconfig         |  7 ++++
> >  drivers/power/reset/Makefile        |  1 +
> >  drivers/power/reset/ti-sci-reboot.c | 63 +++++++++++++++++++++++++++++
> >  4 files changed, 72 insertions(+)
> >  create mode 100644 drivers/power/reset/ti-sci-reboot.c
> >=20
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 45983bb174fe4..ee67ea497fc56 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -21758,6 +21758,7 @@ F:	drivers/clk/keystone/sci-clk.c
> >  F:	drivers/firmware/ti_sci*
> >  F:	drivers/irqchip/irq-ti-sci-inta.c
> >  F:	drivers/irqchip/irq-ti-sci-intr.c
> > +F:	drivers/power/reset/ti-sci-reboot.c
> >  F:	drivers/reset/reset-ti-sci.c
> >  F:	drivers/soc/ti/ti_sci_inta_msi.c
> >  F:	drivers/pmdomain/ti/ti_sci_pm_domains.c
> > diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig
> > index fece990af4a75..d3e91e54cae24 100644
> > --- a/drivers/power/reset/Kconfig
> > +++ b/drivers/power/reset/Kconfig
> > @@ -205,6 +205,13 @@ config POWER_RESET_ST
> >  	help
> >  	  Reset support for STMicroelectronics boards.
> > =20
> > +config POWER_RESET_TI_SCI
> > +	tristate "TI System Control Interface (TI-SCI) reboot driver"
> > +	depends on TI_SCI_PROTOCOL
> > +	help
> > +	  This enables the reboot driver support over TI System Control
> > +	  Interface available on some TI's SoCs.
> > +
> >  config POWER_RESET_TPS65086
> >  	bool "TPS65086 restart driver"
> >  	depends on MFD_TPS65086
> > diff --git a/drivers/power/reset/Makefile b/drivers/power/reset/Makefile
> > index a95d1bd275d18..881ca58a43b9c 100644
> > --- a/drivers/power/reset/Makefile
> > +++ b/drivers/power/reset/Makefile
> > @@ -23,6 +23,7 @@ obj-$(CONFIG_POWER_RESET_QNAP) +=3D qnap-poweroff.o
> >  obj-$(CONFIG_POWER_RESET_REGULATOR) +=3D regulator-poweroff.o
> >  obj-$(CONFIG_POWER_RESET_RESTART) +=3D restart-poweroff.o
> >  obj-$(CONFIG_POWER_RESET_ST) +=3D st-poweroff.o
> > +obj-$(CONFIG_POWER_RESET_TI_SCI) +=3D ti-sci-reboot.o
> >  obj-$(CONFIG_POWER_RESET_TPS65086) +=3D tps65086-restart.o
> >  obj-$(CONFIG_POWER_RESET_VERSATILE) +=3D arm-versatile-reboot.o
> >  obj-$(CONFIG_POWER_RESET_VEXPRESS) +=3D vexpress-poweroff.o
> > diff --git a/drivers/power/reset/ti-sci-reboot.c b/drivers/power/reset/=
ti-sci-reboot.c
> > new file mode 100644
> > index 0000000000000..400bd5d740f8b
> > --- /dev/null
> > +++ b/drivers/power/reset/ti-sci-reboot.c
> > @@ -0,0 +1,63 @@
> > +// SPDX-License-Identifier: GPL-2.0-only
> > +/*
> > + * Texas Instrument's System Control Interface (TI-SCI) reboot driver
> > + *
> > + * Copyright (C) 2024 Texas Instruments Incorporated - https://www.ti.=
com/
> > + *	Andrew Davis <afd@ti.com>
> > + */
> > +
> > +#include <linux/mod_devicetable.h>
> > +#include <linux/module.h>
> > +#include <linux/platform_device.h>
> > +#include <linux/reboot.h>
> > +
> > +#include <linux/soc/ti/ti_sci_protocol.h>
> > +
> > +static int ti_sci_reboot_handler(struct sys_off_data *data)
> > +{
> > +	const struct ti_sci_handle *sci =3D data->cb_data;
> > +	const struct ti_sci_core_ops *core_ops =3D &sci->ops.core_ops;
> > +
> > +	core_ops->reboot_device(sci);
> > +
> > +	return NOTIFY_DONE;
> > +}
> > +
> > +static int ti_sci_reboot_probe(struct platform_device *pdev)
> > +{
> > +	const struct ti_sci_handle *sci;
> > +	int err;
> > +
> > +	sci =3D devm_ti_sci_get_handle(&pdev->dev);
> > +	if (IS_ERR(sci))
> > +		return PTR_ERR(sci);
> > +
> > +	err =3D devm_register_sys_off_handler(&pdev->dev,
> > +					    SYS_OFF_MODE_RESTART,
> > +					    SYS_OFF_PRIO_LOW,
> > +					    ti_sci_reboot_handler,
> > +					    (void *)sci);
> > +	if (err)
> > +		return dev_err_probe(&pdev->dev, err, "Cannot register restart handl=
er\n");
> > +
> > +	return 0;
> > +}
> > +
> > +static const struct of_device_id ti_sci_reboot_of_match[] =3D {
> > +	{ .compatible =3D "ti,sci-reboot", },
> > +	{ /* sentinel */ },
> > +};
> > +MODULE_DEVICE_TABLE(of, ti_sci_reboot_of_match);
> > +
> > +static struct platform_driver ti_sci_reboot_driver =3D {
> > +	.probe =3D ti_sci_reboot_probe,
> > +	.driver =3D {
> > +		.name =3D "ti-sci-reboot",
> > +		.of_match_table =3D ti_sci_reboot_of_match,
> > +	},
> > +};
> > +module_platform_driver(ti_sci_reboot_driver);
> > +
> > +MODULE_AUTHOR("Andrew Davis <afd@ti.com>");
> > +MODULE_DESCRIPTION("TI System Control Interface (TI SCI) Reboot driver=
");
> > +MODULE_LICENSE("GPL");
> > --=20
> > 2.39.2
>=20
> Will assume the patch to go via Sebastien. Will be good for the dts to
> go via SoC tree. So hoping Sebastien will just pick the driver and
> bindings.

I will wait for the DT binding discussion to have settled. The
driver itself LGTM.

-- Sebastian

--pzni7lzp76a4ycxf
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmW9IIMACgkQ2O7X88g7
+poPVhAAhZtyxfQ0GDuYExpKNvR0PJYXbvA6n9jzOfg5v8ocwQoWCAEHxB0Stujq
W/hnOMJqQ7mPtDTmX3YAvGjak0ZZO8uBU4duj2ygS7szoJ0cOaOGSyDjDgvV2OnH
Tq+dv1s4P/Ex7bvs+jedaz8HFNK+Bq9YGyc58liCEv8OBWQ9dIkuQ37sA8Bf3HnL
V32FKMfW/Y640MIJ7J4EvteQPNWgb/UnobKLLQdoXgMHCkdoze3y0RNbDgdbuFvy
Amo+d/Y5Sachm21BoKKgrrw9/cVjiYl6LDcmPZoRCfNDA39d1HEI2gYovx8oet1z
eJAkLIA7nYPEKRPYYNObfeYFDSmxlYqE+mx1CGkieDh9qrlYo20bHxrZcjuWhTDV
ThMUw1wTAw0TwJZPgO4F2X53mmFf5bO5yebayCq0wUawVFqUdePj/KIjZRJCdVjL
dyhR1djDstBSdOwUCyv1KXltvFDhwrUx4GOFn7HUEmXqwM4kfuy0DeKZKFoagrdY
RnZaTcXKHof60XZJhkorunklTGMQAese+v8KKlaO+2GvyfD91Cm5BHtecL4nUt1n
ZVa5mPy+gYX6QcFjQYfwHn5RtApsX195b62wCV6fsZ0m5HxScyvDaClNEaGGqCdH
2k+f4aNCSyRb52HdgRAf7bajqWe3o6PTfLvxFsnJpIb1s+7RhZw=
=Qr8y
-----END PGP SIGNATURE-----

--pzni7lzp76a4ycxf--