Received-SPF: pass (google.com: domain of linux-kernel+bounces-50277-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Fri, 2 Feb 2024 11:56:31 -0600
From: David Vernet <void@manifault.com>
To: Valentin Schneider <vschneid@redhat.com>
Cc: linux-kernel@vger.kernel.org, mingo@redhat.com, peterz@infradead.org,
	juri.lelli@redhat.com, vincent.guittot@linaro.org,
	dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com,
	mgorman@suse.de, bristot@redhat.com, kernel-team@meta.com
Subject: Re: [PATCH] sched/fair: Simplify some logic in
 update_sd_pick_busiest()
Message-ID: <20240202175631.GB2242043@maniforge>
References: <20240202070216.2238392-1-void@manifault.com>
 <xhsmhwmrmhkbh.mognet@vschneid-thinkpadt14sgen2i.remote.csb>
 <20240202170712.GC2238525@maniforge>
 <xhsmhplxehiii.mognet@vschneid-thinkpadt14sgen2i.remote.csb>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="jOWiPU0TXI0BALpG"
Content-Disposition: inline
In-Reply-To: <xhsmhplxehiii.mognet@vschneid-thinkpadt14sgen2i.remote.csb>
User-Agent: Mutt/2.2.12 (2023-09-09)


--jOWiPU0TXI0BALpG
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Feb 02, 2024 at 06:40:21PM +0100, Valentin Schneider wrote:
> On 02/02/24 11:07, David Vernet wrote:
> > On Fri, Feb 02, 2024 at 06:01:22PM +0100, Valentin Schneider wrote:
> >> On 02/02/24 01:02, David Vernet wrote:
> >> > When comparing the current struct sched_group with the yet-busiest
> >> > domain in update_sd_pick_busiest(), if the two groups have the same
> >> > group type, we're currently doing a bit of unnecessary work for any
> >> > group >=3D group_misfit_task. We're comparing the two groups, and th=
en
> >> > returning only if false (the group in question is not the busiest).
> >> > Othewise, we break, do an extra unnecessary conditional check that's
> >> > vacuously false for any group type > group_fully_busy, and then alwa=
ys
> >> > return true.
> >> >
> >> > Let's just return directly in the switch statement instead. This doe=
sn't
> >> > change the size of vmlinux with llvm 17 (not surprising given that a=
ll
> >> > of this is inlined in load_balance()), but it does shrink load_balan=
ce()
> >> > by 88 bytes on x86. Given that it also improves readability, this se=
ems
> >> > worth doing.
> >> >
> >> > As a bonus, remove an unnecessary goto in update_sd_lb_stats().
> >> >
> >>
> >> Given that's a different scope than what the rest of the patch touches=
, I'd
> >> rather see this as a separate patch.
> >>
> >> Other than that:
> >> Reviewed-by: Valentin Schneider <vschneid@redhat.com>
> >
> > Thanks, would you like me to send a follow-on series split into two with
> > your tag on both? Or were you just letting me know for next time?
> >
>=20
> Well, I'm not picking up any patches, just reviewing them :) So yes I'd s=
ay
> re-send with the split and feel free to apply the tag on both.

Sounds good, I'll send a follow up at some point tomorrow or early next
week.

> > We could also update this check to only do a strict greater than to
> > avoid unnecessary writes, but I figured it was preferable to have no
> > logical changes for this iteration:
> >
> > return sgs->group_misfit_task_load >=3D busiest->group_misfit_task_load;
>=20
> That's a good point, I don't think there was a specific reason for going
> with a lower-than rather than a lower-or-equal back then:
>   cad68e552e77 ("sched/fair: Consider misfit tasks when load-balancing")

Yeah, the goal is to choose the group with the highest misfit task load,
so it seems pretty straightforward that we don't gain anything from
choosing a new group that has the same load as the previous busiest.

When I send out the follow-on patch set, I'll do it as 3 separate
patches (unless I hear otherwise from someone else).

Thanks,
David

--jOWiPU0TXI0BALpG
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQRBxU1So5MTLwphjdFZ5LhpZcTzZAUCZb0szwAKCRBZ5LhpZcTz
ZLTeAQDp8vOHWhXmypFIC6jR53ETfpojXRURZIZ7GzJQKDEjRQD9E8/5EgRW9nUv
gDYlB2VRA+JVJ7QHqRKXuMJxdM+GRAk=
=owuw
-----END PGP SIGNATURE-----

--jOWiPU0TXI0BALpG--