Received-SPF: pass (google.com: domain of linux-kernel+bounces-50281-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240129202741.3424902-1-aahila@google.com> <ZbvFEtQskK3xzi6y@nanopsycho>
 <CAGfWUPzeWeF-XPGem=VqxG=DaOEMRWnjCcueD+ODsEKLczDEMA@mail.gmail.com> <ZbyXJu0ZO4sZfrV2@nanopsycho>
In-Reply-To: <ZbyXJu0ZO4sZfrV2@nanopsycho>
From: Aahil Awatramani <aahila@google.com>
Date: Fri, 2 Feb 2024 09:59:30 -0800
Message-ID: <CAGfWUPyaSrmWG9eY+TgBwmzP4eHoLf4S8L1HVCGr9p+Akkh5Rg@mail.gmail.com>
Subject: Re: [PATCH net-next v6] bonding: Add independent control state machine
To: Jiri Pirko <jiri@resnulli.us>
Cc: David Dillow <dave@thedillows.org>, Mahesh Bandewar <maheshb@google.com>, 
	Jay Vosburgh <j.vosburgh@gmail.com>, Hangbin Liu <liuhangbin@gmail.com>, 
	Andy Gospodarek <andy@greyhouse.net>, "David S . Miller" <davem@davemloft.net>, 
	Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, 
	Martin KaFai Lau <martin.lau@kernel.org>, Herbert Xu <herbert@gondor.apana.org.au>, 
	Daniel Borkmann <daniel@iogearbox.net>, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

> Don't touch procfs here.

OK removing procfs changes.


On Thu, Feb 1, 2024 at 11:18=E2=80=AFPM Jiri Pirko <jiri@resnulli.us> wrote=
:
>
> Thu, Feb 01, 2024 at 07:45:23PM CET, aahila@google.com wrote:
> >> Any chance we can have some coverage via self-tests?
> >
> >I plan to work on these self-tests decoupled from the current patch.
> >
> >> Hmm, I wonder how it makes sense to add new features here. This should
> >> rot.
> >
> >Could you clarify what you are suggesting here?
>
> Don't touch procfs here.
>
> >
> >
> >On Thu, Feb 1, 2024 at 8:28=E2=80=AFAM Jiri Pirko <jiri@resnulli.us> wro=
te:
> >>
> >> Mon, Jan 29, 2024 at 09:27:41PM CET, aahila@google.com wrote:
> >>
> >> [...]
> >>
> >>
> >> >diff --git a/drivers/net/bonding/bond_procfs.c b/drivers/net/bonding/=
bond_procfs.c
> >> >index 43be458422b3..95d88df94756 100644
> >> >--- a/drivers/net/bonding/bond_procfs.c
> >> >+++ b/drivers/net/bonding/bond_procfs.c
> >> >@@ -154,6 +154,8 @@ static void bond_info_show_master(struct seq_file=
 *seq)
> >> >                          (bond->params.lacp_active) ? "on" : "off");
> >> >               seq_printf(seq, "LACP rate: %s\n",
> >> >                          (bond->params.lacp_fast) ? "fast" : "slow")=
;
> >> >+              seq_printf(seq, "LACP coupled_control: %s\n",
> >> >+                         (bond->params.coupled_control) ? "on" : "of=
f");
> >>
> >> Hmm, I wonder how it makes sense to add new features here. This should
> >> rot.
> >>
> >>
> >> >               seq_printf(seq, "Min links: %d\n", bond->params.min_li=
nks);
> >> >               optval =3D bond_opt_get_val(BOND_OPT_AD_SELECT,
> >> >                                         bond->params.ad_select);
> >>
> >> [...]