Received-SPF: pass (google.com: domain of linux-kernel+bounces-50465-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Sender: Guenter Roeck <groeck7@gmail.com>
Date: Fri, 2 Feb 2024 11:08:41 -0800
From: Guenter Roeck <linux@roeck-us.net>
To: Aleksa Savic <savicaleksa83@gmail.com>
Cc: linux-hwmon@vger.kernel.org, Jonas Malaco <jonas@protocubo.io>,
	Yury Zhuravlev <stalkerg@gmail.com>,
	Jean Delvare <jdelvare@suse.com>, Jonathan Corbet <corbet@lwn.net>,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: Add driver for NZXT Kraken X and Z series AIO CPU
 coolers
Message-ID: <c4ecb715-ec25-416e-a893-6e9eecb37409@roeck-us.net>
References: <20240129111932.368232-1-savicaleksa83@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240129111932.368232-1-savicaleksa83@gmail.com>

On Mon, Jan 29, 2024 at 12:19:28PM +0100, Aleksa Savic wrote:
> This driver enables hardware monitoring support for NZXT Kraken
> X53/X63/X73 and Z53/Z63/Z73 all-in-one CPU liquid coolers.
> 
> All models expose liquid temperature and pump speed (in RPM), as well as
> PWM control (natively only through a temp-PWM curve, but the driver also
> emulates fixed PWM control on top of that). The Z-series models
> additionally expose the speed and duty of an optionally connected fan,
> with the same PWM control capabilities.
> 
> Pump and fan duty control mode can be set through pwm[1-2]_enable,
> where 1 is for the manual control mode and 2 is for the liquid temp
> to PWM curve mode. Writing a 0 disables control of the channel through
> the driver after setting its duty to 100%. As it is not possible to query
> the device for the active mode, the driver keeps track of it.
> 
> The temperature of the curves relates to the fixed [20-59] C range, per
> device limitations, and correlating to the detected liquid temperature.
> Only PWM values (ranging from 0-255) can be set.
> 
> The addressable RGB LEDs and LCD screen, included only on Z-series models,
> are not supported in this driver.
> 
> Co-developed-by: Jonas Malaco <jonas@protocubo.io>
> Signed-off-by: Jonas Malaco <jonas@protocubo.io>
> Co-developed-by: Yury Zhuravlev <stalkerg@gmail.com>
> Signed-off-by: Yury Zhuravlev <stalkerg@gmail.com>
> Signed-off-by: Aleksa Savic <savicaleksa83@gmail.com>

Applied.

Thanks,
Guenter