Received-SPF: pass (google.com: domain of linux-kernel+bounces-50475-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Fri, 2 Feb 2024 14:21:37 -0500
From: "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To: Jeff Xu <jeffxu@chromium.org>
Cc: Jeff Xu <jeffxu@google.com>, Jonathan Corbet <corbet@lwn.net>,
        akpm@linux-foundation.org, keescook@chromium.org, jannh@google.com,
        sroettger@google.com, willy@infradead.org, gregkh@linuxfoundation.org,
        torvalds@linux-foundation.org, usama.anjum@collabora.com,
        rdunlap@infradead.org, jorgelo@chromium.org, groeck@chromium.org,
        linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
        linux-mm@kvack.org, pedro.falcato@gmail.com, dave.hansen@intel.com,
        linux-hardening@vger.kernel.org, deraadt@openbsd.org
Subject: Re: [PATCH v8 0/4] Introduce mseal
Message-ID: <20240202192137.6lupguvhtdt72rbr@revolver>
Mail-Followup-To: "Liam R. Howlett" <Liam.Howlett@Oracle.com>,
	Jeff Xu <jeffxu@chromium.org>, Jeff Xu <jeffxu@google.com>,
	Jonathan Corbet <corbet@lwn.net>, akpm@linux-foundation.org,
	keescook@chromium.org, jannh@google.com, sroettger@google.com,
	willy@infradead.org, gregkh@linuxfoundation.org,
	torvalds@linux-foundation.org, usama.anjum@collabora.com,
	rdunlap@infradead.org, jorgelo@chromium.org, groeck@chromium.org,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	linux-mm@kvack.org, pedro.falcato@gmail.com, dave.hansen@intel.com,
	linux-hardening@vger.kernel.org, deraadt@openbsd.org
References: <20240131175027.3287009-1-jeffxu@chromium.org>
 <20240131193411.opisg5yoyxkwoyil@revolver>
 <CABi2SkXOX4SRMs0y8FYccoj+XrEiPCJk2seqT+sgO7Na7NWwLg@mail.gmail.com>
 <20240201204512.ht3e33yj77kkxi4q@revolver>
 <CALmYWFupdK_wc6jaamjbrZf-PzHwJ_4=b69yCtAik_7uu3hZug@mail.gmail.com>
 <20240202151345.kj4nhb5uog4aknsp@revolver>
 <CABi2SkUSWLHM5KD=eK9bJrt3bBsEaB3gEpvJgr0LSTAE2G00Tg@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CABi2SkUSWLHM5KD=eK9bJrt3bBsEaB3gEpvJgr0LSTAE2G00Tg@mail.gmail.com>
User-Agent: NeoMutt/20220429
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?DLZwYDMspeJ7da+DgJJfWHDSswMdhuArQdcr4EtsZngqygLfAx1qXyKzgG7h?=
 =?us-ascii?Q?KW7RFMqH0GX5gziclXJW64YLmCV4QXKRx8J4D/oVq8RoSfz1SC3fgwXjui7T?=
 =?us-ascii?Q?ksKwJzzYnSeZyZortaeyYVOIsJwzYs0T95oAxD19doBrtTxNxKbRlK3cIPoy?=
 =?us-ascii?Q?+agteLUW4eeOMPcXsueWDG0Mz+VjOdCIenlwnEIEyR0sv6EKYFR0RR5es1wP?=
 =?us-ascii?Q?vqWNi6dKaZJLeNu8lLvL/zEXte7ce4woqLrDNf1EJWkfOdu+VcGM2Uns7GdN?=
 =?us-ascii?Q?crPH3smcTAWXGloFNdKeUEDly2emss51ICrxWcz4pINTkB8DpVrfyM3UECba?=
 =?us-ascii?Q?FMWVb3UPCtrn70IcgrHaSflvQbLz9921SMfcDGZVuLaaptW01i4NJStaqvvT?=
 =?us-ascii?Q?eeBOinvR8KazZs4k6N0rvsJ556CKbcjcR2hFtTCOnXhL4bUXkvgBGSYYk6+T?=
 =?us-ascii?Q?VkDaQVQjmMtNsFwJ78tWEqH8bNSTwvLGtUt2/eZE2xZBRbUVgprlOAARTGYE?=
 =?us-ascii?Q?DvmNOf62duhmAkKykacYv4F04R0cH9FtbrAbqB6CrU6dxc6HnAGIe3T9lYqU?=
 =?us-ascii?Q?U4G4zkF8aj+YomFHasJnH4kT6mnqpbTPBR83hzKIY09bE1EhG9c3A4VFFepB?=
 =?us-ascii?Q?ebm2mes/r+O7XYEHzhs1jPHTp6VK85Q8zqTesDYrvfW2UdxflkP/to7ueSL1?=
 =?us-ascii?Q?/pZDnQj1YeGiocJ2Pbz03pRLQntCIIoTA6DDmLhvpCS6fLGO6yiEjn7BEjKt?=
 =?us-ascii?Q?zHHNGUyEDVuj6+kLCi1b6HHu12pAtUfavVeWl8iSc0zfTaZPorih2w6kuuBH?=
 =?us-ascii?Q?djd4/87c3FliYBAJHL6pmJcQzjitSkQAJrxWlVeXGGYFplFo0yg9Cuut+aRB?=
 =?us-ascii?Q?ABquZquX5r6s0AU/LtTtjl8TPlMAyyj22A6UQ+YeiMdNMHTqhy3OY37FzsXn?=
 =?us-ascii?Q?cwqGJrlObG2yZ8lJ7vTVF2p5twZLsn9F/fYVZJYZQyTOyix/ZQ1nUe4WQgzh?=
 =?us-ascii?Q?3km0tvqJdHFFqx7DAog2DLk2UcqJsPwp67vxpkl38+PoGxLO7orZnlde6iYS?=
 =?us-ascii?Q?rlLpmxAxkqvscCJiQys4AtP9vxziSjDnAPZfdHEyR0+b9B+5LbeKMgUhokG+?=
 =?us-ascii?Q?kSW3vYEI2lQtyugA0Boma4cUxv5Wtt8Xh4xrmbAdAUe/o2GjsSnpApvW3ukN?=
 =?us-ascii?Q?vOhu8cxycMepg5mlq01ohiFcmNWCZ2+XkVHTlOGhP9/d7npriWbGelAHH/St?=
 =?us-ascii?Q?dr4iozpYTdGzsHMfIiKW+i2dIueuHOtd2u20OFHlBP2EF3pnq4Ykl8MeNk+J?=
 =?us-ascii?Q?vo2i92pfln3Jv/domaOWqaFBPurFwGkdKUatZZyv5vwRSOJ5zSlgQ3JbHSCi?=
 =?us-ascii?Q?NfCdMsSJGo7aKgeQs4IBZoZ4IqZhDy/m2JeDQed4UreciGyE2gaaHtgi/cuw?=
 =?us-ascii?Q?p5PxRA+doKr61CInaoO3GrwtEm+F0lm8kVLYjzhXr09vUd+NtdlZf+P9zDgk?=
 =?us-ascii?Q?ggq21ewjwvUuT3vLkmk8TOpm9vQnBUKt3lkmfUDpsFDRNj4Ll4OIQX/VToPx?=
 =?us-ascii?Q?Huh+kcw6ungc6WD9MrWfCKtD+GucatkLTzn19IIwyFDE4HCWYknxhI/a+3sI?=
 =?us-ascii?Q?wA=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	peBma6ZZPUVp+QvFNLr1Fhb2HE/koBVR17OMS3bKd5rl7zaqrB+GTVt//wk3s7DgBmmaniyhi7F8ScqKatMqe28euW0zky1N4PVxQTSA8WaIchzszcJAGRRdAxWJIS2PUtfXzA7rCjrlipXKFm+ykFCiocit9DjHnQWGzXrrMS4RIKSvsl3SV6kaVophFXN+x/4JMnidRrczlq+wgm1gpfXNE1DsDDm4ZVwnQ68LS8kCaTnqqWIPOJFVZoaI+T94HLyHKsqBwClxX2zJIZQVkfzTmqN6SM3kc30Z8Jsonl1JmSoz/FSWXlpNW2uHgMZVPFxF13W/JXlTaQHOk5kUMxv2nyS0BfVWHn3cpET9LNWRewf5v/yZ9QYZPEh70kukrWi4Eaoe+79o3/hahCwwemttqVrLkr8Ib6VmnnpbvK4OKFhPH9qFRGPBKPM0vh96zW2jt3dP3rx5d4btvAIGYFiWBWZB4nFU4oDH1PGbCmLdHmzL6Zt1xSpI2plU0CLZJYCbXi/ezPQcSdUHMe9PbHJO25b3YH8b5hFmhRAKgLdtd7A0Eolc6ocsMFCi7I50nyUmLZidR2FF6fHmxn9aYDpzEwWgSa8B71h9lo3m6rc=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3097f50b-3213-4db8-e805-08dc24242e96
X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7933.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2024 19:21:39.9919
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9DqFJlC0t97DVY9fFVEmFSiuXPZRsvZj4I11Ku07MR3OcDftiHtfYYrOWixFbuTWmgnkzCTW9PqtOf+pYh/6dg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4516
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-02_12,2024-01-31_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 malwarescore=0 mlxscore=0
 spamscore=0 suspectscore=0 adultscore=0 mlxlogscore=993 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2402020141
X-Proofpoint-GUID: DqaPrQK9rduC13xKgmjCKsD5ivhWP3zb
X-Proofpoint-ORIG-GUID: DqaPrQK9rduC13xKgmjCKsD5ivhWP3zb

* Jeff Xu <jeffxu@chromium.org> [240202 12:24]:

..

> > Provide code that uses this feature.

Please do this too :)

> >
> > Provide benchmark results where you apply mseal to 1, 2, 4, 8, 16, and
> > 32 VMAs.
> >
> I will prepare for the benchmark tests.

Thank you, please also include runs of calls that you are modifying for
checking for mseal() as we are adding loops there.

> 
> > Provide code that tests and checks the failure paths.  Failures at the
> > start, middle, and end of the modifications.
> >
> Regarding, "Failures at the start, middle, and end of the modifications."
> 
> With the current implementation, e.g. it checks if the sealing is
> applied before actual modification of VMAs, so partial modifications
> are avoided in mprotect, mremap, munmap.
> 
> There are test cases in the selftests to cover the failure path,
> including the beginning, middle and end of VMAs.
> test_seal_unmapped_start
> test_seal_unmapped_middle
> test_seal_unmapped_end
> test_seal_invalid_input
> test_seal_start_mprotect
> test_seal_end_mprotect
> etc.
> 
> Are those what you are looking for ?

Those are certainly good, but we need more checking in there.  You have
a seal_split test that splits the vma by mseal but you don't check the
flags on the VMAs.

What I'm more concerned about is what happens if you call mseal() on a
range and it can mseal a portion.  Like, what happens to the first vma
in your test_seal_unmapped_middle case?  I see it returns an error, but
is the first VMA mseal()'ed? (no it's not, but test that)

What about the other system calls that will be denied on an mseal() VMA?
Do they still behave the same?  do_mprotect_pkey() will break out of the
loop on the first error it sees - but it has modified some VMAs up to
that point, I believe?  You have changed this to abort before anything
is modified.  This is probably acceptable because it won't affect
existing applications unless they start using mseal(), but that's just
my opinion.

It would be good to state the change in behaviour because it is changing
the fundamental model of changing mprotect/madvise until an issue is
hit.  I think you are covering this by "it blocks X" but it's doing more
than, say, a flag verification.  One could reasonably assume this is
just another flag verification.

> 
> > Document what happens in those failure paths.

I'd like to know how this affects other system calls in the partial
success cases/return error cases.  Some will now return new error codes
and some may change the behaviour.

It may even be okay to allow munmap() to split VMAs at the start/end of
the region and fail to munmap because some VMA in the middle is
mseal()'ed - but maybe not?  I haven't put a whole lot of thought into
it.

Thanks,
Liam