Received-SPF: pass (google.com: domain of linux-kernel+bounces-50468-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Sender: Guenter Roeck <groeck7@gmail.com>
Date: Fri, 2 Feb 2024 11:11:42 -0800
From: Guenter Roeck <linux@roeck-us.net>
To: Aleksa Savic <savicaleksa83@gmail.com>
Cc: linux-hwmon@vger.kernel.org,
	Florian Freudiger <florian.freudiger@proton.me>,
	Jean Delvare <jdelvare@suse.com>, Jonathan Corbet <corbet@lwn.net>,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: Add driver for ASUS ROG RYUJIN II 360 AIO cooler
Message-ID: <903cb262-719f-46f7-9029-43dd5be5c798@roeck-us.net>
References: <20240108094453.22986-1-savicaleksa83@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240108094453.22986-1-savicaleksa83@gmail.com>

On Mon, Jan 08, 2024 at 10:44:50AM +0100, Aleksa Savic wrote:
> This driver exposes hardware sensors of the ASUS ROG RYUJIN II 360
> all-in-one CPU liquid cooler, which communicates through a proprietary
> USB HID protocol. Report offsets were initially discovered in [1] by
> Florian Freudiger.
> 
> Available sensors are pump, internal and external
> (controller) fan speed in RPM, their duties in PWM, as well as
> coolant temperature.
> 
> Attaching external fans to the controller is optional and allows them
> to be controlled from the device. If not connected, the fan-related
> sensors will report zeroes. The controller is a separate hardware unit
> that comes bundled with the AIO and connects to it to allow fan control.
> 
> The addressable LCD screen is not supported in this
> driver and should be controlled through userspace tools.
> 
> [1]: https://github.com/liquidctl/liquidctl/pull/653
> 
> Tested-by: Florian Freudiger <florian.freudiger@proton.me>
> Signed-off-by: Aleksa Savic <savicaleksa83@gmail.com>

Applied.

Thanks,
Guenter