Received-SPF: pass (google.com: domain of linux-kernel+bounces-50531-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 2 Feb 2024 12:14:16 -0800
From: Dan Williams <dan.j.williams@intel.com>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>, Dan Williams
	<dan.j.williams@intel.com>, Arnd Bergmann <arnd@arndb.de>, Dave Chinner
	<david@fromorbit.com>
CC: <linux-kernel@vger.kernel.org>, Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>, <linux-mm@kvack.org>,
	<linux-arch@vger.kernel.org>, Vishal Verma <vishal.l.verma@intel.com>, "Dave
 Jiang" <dave.jiang@intel.com>, Matthew Wilcox <willy@infradead.org>, "Russell
 King" <linux@armlinux.org.uk>, <nvdimm@lists.linux.dev>,
	<linux-cxl@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>,
	<dm-devel@lists.linux.dev>
Subject: Re: [RFC PATCH v3 2/4] dax: Check for data cache aliasing at runtime
Message-ID: <65bd4d18cab98_7193229421@dwillia2-mobl3.amr.corp.intel.com.notmuch>
References: <20240131162533.247710-1-mathieu.desnoyers@efficios.com>
 <20240131162533.247710-3-mathieu.desnoyers@efficios.com>
 <65bab567665f3_37ad2943c@dwillia2-xfh.jf.intel.com.notmuch>
 <0a38176b-c453-4be0-be83-f3e1bb897973@efficios.com>
 <65bac71a9659b_37ad29428@dwillia2-xfh.jf.intel.com.notmuch>
 <f1d14941-2d22-452a-99e6-42db806b6d7f@efficios.com>
 <65bd284165177_2d43c29443@dwillia2-mobl3.amr.corp.intel.com.notmuch>
 <6bdf6085-101d-47ef-86f4-87936622345a@efficios.com>
 <65bd457460fb1_719322942@dwillia2-mobl3.amr.corp.intel.com.notmuch>
 <5e838147-524c-40e5-b106-e388bf4e549b@efficios.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <5e838147-524c-40e5-b106-e388bf4e549b@efficios.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?gzKzF6ApSErPESjn2czsZRdmVAQsdgxswhTXAdmWE2TbYQIqI55GUO/IaOec?=
 =?us-ascii?Q?rNl3QIO/mN2hw/aEm50XcV/odi0pH7d9vksu8wt+fWw5rRHiPOa2A9sVKr8J?=
 =?us-ascii?Q?QY5wueIR3OlnKwtKfdjcBChjopBor2q6t9X8OIDX132BzmCAei9MdJtC1afF?=
 =?us-ascii?Q?lgZ3V/ziEYg0y8/coI/BbEAp668uTbZWodPvXSSze6DGLTFAo+cyhcjJ2+bu?=
 =?us-ascii?Q?HSIGbLUbNO/kWKOWHarI1dG4OioVQdjWVuCQmLryKxU45LoMA0uBLEU4Ub+E?=
 =?us-ascii?Q?RT3dDAdDeTpiwpDIvqlq6vvSHWVMCCWrbNFJlIrWEq2kVpP+Kx2s6wPLrKnC?=
 =?us-ascii?Q?spmpZTNCIOsbIfeb5boKQ13QKXB2A6zV6IG2DMWf6ccphf6eTr0EWMQ2rQXt?=
 =?us-ascii?Q?VD17QkGMQbzX8HhgiKH+vJ5XxrDj1rVN4bwtR+ZA4PAf+VMwJ6DkgvSDRba0?=
 =?us-ascii?Q?I/C7kTzwSZQhgc1MvWvqgePtJkUJC7aQQREjk+4zk2yPfN9K3w3LGqo0rHo+?=
 =?us-ascii?Q?qqEfI8kPUs6Q9YoLskQCFkSYiOiWi21Kuxf9a80eMuhCZYP9g2f7VGLsW+Gl?=
 =?us-ascii?Q?4zk2xYeytw0W/rfK2Gafq/4LMvQLiNWIpyUXBjeyyzqDdS6BRiiDq0daLgu6?=
 =?us-ascii?Q?UtfM0rwUT8GhsvIxoe5cpXO1p2fYGmTvZZ2+Fw4op7KXeifXhEt50tft4uPG?=
 =?us-ascii?Q?iSyeYTu+65ISqtGW62zQIH2TQOrY6mimq0bxNtRqqooAgPqNZ18Tt9l9QdGu?=
 =?us-ascii?Q?93y83n6gjqO85/vLPJ7rB8CIpxw42w77cgMc/ZOHxS6MDrdWQ9i7W/jU8VFf?=
 =?us-ascii?Q?q+0xV+AKDdRARakbW7wfeMO8NbuPHn/PTHr2e11eTe8IKM762PdpkutOh4SC?=
 =?us-ascii?Q?eSezgGn6XtqpgMClM5V7Acd+TzwzXSnFSbOqKdsfU7hSj290n4dkb+NOtV2M?=
 =?us-ascii?Q?IRdvw/WspHuEgb/U0YOqoLm4gkoydWN3e3F0ykcRWfgAEgzLh8ckvs55tyxK?=
 =?us-ascii?Q?VGaHf9+hcxunXvZ9FyL+18CmvpmWVBZxIUNf1eIlQim+DJQFxsxssd+Ae0eK?=
 =?us-ascii?Q?BLuA3RXnUidOhDp8OCiMTPoJEm0StKZ7A5j6Xw0LUeJuiaRiWypFLBqyB0of?=
 =?us-ascii?Q?XhShCE7KdXl2BC5FDq7B6bRV8NKJ1LxpubyBXS22hZ8vc0Ue4IlO/FNIe2HS?=
 =?us-ascii?Q?ZRqyEkaC5RhaBTAsmNd+kTQj+VbWrvBGz42PP14meM6ENjEECcKpa+6QMXaM?=
 =?us-ascii?Q?B+GmB4Ij0+TRXNYGQggQiYVBGEEYDwM8PDNH9SxfQU8ya2xzUorttFRmifc6?=
 =?us-ascii?Q?HakqgEgt56ccrS3uolc0ke3N+s0GBZyCXhdgnk62BGBcMVKQ+wFDbp3PgT/U?=
 =?us-ascii?Q?tFeXBnGjQ8L73jqwfJDikvdljTjCYYa4h91vFzMIxFsLv1HeR6NuA8Gej+2c?=
 =?us-ascii?Q?0UBMmCqSoqwZMKvBfKIqVG/itHulGMTJrB0xnpWjqhc2HeNoVuWjnqDOoLWU?=
 =?us-ascii?Q?mF3CHu10PLh+fMShdLS3lHEvrebvGdvSByZ5iNQI+D7HIUPqcj1OM55pkGBO?=
 =?us-ascii?Q?GG79ZnoCpjXgPydb+4mbs9cQFXJwrPG68SvN2A3IdSpt4MYNp6DkvNqtRv7a?=
 =?us-ascii?Q?+Q=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: bdab67eb-234c-460b-a795-08dc242b8a74
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2024 20:14:20.6075
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SSAIMMAXN6Ghc2YbALKdnBKtcyIFLdO+3FnJMpiK4V/vujCdTq/Zu02aQtW3b90ETDN02JAWENhLZmFT6Fg0xxwB+tkcyZ2VvE4JR6hbWZM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB7583
X-OriginatorOrg: intel.com

Mathieu Desnoyers wrote:
[..]
> > Thanks for that. All of those need to be done before the fs goes live
> > later in virtio_device_ready(), but before that point nothing should be
> > calling into virtio_fs_dax_ops, so as far as I can see it is safe to
> > change the order.
> 
> Sounds good, I'll do that.
> 
> I will soon be ready to send out a RFC v4, which is still only
> compiled-tested. Do you happen to have some kind of test suite
> you can use to automate some of the runtime testing ?

There is a test suite for the pmem, dm, and dax changes
(https://github.com/pmem/ndctl?tab=readme-ov-file#unit-tests), but not
automated unfortunately. The NVDIMM maintainer team will run that before
pushing patches out to the fixes branch if you just want to lean on
that. For the rest I think we will need to depend on tested-by's from
s390 + virtio_fs folks, and / or sufficient soak time in linux-next.