Received-SPF: pass (google.com: domain of linux-kernel+bounces-50538-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <f3ec50a5-ff5e-41ae-ab2f-7319a18381e2@efficios.com>
Date: Fri, 2 Feb 2024 15:18:36 -0500
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [RFC PATCH v3 2/4] dax: Check for data cache aliasing at runtime
Content-Language: en-US
To: Dan Williams <dan.j.williams@intel.com>, Arnd Bergmann <arnd@arndb.de>,
 Dave Chinner <david@fromorbit.com>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>,
 Linus Torvalds <torvalds@linux-foundation.org>, linux-mm@kvack.org,
 linux-arch@vger.kernel.org, Vishal Verma <vishal.l.verma@intel.com>,
 Dave Jiang <dave.jiang@intel.com>, Matthew Wilcox <willy@infradead.org>,
 Russell King <linux@armlinux.org.uk>, nvdimm@lists.linux.dev,
 linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org,
 dm-devel@lists.linux.dev
References: <20240131162533.247710-1-mathieu.desnoyers@efficios.com>
 <20240131162533.247710-3-mathieu.desnoyers@efficios.com>
 <65bab567665f3_37ad2943c@dwillia2-xfh.jf.intel.com.notmuch>
 <0a38176b-c453-4be0-be83-f3e1bb897973@efficios.com>
 <65bac71a9659b_37ad29428@dwillia2-xfh.jf.intel.com.notmuch>
 <f1d14941-2d22-452a-99e6-42db806b6d7f@efficios.com>
 <65bd284165177_2d43c29443@dwillia2-mobl3.amr.corp.intel.com.notmuch>
 <6bdf6085-101d-47ef-86f4-87936622345a@efficios.com>
 <65bd457460fb1_719322942@dwillia2-mobl3.amr.corp.intel.com.notmuch>
 <5e838147-524c-40e5-b106-e388bf4e549b@efficios.com>
 <65bd4d18cab98_7193229421@dwillia2-mobl3.amr.corp.intel.com.notmuch>
From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
In-Reply-To: <65bd4d18cab98_7193229421@dwillia2-mobl3.amr.corp.intel.com.notmuch>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 2024-02-02 15:14, Dan Williams wrote:
> Mathieu Desnoyers wrote:
> [..]
>>> Thanks for that. All of those need to be done before the fs goes live
>>> later in virtio_device_ready(), but before that point nothing should be
>>> calling into virtio_fs_dax_ops, so as far as I can see it is safe to
>>> change the order.
>>
>> Sounds good, I'll do that.
>>
>> I will soon be ready to send out a RFC v4, which is still only
>> compiled-tested. Do you happen to have some kind of test suite
>> you can use to automate some of the runtime testing ?
> 
> There is a test suite for the pmem, dm, and dax changes
> (https://github.com/pmem/ndctl?tab=readme-ov-file#unit-tests), but not
> automated unfortunately. The NVDIMM maintainer team will run that before
> pushing patches out to the fixes branch if you just want to lean on
> that. For the rest I think we will need to depend on tested-by's from
> s390 + virtio_fs folks, and / or sufficient soak time in linux-next.

I suspect this will be necessary. There are just so many combinations
of architectures, drivers and filesystems involved here that I don't
think it is realistic to try to do all this testing manually on my own.

I prefer to voice this up front, so there are no misplaced expectations
about testing.

Thanks,

Mathieu


-- 
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com