Received-SPF: pass (google.com: domain of linux-kernel+bounces-50115-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <e6127bb4-c423-4028-aed6-7357a90440d6@infradead.org>
Date: Fri, 2 Feb 2024 08:15:19 -0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH -next] ksmbd: Add kernel-doc for ksmbd_extract_sharename()
 function
Content-Language: en-US
To: Yang Li <yang.lee@linux.alibaba.com>, linkinjeon@kernel.org,
 sfrench@samba.org
Cc: senozhatsky@chromium.org, tom@talpey.com, linux-cifs@vger.kernel.org,
 linux-kernel@vger.kernel.org
References: <20240202081317.128980-1-yang.lee@linux.alibaba.com>
From: Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20240202081317.128980-1-yang.lee@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 2/2/24 00:13, Yang Li wrote:
> The ksmbd_extract_sharename() function lacked a complete kernel-doc
> comment. This patch adds parameter descriptions and detailed function
> behavior to improve code readability and maintainability.
> 
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>

Acked-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
>  fs/smb/server/misc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/smb/server/misc.c b/fs/smb/server/misc.c
> index 9e8afaa686e3..1a5faa6f6e7b 100644
> --- a/fs/smb/server/misc.c
> +++ b/fs/smb/server/misc.c
> @@ -261,6 +261,7 @@ char *ksmbd_casefold_sharename(struct unicode_map *um, const char *name)
>  
>  /**
>   * ksmbd_extract_sharename() - get share name from tree connect request
> + * @um: pointer to a unicode_map structure for character encoding handling
>   * @treename:	buffer containing tree name and share name
>   *
>   * Return:      share name on success, otherwise error

-- 
#Randy