Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp1078659rdb; Fri, 2 Feb 2024 12:58:01 -0800 (PST) X-Google-Smtp-Source: AGHT+IEDY+ax+Qtimokn2IBj/UX0UHMeEy8FguZoBXJQ4i9SDas1PLjmooIHkNfcysmhYt4EZix+ X-Received: by 2002:a2e:a783:0:b0:2cd:e963:b6c1 with SMTP id c3-20020a2ea783000000b002cde963b6c1mr8380149ljf.13.1706907481727; Fri, 02 Feb 2024 12:58:01 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706907481; cv=pass; d=google.com; s=arc-20160816; b=OPKCsskirI0dnXHkeX+FnwTlUH2qIvg6XxYXSO8TlJER1WVwPCA9SJ5HoT+syQnYFI S98RkUE1SY6RXygbG2zdOweFEZC09ljLK3ETHl0b0/ivXC1XV9DXVUQaB9e5gQ6bDuyy f5qCLOSgdHHsX7YB4j558RjVWZlkXNhPmQm1ML3hV9m9ROcShJz1WPPtRbXnXph10haq VQrqoSTcyLERIbpFQkJG+oCRI5ZU5y3efiijyL1SqXZsNhgG3kcqW7VXv29xH6YAKVkX sNzZq4QBd/kLIoFI5bmL+GPBBH+IXGQv/Q3XHUWHjFreY3Li2IdgCx6uHZLtb/CLxrLv WFeA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=Cyex+fGaWl3xNz9VOzEmPy+oYmdC8wTNZx9xwE1dUTA=; fh=7kPdt5m2GCVr62+nqlhfyx0rfBr1m4QcT4BQWuhr18Q=; b=gOVrk2NebMm3pJ1E5TVl94LJidqDqlLupl6ZSdpYOZnt+SyCNlqMdtICCMl9LKppyy /pbtRCRd3wvX4+imSb4bryZBEyqlj2ROK5udhLeFGYvghV2Qd+2xy1DfkrFlkSbcHJWK qCzukITxXFmQFUM/jagtqs6N2V+hEACQy+12IR3stu++cQ+Sf20dK4uOFSXDpL97+vPH Dni46uzANVQQ7ZEKD+iavrQhoUvdw6eiYWp+DKvozxzpdNz/IwkLmcQQObegB4FQvMTR +KGhAvciHenVGRdon2dhclzuU/SVJBLHoQ1eoadChy9qQLQPQPT35N+1MUa1mmUBTv+Y bKtw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="tkJyP0/G"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-50560-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-50560-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=1; AJvYcCWh9RMNLAZdoW6gQFGEcLatiEj+qliOIhc/zqhbdo5dOPrGkX7J5ZoOQ9ffGKixalS1ftRsqwliDMMxCHR0mhYPt4rFNrVDr2ht9060cQ== Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id a12-20020aa7d74c000000b0055fec51fafdsi1005725eds.646.2024.02.02.12.58.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Feb 2024 12:58:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-50560-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="tkJyP0/G"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-50560-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-50560-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 8B48D1F28CE7 for ; Fri, 2 Feb 2024 20:57:17 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 025807CF3F; Fri, 2 Feb 2024 20:57:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="tkJyP0/G" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A8257765D; Fri, 2 Feb 2024 20:57:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706907428; cv=none; b=hosPYypbQk9lyvftxyz6JsSNUKvVGwx/D4GRPlkewYHKYLKkhQ/j98V5hVN5HppzPvFEdZyGff6oinurLI4OvFxMnD1UPpibDC3UkYXz07x7+6T8GSfBWK3NrEWl1deuy+bTz34iSMm+wwO0wUumKrtYfc/gGXBLcuP6VhWxoO0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706907428; c=relaxed/simple; bh=frHQ/yeUekczVJm0BUTiuYzRV0/Mo1G2u+LCKvaWbT4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=LpMxsBPJ+Qxnx+rJSXSmJL3afNMHxdRZqdiLuwjFSkLdtzjYtJC0mt3II1zqC+evXYTHLVuAf7IxLWzTQ+CZ/UxqtxAp7H40Pu0fn1yP0DVanTFu72elgHbRiY9695Ped1MTSuqM5XG8KyxnQDkaf76hzXKzEHst7zx8eQc56JI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=tkJyP0/G; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3C352C433F1; Fri, 2 Feb 2024 20:57:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706907427; bh=frHQ/yeUekczVJm0BUTiuYzRV0/Mo1G2u+LCKvaWbT4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tkJyP0/GaIbGr1XNSGB1IbQvrGThxyjMuYY9rouzwDXcpBPGgx3MbI/ut+vnAqxmc EO6nwdXcxPbrv6N5kma6EyXRYx5W3aqBQ2XJJIERXLhTSSp+/aKqcYfhnN7Pi4MbIv xxhsOUm+RttKgkrm36Q8PNmsUejmWpVuc15kVbt7oLTkGhG5O/iJRFy8yMGPEt6zni PB/uirO3BsqWaImSka/Xb9bg230pCmVDMWYVlar3TYdgEZT9RF3X52+0Zby/CdvWNB 6QHQTVX1U5dX/2X+j/8TW3HxHTIpf3ul1btIVF94uhimdutd0GeGfSOvduKOUsWYRI 6mPBi+tP86DKg== From: Namhyung Kim To: Steven Rostedt , Adrian Hunter , Arnaldo Carvalho de Melo , Ze Gao , Alexander Shishkin , Jiri Olsa , Ingo Molnar , Peter Zijlstra , Ian Rogers , Mark Rutland Cc: Ze Gao , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] perf evsel: Rename get_states() to parse_task_states() and make it public Date: Fri, 2 Feb 2024 12:57:00 -0800 Message-ID: <170690725031.1264496.18004455069191563889.b4-ty@kernel.org> X-Mailer: git-send-email 2.43.0.594.gd9cf4e227d-goog In-Reply-To: <20240123070210.1669843-2-zegao@tencent.com> References: <20240122070859.1394479-2-zegao@tencent.com> <20240123070210.1669843-2-zegao@tencent.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit On Tue, 23 Jan 2024 02:02:11 -0500, Ze Gao wrote: > Since get_states() assumes the existence of libtraceevent, so move > to where it should belong, i.e, util/trace-event-parse.c, and also > rename it to parse_task_states(). > > Leave evsel_getstate() untouched as it fits well in the evsel > category. > > [...] Applied to perf-tools-next now, thanks for your work! Best regards, -- Namhyung Kim