Received-SPF: pass (google.com: domain of linux-kernel+bounces-50599-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Fri, 2 Feb 2024 16:18:07 -0500
From: "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Jeff Xu <jeffxu@chromium.org>, Jeff Xu <jeffxu@google.com>,
        Jonathan Corbet <corbet@lwn.net>, akpm@linux-foundation.org,
        keescook@chromium.org, jannh@google.com, sroettger@google.com,
        willy@infradead.org, gregkh@linuxfoundation.org,
        usama.anjum@collabora.com, rdunlap@infradead.org, jorgelo@chromium.org,
        groeck@chromium.org, linux-kernel@vger.kernel.org,
        linux-kselftest@vger.kernel.org, linux-mm@kvack.org,
        pedro.falcato@gmail.com, dave.hansen@intel.com,
        linux-hardening@vger.kernel.org
Subject: Re: [PATCH v8 0/4] Introduce mseal
Message-ID: <20240202211807.6sca4ppezma7cyev@revolver>
Mail-Followup-To: "Liam R. Howlett" <Liam.Howlett@Oracle.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Jeff Xu <jeffxu@chromium.org>, Jeff Xu <jeffxu@google.com>,
	Jonathan Corbet <corbet@lwn.net>, akpm@linux-foundation.org,
	keescook@chromium.org, jannh@google.com, sroettger@google.com,
	willy@infradead.org, gregkh@linuxfoundation.org,
	usama.anjum@collabora.com, rdunlap@infradead.org,
	jorgelo@chromium.org, groeck@chromium.org,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	linux-mm@kvack.org, pedro.falcato@gmail.com, dave.hansen@intel.com,
	linux-hardening@vger.kernel.org
References: <20240131175027.3287009-1-jeffxu@chromium.org>
 <20240131193411.opisg5yoyxkwoyil@revolver>
 <CABi2SkXOX4SRMs0y8FYccoj+XrEiPCJk2seqT+sgO7Na7NWwLg@mail.gmail.com>
 <20240201204512.ht3e33yj77kkxi4q@revolver>
 <CALmYWFupdK_wc6jaamjbrZf-PzHwJ_4=b69yCtAik_7uu3hZug@mail.gmail.com>
 <20240202151345.kj4nhb5uog4aknsp@revolver>
 <CABi2SkUSWLHM5KD=eK9bJrt3bBsEaB3gEpvJgr0LSTAE2G00Tg@mail.gmail.com>
 <20240202192137.6lupguvhtdt72rbr@revolver>
 <85714.1706902336@cvs.openbsd.org>
 <CAHk-=wjNXcqDVxDBJW8hEVpHHAE0odJEf63+oigabtpU6GoCBg@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAHk-=wjNXcqDVxDBJW8hEVpHHAE0odJEf63+oigabtpU6GoCBg@mail.gmail.com>
User-Agent: NeoMutt/20220429
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?7gIHTt+Zh9sOIph3mc3Rkp8+FehfyPymCJR/kml5+9r6m9ZAzEi8DMtorRuf?=
 =?us-ascii?Q?HMttPXc2BbEHN5x/6q5E0TN4ojyqOm4j0WGIH2lxSAHb2xoaXYpef7Xt+UKr?=
 =?us-ascii?Q?DWDAa8FaeRLPNNymUX2IuxY+QhSegQ6JTkutd+sFcCaJNCCKIEiFjPEW4S+F?=
 =?us-ascii?Q?NZFM/T4zC6AWCn2CiGJ0LMxE8xlanu8NUwFukZWPFnouUBw3y1HBCPb705p2?=
 =?us-ascii?Q?negOO0A4hkmlsE6NIQGXKnw4aSktF/dTSA/druMwOnW7jYSEBUhDpiSKHtMo?=
 =?us-ascii?Q?ijM4FLd1xlhmpRrvDrpY8a6GeAzCj79xscjV0o+azETvvk0qc1jU9Oiqi8pW?=
 =?us-ascii?Q?E4ElZg+utA8UwFkzTSYH/BSS/T/DEJNhth3GdnB+xTe44zpHjmyh0rl8vycJ?=
 =?us-ascii?Q?vWPSMK2GjPLyXtS0Z7mlVSlau0xgFbIrsYrAiBNutI58vZF5ohazytylpoPB?=
 =?us-ascii?Q?ndowLT/qxpNR4f2fCOQ6JkX5FEQ3l3zA7lYIBL3+DY+euz8R0pCF6RFpf0hs?=
 =?us-ascii?Q?jsqlah1g5ghxJCLYrJnxCpyNjmK5HugoMFjaCTaniUkVgf+wLcfWug94arH1?=
 =?us-ascii?Q?0I8uCvmaCkOxETPFIppQGVLghE8TFyha10sOOhWBwQ2m5M9MsmjYebcXKtrq?=
 =?us-ascii?Q?9CSMix0HfoyK3B3hm2S4JgUiEBiQjEIgyQfn0qWJaj7QP7sjC+bobhMfAhlh?=
 =?us-ascii?Q?BwdyhavwQzeVO22aQwvRH2S7Qt8hG9vcq9EcFmjwMGuvsuPZOZHO0thRp7iZ?=
 =?us-ascii?Q?YqZzKEuAPFehvkZu0WVuQvDo4NIIFmIgdRnS7RY/xNWSqorDMpL2T+BQLk4V?=
 =?us-ascii?Q?V01IiLRrQSRDUOR8a506iUjbJHweaHFWO5oGHMigOSIrsfT++Tj9VN4dJduq?=
 =?us-ascii?Q?rvCvA2O36VnJmGX6N5UPfS7Nb2tweRniWm1LYtbI+JArkKB82RrudTTZd3tk?=
 =?us-ascii?Q?X3v1SMiksBA3kNFKp9lKnAzWJ7gaK/Eo9m083kjHAyMdQfMn02csm+en4zVI?=
 =?us-ascii?Q?/Zj1EoK6W0ml34HikWqMV+QsSRddjr6XnswAuwe1N5vmyvaF76p5AqeDOeAn?=
 =?us-ascii?Q?SBtAgFqRvluPS7GpCPERGaInOVMa/O1LMrU+18ZXqBPvT/omVhtXPjenovYd?=
 =?us-ascii?Q?eIZDxBLibTS+7OPr2Jb9Wl6M4YecLMyJ5EpUILbPL2Bk92rrY7uXFk0Erj4w?=
 =?us-ascii?Q?BBVjAOS9aJCFY04+ro82gObE/7dZMkdcwC4jBvpEo8Ur1Ojrgy3/G0hyvkXM?=
 =?us-ascii?Q?6Qh3vUVLpCGL+DvArBlbz8eIpBkhfWMkGrDaL2EYiq/wkPz2IAXMTKxuNU+/?=
 =?us-ascii?Q?VUrgM96Cwjio/RjK/tEzDHdt+5X12mBLle9gRMk2/At7l3lnpVbfIf5VB/Tq?=
 =?us-ascii?Q?WbC5Tve8Q5h4cEb5YgEeZvfSc/hmvIlESO/jVWlLh4h3qtc8jOyoIvrrvxLW?=
 =?us-ascii?Q?6osTGYZuMD55IpdgyxUb2wRpRSEzsZTpiEsn0EMrvHgnR6CtP0B1YZ2o8j9z?=
 =?us-ascii?Q?anRsD3DA8LY8tIc4VnLTldw6wb4gVUCDgmPGTaDKT+tTuQM4x+pVrWcnFkF7?=
 =?us-ascii?Q?SNdxZPRL/GS0k0NsWx1FRt3Z9kSZlKjQvWpWZxstOqhBdiwPRZCtQaHWXw7E?=
 =?us-ascii?Q?Dw=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	0sOffcCgwQ2ynSbFFEvZEDakeHYZUXTUz3d+BKyQAWMCYDCFv2gpxOt/E3HLAZFPwo7+aMKWtqFY1yTan6ToqhoWK7EE5FqX7E8AdYCjrZMl5hWVWFKtUV7voxltSUl6VbIYHQ9Aln/Ie6tkDM5opqM9ci48ON4jm4qGdADzVKQ+AAuEXBWDRa2L5jkMzOwbF5GwrOv/yWrioDxYlHGVTxQKvzaV6yolxj/94LPLDywdbvODkiQklQ12Av8kemyXZSmbESBBYu27Xh9ChrDe/FPkjnWY43nkO1y/5Kzob1IfBlgPOvAkPURb+OBP/Mj72/qYoX8kqm+/LN6Ltq3oeEI0mLd0M7PEvI6ffoStxKpeJn+MNcQgFQ0dtx5qR/tbisoGa6PLGkJvjmNpirhUihHMh7oGizaGRyokNhPjw3c77J8AdUgFKTZxX+bBNPdLW4ibtFnJpat2Rg1j/M4R0n6/dSzfWGT6LCAe8zbuWM8JMmbTBsfUJu7lAV1koVJg9WVYKqqUO18I/9jfgbUWabIC808tgwVKdGkO6AwJsWCwMi9qdnUsDqnR3tEQDyIXuwnM/3Rn4klfyfUYSwIh7ymw06z8hPPc5dLkzgYkKlo=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d1130262-650e-4a91-bb85-08dc243474db
X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7933.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2024 21:18:09.8152
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: B4itdf70xw4yZNXYEV1xuAMIx5mi0pvhZCNlZqDWeyM4jroQ61GYw59IrTcNJQ5t/KpcoE3xbWF3EqXVkeim7g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR10MB7676
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-02_14,2024-01-31_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 malwarescore=0
 suspectscore=0 phishscore=0 mlxscore=0 mlxlogscore=500 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2402020157
X-Proofpoint-ORIG-GUID: bsYyBNGIrwvuiZXH4IxQmv8CD62DDglT
X-Proofpoint-GUID: bsYyBNGIrwvuiZXH4IxQmv8CD62DDglT

* Linus Torvalds <torvalds@linux-foundation.org> [240202 15:37]:
> On Fri, 2 Feb 2024 at 11:32, Theo de Raadt <deraadt@openbsd.org> wrote:
> >
> > Unix system calls must be atomic.
> >
> > They either return an error, and that is a promise they made no changes.
> 
> That's actually not true, and never has been.

..

> 
> In the specific case of mseal(), I suspect there are very few reasons
> ever *not* to be atomic, so in this particular context atomicity is
> likely always something that should be guaranteed. But I just wanted
> to point out that it's most definitely not a black-and-white issue in
> the general case.

There will be a larger performance cost to checking up front without
allowing the partial completion.  I don't expect these to be high, but
it's something to keep in mind if we are okay with the flexibility and
less atomic operation.

Thanks,
Liam