Received-SPF: pass (google.com: domain of linux-kernel+bounces-50649-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Fri, 2 Feb 2024 16:09:18 -0600
From: Lucas De Marchi <lucas.demarchi@intel.com>
To: Arnd Bergmann <arnd@kernel.org>
CC: Oded Gabbay <ogabbay@kernel.org>, Thomas =?utf-8?Q?Hellstr=C3=B6m?=
	<thomas.hellstrom@linux.intel.com>, Maarten Lankhorst
	<maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>, David Airlie <airlied@gmail.com>,
	Daniel Vetter <daniel@ffwll.ch>, Matthew Brost <matthew.brost@intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>, Arnd Bergmann <arnd@arndb.de>,
	<linux-kernel@vger.kernel.org>, <dri-devel@lists.freedesktop.org>, Matt Roper
	<matthew.d.roper@intel.com>, <intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH] drm/xe: circumvent bogus stringop-overflow warning
Message-ID: <sbbfz5zzdjj7hjcmyqvof3roe6zb43kflgmweopfu65hllxdep@m4pxjiuqxood>
References: <20240103114819.2913937-1-arnd@kernel.org>
Content-Type: text/plain; charset="us-ascii"; format=flowed
Content-Disposition: inline
In-Reply-To: <20240103114819.2913937-1-arnd@kernel.org>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?MjVvvisK52O/VFzNp3UnP8kke8KJZ8kDNJC8/oD7imzSdwrgQsgGizpwSGUt?=
 =?us-ascii?Q?qryE0X/j/QeyNHz7E69tuOaWe4RzNXTXVxJ6ctHFzRjujdihjceDz3lkTkN5?=
 =?us-ascii?Q?FvB4xlyv7q7DUxVHJdCcF5wV3kteD6L6DqXGCu0EO67hoero/2Po5RDYpLuI?=
 =?us-ascii?Q?mLKtd7126+0T5QLasjLC6EqdkxCyXISXc/dh6KXmQlbHqhMpHFuEsVOvdBRT?=
 =?us-ascii?Q?NWMh6tg9G6jf9vNJ7v8hAj1LvKslw1rAkRKW9OYP/oU/KpkkY5YKVH8UFG5w?=
 =?us-ascii?Q?EBqJOeUTPSs/lbCINE1gg7dusWl0YJI9RLKJObd75bbQ5lFFyVM93VdHabFS?=
 =?us-ascii?Q?BAwngYrUb6DECeZcuC3tHWANoaDXx+JQ93qQQXqGjlLPde9X58q5p4o0XZHG?=
 =?us-ascii?Q?0HE65RdmMcNPMF4LITgujiH5OfYJ43NOONkQQFl9+wn6vHEsxL9qwPRkQo/h?=
 =?us-ascii?Q?aSB8j7i5ss7FJmyhYNsDvs13Q70+uxcdHPmU8dvEqwj2xiFFrtLRcT4VbqAn?=
 =?us-ascii?Q?9ynS0vQVrtM4ORVM1FStyzyWYdyhvOnIVCnXF8TYuffEL6K3NSk5x8ve1Sam?=
 =?us-ascii?Q?IatbPTtwT4wMOkMPYobrikLzQMlCGZkFhoNvxuj+Zuz/odYE+gTNMp0AQumB?=
 =?us-ascii?Q?5yygGSHq4hCaquAbC9+Ko71A6K2d7J2tQS/S8Me4LGBtsuV4p/qCieE5MtTR?=
 =?us-ascii?Q?ojcSt1gswRQ70RyO+BfMNPWjacSF9uhw8qg0yXNyqNZNwidOF5e/rGA/wDvL?=
 =?us-ascii?Q?bSrK2bB+wq+G5zTIj0jZ4XJECHqQPDS/tHuQbJG2raxi7/VfkmuijVwsKcfM?=
 =?us-ascii?Q?ySDNxyC4ZEyCMFMxU5IFPI7oKg+It5QudW7nBQQsrMZ22f/7/El81k60T4P+?=
 =?us-ascii?Q?2LlUDtRxWUc3Et+hFUe+kAL5peCCKw5aBMxH8rizJeNTRdPMX+cPakVDO36h?=
 =?us-ascii?Q?8yB9XOSLdR0Aia4fVO72b0KynOEABn/0UOEdFq+tY6JNHdJo6OqfHf2H0712?=
 =?us-ascii?Q?FC/+i0cCrCRFUnDYz07691IG2pxvfEfSEbpK8LuXzOtQkuJTY1HSX9HpPsaZ?=
 =?us-ascii?Q?6ILpNrY2NNaxpjhJJ1EhHLfIIltcBygtcVyFS02/7f2Q9SXaJ2NDhdWBp6Xg?=
 =?us-ascii?Q?XAF5580RIkKgxohT2TZ6oPxpJKeAaA1n+7/qG8wA4Er3n/EGZQxoLm1XOyUN?=
 =?us-ascii?Q?ncSRL8oAImXD0nJtjR8xOIhrEV82X2kKfgi9jiq7aYulZxLq1sg/EOaJ+wsD?=
 =?us-ascii?Q?XS+KKmXk2+I9Mv4pWPFh3GqdifDAEIqgce84UPOFVKvHLvkyVVA3fBgrQF6U?=
 =?us-ascii?Q?7NITeJvpRiGIogdcoAKwfOL14P4TAQj6ah5bRnr2Yfv3J7WoxKJQlnUMoRUY?=
 =?us-ascii?Q?l9lFLtnum6/8jR9fDp82PfR5dHb/hejXoWrn+zs9c42oemnEEKhwu+fLhMzV?=
 =?us-ascii?Q?2e7Yn88UXnZ8VYjKc+g9+KZ0tx9bSgglzEGjPnp3pia9yqgJobq+tz8DRFz5?=
 =?us-ascii?Q?djlZ5hpOjpMWjHaAEql6zImZa1D7O6FxbUIpYzOKa0jMTQo3LlYOwJWCwf0M?=
 =?us-ascii?Q?DJrWkvJ4IPTUiMQfW7cFJetlxj+c8CmnaSWbtShqs45egXv8NQlkg/HlwGsh?=
 =?us-ascii?Q?kA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: fba9ed87-60e6-4036-98fe-08dc243b9b7f
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6139.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2024 22:09:21.2030
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BfG4ulFlgsFPmabaK8eDaExe27EXi8y070q4S/BlaDBVL895lF4NMXJaKOCi8MM9kMFX+wd7ABab5EWIZwn9ywLjLtGYBdqMwE6dg6nXBb0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5166
X-OriginatorOrg: intel.com

On Wed, Jan 03, 2024 at 12:48:02PM +0100, Arnd Bergmann wrote:
>From: Arnd Bergmann <arnd@arndb.de>
>
>gcc-13 warns about an array overflow that it sees but that is
>prevented by the "asid % NUM_PF_QUEUE" calculation:
>
>drivers/gpu/drm/xe/xe_gt_pagefault.c: In function 'xe_guc_pagefault_handler':
>include/linux/fortify-string.h:57:33: error: writing 16 bytes into a region of size 0 [-Werror=stringop-overflow=]
>include/linux/fortify-string.h:689:26: note: in expansion of macro '__fortify_memcpy_chk'
>  689 | #define memcpy(p, q, s)  __fortify_memcpy_chk(p, q, s,                  \
>      |                          ^~~~~~~~~~~~~~~~~~~~
>drivers/gpu/drm/xe/xe_gt_pagefault.c:341:17: note: in expansion of macro 'memcpy'
>  341 |                 memcpy(pf_queue->data + pf_queue->tail, msg, len * sizeof(u32));
>      |                 ^~~~~~

ugh... I missed that this was for gcc 13 rather than the broken gcc 11
that we workarounded by excluding gcc 11.

>drivers/gpu/drm/xe/xe_gt_types.h:102:25: note: at offset [1144, 265324] into destination object 'tile' of size 8
>
>I found that rewriting the assignment using pointer addition rather than the
>equivalent array index calculation prevents the warning, so use that instead.
>
>I sent a bug report against gcc for the false positive warning.
>
>Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
>Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113214
>Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>---
> drivers/gpu/drm/xe/xe_gt_pagefault.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/xe/xe_gt_pagefault.c b/drivers/gpu/drm/xe/xe_gt_pagefault.c
>index 59a70d2e0a7a..78dc08cc2bfe 100644
>--- a/drivers/gpu/drm/xe/xe_gt_pagefault.c
>+++ b/drivers/gpu/drm/xe/xe_gt_pagefault.c
>@@ -332,7 +332,7 @@ int xe_guc_pagefault_handler(struct xe_guc *guc, u32 *msg, u32 len)
> 		return -EPROTO;
>
> 	asid = FIELD_GET(PFD_ASID, msg[1]);
>-	pf_queue = &gt->usm.pf_queue[asid % NUM_PF_QUEUE];
>+	pf_queue = gt->usm.pf_queue + (asid % NUM_PF_QUEUE);

surprising that it fixed it, but looks fine to get in.

Applied to drm-xe-next, thanks.

Lucas De Marchi


>
> 	spin_lock_irqsave(&pf_queue->lock, flags);
> 	full = pf_queue_full(pf_queue);
>-- 
>2.39.2
>