Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp1136571rdb; Fri, 2 Feb 2024 15:20:57 -0800 (PST) X-Google-Smtp-Source: AGHT+IEMo7osiTN0wpYg75+5/1pOyZ4l6zoM0C5FFEca2AW4Jz4TzihwDRmRGtTd1zS8mGDvEfju X-Received: by 2002:a05:6214:508b:b0:68c:8ad2:5e5 with SMTP id kk11-20020a056214508b00b0068c8ad205e5mr2335655qvb.59.1706916057706; Fri, 02 Feb 2024 15:20:57 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706916057; cv=pass; d=google.com; s=arc-20160816; b=minFbkghOS6P8in0BFPQUnVDBq+GZJM+R3jmbd3vdl/eEWdwPJ6ZF79slrzNNEH/ap gKXkIaJyIJVXRKai4/t8Ab16C/MkZsqT7w0YeRocJFkaUVhoK7uwp3Mhpv03nubgtjY1 EGrJ5OjzqDM1oZL9l2QC22Ty1T303njHFl0GIpuvLjxVy6EI2EVB8BZ5uEFYQmD6kjjZ 3fgwKCIb0tuXxtWNi6if2F5QHAiIaccaxIU3pn6AkMuRnebYVGujAqIcjSr4Y9F+Mf3J fiiXgljmgMpeEguXPnJYrLfmaoR5MRTs4LPcBUcZScbyie4LAI0wqzISHcpMnc5kjGhL lZ0Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:to :from:date:dkim-signature; bh=j9q6o8Q6g4/oBM3MmGcxIFDw8FrtIUE7gpoFXr2ZYG4=; fh=GwRQlJNHaEiQm60hu+xaJ13/V5FII5VRmyOanYaWlQc=; b=f6/iJ2PNs4i82as8RmJEZy+IvdzPtHVWXBkZvjmc/RtJOJeHFulG+5TUMPy3PPhwJY lfI8t3E4TKzqaMQz37vyG5djVBbcgjZbagDvnfvlLSonIZGhp+CSv+5qt+HshXeEbneS qmMTZSyWt8QEVLmgWLA0cIiXCGLnks/p0fQFrd6ZvvzNsqo2PhrTROEy+C/Zc/CvkOi1 prPMmKEKiUk1sSE/hd89MwoY+Xl2kvwxAePjh3twsSO4Y41j4COMNzm+TeBY+UrUXH9q CyBO355Q9o9kiI95dtgmKUzP7iKrTEoSCwDKJ+1FDuiMal9Q0vEypAOOxO8yHI7/eufE gUsw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=f5E2eXf1; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-50708-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-50708-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=1; AJvYcCXzsSrewzlORQGvHvw5w5GnueUlsAB4hP+qhToZI01Hn5MkdAqBREiLZ6EB+bbUONcF4sxxR3rrs7cEO9EZwrgcFwk+7k8wbNWlJTQYHw== Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id c20-20020a05620a11b400b0078351e1950esi3008511qkk.420.2024.02.02.15.20.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Feb 2024 15:20:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-50708-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=f5E2eXf1; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-50708-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-50708-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 76D1E1C22B59 for ; Fri, 2 Feb 2024 23:20:57 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A872E12C802; Fri, 2 Feb 2024 23:20:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="f5E2eXf1" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C75108592F; Fri, 2 Feb 2024 23:20:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706916049; cv=none; b=WeLqos2GAWeU495/7Psv9R/Q84LY7XoJQc48X/iYue7gFM37VfVC5JpXnsxX+ZC6b2x4SdF1TJL8zQIc6air63dLaKdewMS74YugtxYq3xTwApPPUqovHD0d7AkpYejly9IOYBFVbL+kdNiTuxjC6em+HAcdi5bfq+fWnj+ezqc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706916049; c=relaxed/simple; bh=OZlIIMlUht4XYhbukAIZUl5DVjNY9FcWhu1WB1zXhO8=; h=Date:From:To:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jjn3wbsccDDd6Ycerzx86oKGwi3ykOY8MRcLZmrArziKvzUQSOcfsOz6BO4zpaLxnPIFPgk3NIQBbqDda4Wg2o4jtdgPIkacCL1qNi5b3D0t6Gne6irSEDHnj3dlrc0p47dG6j2Myqy8ULHh5Z+MwiHJ2TLMJ/XV/F1dgd4w8HY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=f5E2eXf1; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id A6C14C433F1; Fri, 2 Feb 2024 23:20:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706916049; bh=OZlIIMlUht4XYhbukAIZUl5DVjNY9FcWhu1WB1zXhO8=; h=Date:From:To:Subject:References:In-Reply-To:From; b=f5E2eXf1Ild/UMkfGx99IbLsTij/1GRs5ifwmhNvRkW/K++94QA58uN3l7ic5ZQsi agVFB7axGJfjtI95n+uM9bJryBfV1IZZLvMz7SKFM/dzxdNKTL6fxiw0pGR1RSsrB7 PCpK2BVU2V6j7p1umI4ncoz4kY7PmYUKnGw4j4ADQHlh3yMjBo5GDzfkHUnGkWfynv IF/WIiRZXD/umuoVdEzuVtFcmSGijqysTCf8vguztRT7ueTDAbaJUmwadeePS1+6Lw AJVuaAsXSci79oOQjhgwnygnG+HamDu8UhPbX2f8xiOQyWPSic8ZOOFArMH0ooBr4N 599AZNBx/FTzw== Date: Fri, 2 Feb 2024 17:20:46 -0600 From: Bjorn Andersson To: Unnathi Chalicheemala , Konrad Dybcio , Satya Durga Srinivasu Prabhala , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@quicinc.com, Dmitry Baryshkov Subject: Re: Re: [PATCH] soc: qcom: llcc: Check return value on Broadcast_OR reg read Message-ID: <2fwmzxfxm3eyrffmri2ybxicgk3n6rxckmyvvpxhmok62cqvzs@iaioxvhlncwu> References: <20240202-fix_llcc_update_act_ctrl-v1-1-d36df95c8bd5@quicinc.com> <5ba42ywqwi2ix2hyo4ysdgo2onyrhm6rtvpow626r7kctoixz6@xrens4w3k7ar> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5ba42ywqwi2ix2hyo4ysdgo2onyrhm6rtvpow626r7kctoixz6@xrens4w3k7ar> On Fri, Feb 02, 2024 at 11:56:53AM -0800, Elliot Berman wrote: > On Fri, Feb 02, 2024 at 11:47:43AM -0800, Unnathi Chalicheemala wrote: > > Commit a3134fb09e0b ("drivers: soc: Add LLCC driver") didn't > > check return value after Broadcast_OR register read in > > llcc_update_act_ctrl(), add it. > > > > Reviewed-by: Elliot Berman > > You'll probably want to add: > > Fixes: a3134fb09e0b ("drivers: soc: Add LLCC driver") No, this was correct in a3134fb09e0b, ret was returned on the following line. The problem was introduced when the new 4.1 if statement was introduced without considering that ret might be overwritten. Fixes: c72ca343f911 ("soc: qcom: llcc: Add v4.1 HW version support") Regards, Bjorn > > > Signed-off-by: Unnathi Chalicheemala > > --- > > drivers/soc/qcom/llcc-qcom.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c > > index 4ca88eaebf06..cbef0dea1d5d 100644 > > --- a/drivers/soc/qcom/llcc-qcom.c > > +++ b/drivers/soc/qcom/llcc-qcom.c > > @@ -859,6 +859,8 @@ static int llcc_update_act_ctrl(u32 sid, > > ret = regmap_read_poll_timeout(drv_data->bcast_regmap, status_reg, > > slice_status, !(slice_status & status), > > 0, LLCC_STATUS_READ_DELAY); > > + if (ret) > > + return ret; > > > > if (drv_data->version >= LLCC_VERSION_4_1_0_0) > > ret = regmap_write(drv_data->bcast_regmap, act_clear_reg, > > > > --- > > base-commit: 021533194476035883300d60fbb3136426ac8ea5 > > change-id: 20240202-fix_llcc_update_act_ctrl-64908aed9450 > > > > Best regards, > > -- > > Unnathi Chalicheemala > >