Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp1143611rdb; Fri, 2 Feb 2024 15:42:44 -0800 (PST) X-Google-Smtp-Source: AGHT+IGMB63fNR/k/r/1uqk7I2Fj+Pnr8cY2vcfWOJIPFHlkRR7HagQ/VvhQzdoaytvQRdN5phvs X-Received: by 2002:a05:6a21:398d:b0:19e:378a:124c with SMTP id ad13-20020a056a21398d00b0019e378a124cmr10874762pzc.12.1706917363870; Fri, 02 Feb 2024 15:42:43 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706917363; cv=pass; d=google.com; s=arc-20160816; b=kVd0Z1PnR/zYZEoSVCmmOglvi6f9UAwOz4vlQ/L1oHdM8Dks/nops8a1PSUj/NUVNZ WTLDJ0XuvJmfyceg/QZwXQ0UrB98T4BY2RXMl9aklW/2po0WEg3FmdQ8tpzYClsJb61t QB7jSZzWbEUUeyDJW9UIrseztcjkGSU8K5x/a9dpneCh+Brlw6Kuwh5BR2cVX29NXLd5 yx/G6YL0d7lU1PgoWNJqJsDIvaghiemOPYVj5uLHAHoWe20PCutWykZ1tjcXsjwgO2Iv bWIB34v3L0NV4WXDaGOFz8CLcE2CYHHg2NZ4dRv8GmLv188uEvV1WXIbVJGTW2arrui0 n2Nw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=UuixsYb0Yuy8hlVCABbXiVK4X8IKt3OO9t82oFhb8F4=; fh=yTmN91/3W/0z3cOOgFaCgDC8hWa0e24muei90jzH8yk=; b=csqgzfS6U9Fbm7tE1gyQDZhFEDF3BmO1YDvoOE5ig/yU6qyl/C/1FOwM7gEX8tBmVC J74D0Pd2YSesTh6eSvtahFFbqnsXy78raqXT6YoWwOJINM8+0vMoNjzYqJK1O30sjdF9 8dMLobyjSRf4VW/kQLURog4zOFxcrwke/Jwk3OIhwdI4EIxFwqANh/8IUAHQDTAjdpUW fWrphAfh4dinKxs/1IBVjTC6UFndj/jx894lDpmpAaJ6cq52VViwXfVc3iOHhUFzeGaE NUl8qeW/9PA5MDCYkI/MSiiEbsOxNRyMW3PemjfKvXaQ6Che/XF1TW9M3+yD9lYCYcv5 4NFQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=VFOBftGh; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-50717-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-50717-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org X-Forwarded-Encrypted: i=1; AJvYcCWpsn9LG+rolNwjULO++hEnyM9OOPkuxQ1vtQ7sNDef5P9vRmf47KtzF+ryI7vfbnrArdlr9ZyBntWkrLaqWTU7ezKe8oewja6rtMZjZg== Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id fb37-20020a056a002da500b006ddd3208911si2225838pfb.155.2024.02.02.15.42.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Feb 2024 15:42:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-50717-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=VFOBftGh; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-50717-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-50717-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id EA8D9B2673A for ; Fri, 2 Feb 2024 23:40:15 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DEE9A12D742; Fri, 2 Feb 2024 23:40:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="VFOBftGh" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08D1B5B697; Fri, 2 Feb 2024 23:40:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706917205; cv=none; b=LbdcAGspHaZiAa2uw2MFDFsEJg2kQb9yRZ3dRh/trZY1ZJv6IxACjFANCJptdz46fBq0lx2TsYH4SU+6rLJMHQs0n+h4JLn/UBXyfkeZF9mtu42waYcDvrw0L6bEgK3ontm3yh5bh45Ud1KY4truAMQoAIay9mEsMZcUtlkYWts= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706917205; c=relaxed/simple; bh=unXX6g1ZBdLO7Jo440DSlmm54n4Lw76NBjvoeQ7FaE4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=a7HTDG4ywd3oyRt/6I8bHmM9HfERNa0rHPzMimAxBSv8/n6VJ/XhXWPq27geWZe5nrC0p+oGJjSDJWxOR9D0p5O2VjIuWuKhxQ9fQsVQbfnRA57QUyf20pR/uRVebDXK6ep4t4rh+bjIOI1ZrPnRwmbdZDP6h8wC46CObZWkigQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=VFOBftGh; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 62351C433F1; Fri, 2 Feb 2024 23:40:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1706917204; bh=unXX6g1ZBdLO7Jo440DSlmm54n4Lw76NBjvoeQ7FaE4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VFOBftGhrsfDFpKWZBkIB1P38BKvccfhxGFGhhIf5FMj4IMKNUNVcGgdgcai9P7s4 o19DBLwmAhnnpBuH69hZvj/Xi9FfZpSd9G1qP/4pf2pBkb5hFzXGzgnTCZgnnUWsNM z0uc3O1fBgeW+mDAUcgA34IIRPjkVLYHtm38mHiA= Date: Fri, 2 Feb 2024 15:40:03 -0800 From: Greg Kroah-Hartman To: Hamza Mahfooz Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, "Rafael J. Wysocki" , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , "Pan, Xinhui" , David Airlie , Daniel Vetter , Bjorn Helgaas , Mario Limonciello , Lijo Lazar , Srinivasan Shanmugam , Le Ma , =?iso-8859-1?Q?Andr=E9?= Almeida , James Zhu , Aurabindo Pillai , Alex Shi , Jerry Snitselaar , Wei Liu , Robin Murphy , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-pci@vger.kernel.org Subject: Re: [PATCH 3/3] drm/amdgpu: wire up the can_remove() callback Message-ID: <2024020225-faceless-even-e3f8@gregkh> References: <20240202222603.141240-1-hamza.mahfooz@amd.com> <20240202222603.141240-3-hamza.mahfooz@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240202222603.141240-3-hamza.mahfooz@amd.com> On Fri, Feb 02, 2024 at 05:25:56PM -0500, Hamza Mahfooz wrote: > Removing an amdgpu device that still has user space references allocated > to it causes undefined behaviour. Then fix that please. There should not be anything special about your hardware that all of the tens of thousands of other devices can't handle today. What happens when I yank your device out of a system with a pci hotplug bus? You can't prevent that either, so this should not be any different at all. sorry, but please, just fix your driver. greg k-h