Received-SPF: pass (google.com: domain of linux-kernel+bounces-50795-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: Hillf Danton <hdanton@sina.com>
To: syzbot <syzbot+fa3ef895554bdbfd1183@syzkaller.appspotmail.com>
Cc: linux-kernel@vger.kernel.org,
	syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [net?] WARNING in __unix_gc
Date: Sat,  3 Feb 2024 08:41:22 +0800
Message-Id: <20240203004122.1625-1-hdanton@sina.com>
In-Reply-To: <0000000000003555920610660fbc@google.com>
References: <0000000000003555920610660fbc@google.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

On Fri, 02 Feb 2024 05:26:28 -0800
> HEAD commit:    1701940b1a02 Merge branch 'tools-net-ynl-add-features-for-..
> git tree:       net-next
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=12d6927be80000

#syz test 

--- x/net/unix/garbage.c
+++ y/net/unix/garbage.c
@@ -237,6 +237,8 @@ static void inc_inflight(struct unix_soc
 	usk->inflight++;
 }
 
+static int recycle;
+
 static void inc_inflight_move_tail(struct unix_sock *u)
 {
 	u->inflight++;
@@ -245,8 +247,10 @@ static void inc_inflight_move_tail(struc
 	 * of the list, so that it's checked even if it was already
 	 * passed over
 	 */
-	if (test_bit(UNIX_GC_MAYBE_CYCLE, &u->gc_flags))
+	if (test_bit(UNIX_GC_MAYBE_CYCLE, &u->gc_flags)) {
 		list_move_tail(&u->link, &gc_candidates);
+		recycle++;
+	}
 }
 
 static bool gc_in_progress;
@@ -259,6 +263,7 @@ static void __unix_gc(struct work_struct
 	struct list_head cursor;
 
 	spin_lock(&unix_gc_lock);
+	recycle = 0;
 
 	/* First, select candidates for garbage collection.  Only
 	 * in-flight sockets are considered, and from those only ones
@@ -342,7 +347,7 @@ static void __unix_gc(struct work_struct
 	spin_lock(&unix_gc_lock);
 
 	/* All candidates should have been detached by now. */
-	WARN_ON_ONCE(!list_empty(&gc_candidates));
+	WARN_ON_ONCE(!list_empty(&gc_candidates) && !recycle);
 
 	/* Paired with READ_ONCE() in wait_for_unix_gc(). */
 	WRITE_ONCE(gc_in_progress, false);
--