Received-SPF: pass (google.com: domain of linux-kernel+bounces-51126-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Sat, 3 Feb 2024 15:54:01 +0100
From: Dimitri Fedrau <dima.fedrau@gmail.com>
To: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>, 579lpy@gmail.com,
	jic23@kernel.org, lars@metafoo.de, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: humidity: hdc3020: add threshold events support
Message-ID: <20240203145401.GC3727@debian>
References: <20240203090530.53374-1-dima.fedrau@gmail.com>
 <236dc9db-8525-413e-a77b-54df198c86f5@wanadoo.fr>
 <b789eb01-5b5d-4513-88d2-1f14e95969d9@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <b789eb01-5b5d-4513-88d2-1f14e95969d9@gmail.com>

Am Sat, Feb 03, 2024 at 11:06:02AM +0100 schrieb Javier Carrasco:
> On 03.02.24 10:58, Christophe JAILLET wrote:
> > Le 03/02/2024 à 10:05, Dimitri Fedrau a écrit :
> >> [...]
> >>   drivers/iio/humidity/hdc3020.c | 339 +++++++++++++++++++++++++++++++++
> >>   1 file changed, 339 insertions(+)
> 
> ...
> 
> >> +    guard(mutex)(&data->lock);
> >> +    switch (chan->type) {
> >> +    case IIO_TEMP:
> >> +        /*
> >> +         * Store truncated temperature threshold into 9 LSBs while
> >> +         * keeping the old humidity threshold in the 7 MSBs.
> >> +         */
> >> +        val = (((val + 45) * 65535 / 175) >> HDC3020_THRESH_TEMP_SHIFT);
> > 
> > Why 175?
> > If the span is -40/+120, I guess it should be 160 and if it is -45/+120,
> > 165. No?
> > 
> > Maybe something like:
> >   #define MIN_TEMP -45 (or -40)
> >   #define MAX_TEMP 120
> > in order to avoid hard coded constant?
> > 
> 
> the 45 and 175 values come from the conversion formula provided in the
> datasheet (page 13), even though the sensor range is from –40°C to 125°C.
> 
Will add following constants:
#define MIN_TEMP -40
#define MAX_TEMP 125

It's the supported temperature range by the chip as Javier already
explained. Thanks for finding this.
> >> [...]

Best regards,
Dimitri