Received-SPF: pass (google.com: domain of linux-kernel+bounces-51177-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Sat, 3 Feb 2024 17:08:36 +0100
From: Dimitri Fedrau <dima.fedrau@gmail.com>
To: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Cc: Li peiyu <579lpy@gmail.com>, Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: humidity: hdc3020: add threshold events support
Message-ID: <20240203160836.GA21281@debian>
References: <20240203090530.53374-1-dima.fedrau@gmail.com>
 <1eb2034f-b1ef-474d-91f6-c562a5768bfd@gmail.com>
 <20240203144205.GA3727@debian>
 <871e7e7a-c987-4926-957e-5dfdb46d0740@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <871e7e7a-c987-4926-957e-5dfdb46d0740@gmail.com>

Am Sat, Feb 03, 2024 at 04:53:33PM +0100 schrieb Javier Carrasco:
> On 03.02.24 15:42, Dimitri Fedrau wrote:
> > Am Sat, Feb 03, 2024 at 10:30:09AM +0100 schrieb Javier Carrasco:
> >> Hi Dimitri,
> >>
> > Hi Javier,
> > 
> >>> +	/* Supported temperature range is from –40 to 125 degree celsius */
> >> Should that not be val < -40?
> > yes, you are right. Will fix it.
> >>> +	if (val < -45 || val > 125)
> >>> +		return -EINVAL;
> >>> +
> > 
> > Best regards,
> > Dimitri
> 
> When at it, could you please rename the hdc3020_id variable you added to
> the probe function? It shadows the i2c_device_id global variable (it is
> not used in the probe function, but there is no need to use the exact
> same name), and given that it is in the hdc3020_probe function,
> mentioning the device name again is kind of redundant. Something like
> just "id" or "dev_id" would suffice.
>
Sure.

Best regards,
Dimitri