Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp1498011rdb; Sat, 3 Feb 2024 08:33:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IEET3/VIj31/ELAZbeKj+q6LvZh2fejQsY5YRX4/eBCNgxFDPbWzHYvUSOwDW4gpEkORkfX X-Received: by 2002:a05:6358:7299:b0:176:d2f1:b617 with SMTP id w25-20020a056358729900b00176d2f1b617mr8637194rwf.27.1706978023321; Sat, 03 Feb 2024 08:33:43 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706978023; cv=pass; d=google.com; s=arc-20160816; b=b8XlCYUjg0ZLNlMrDYwRkNr3rrSiV9yy9rtrjyxldvP+rsjqUdDd7f3qYAsRE0pnFu bSoDNoL5BeKUyRC/gQqAVwSNiNxA6Mwx9Q8n/GZOqqZdCzOTJse7FkoUBc4xGlb2y9+D FEojKGP4bZIpjDS2RI2t/ZGoYMg7fHvpq0nghmbPgNYgAFnXBhhGuehOe4HelbiTcUwg 7FuiC+UFjuk4DP29bTQazCbAOPA2YNAbm+6CbX9fenoqd0XtnRFr+Cid87H7b2rZNBYl 3hWNs45RRTe3jCLC2ZJ1PIJzRw+oPQmxZ/lo4jofQMaBEIhd3tmZMFL8jOxYxF1zb+Yn gQZQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Dku+vMvtmnMGHoYUlJi5yCzjF20d0vv8EAcUcglE/uo=; fh=Sx2UkfJkMztVTBS5aNYBso9YDwvVrg5gGnZuC7UvCU4=; b=yiJQgcrHnHrB2CxEeWjrnaQJlXW//LhIcdS2B1iPlFXZPeVIQGLdfI5AqPfhdnYtCF xK4tA8Bpja9quBOCu1t7QSgAJtLNUla7o8yDJ7aovLv6LIZ1QrubChv9fx3yRV/yDehz wFLBF4wvqaZvOKNxDHp71DUbHK+fF41Q5OpqSvXusV11F3JTbjhXe2nbvh9CNq4V0LiJ yGXfjQ6Xmpb6Z8qvVeXhe1NV4+E59g5WmSNAb4HglKfx/evllRlTCtlSBHLpDGltcwlp 3EYO15kE9g92tHysBeN5aTMX/OBUiQbyiaxlY7NnUEEHcOU0jWhGxWhGJrhsE13nuDD3 w1MQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=rUfkdcRq; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-51184-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-51184-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch X-Forwarded-Encrypted: i=1; AJvYcCVtDAZ7JAdpDwMm5r+xX4aVRHYTVMg2q3o4ECGGS0JOAmapTbClobit19hdkeF+dCMeSefEaC2Kb7+nuYvr16SbuiUfTPNM7bv25U+Cgg== Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id bv9-20020a632e09000000b005dbf4efa1f8si2796564pgb.852.2024.02.03.08.33.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Feb 2024 08:33:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-51184-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=rUfkdcRq; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-51184-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-51184-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 3BAEAB21FE1 for ; Sat, 3 Feb 2024 16:33:42 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DCC1C5F853; Sat, 3 Feb 2024 16:33:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="rUfkdcRq" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BCCEA5F549; Sat, 3 Feb 2024 16:33:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706978010; cv=none; b=SsMKktbxOOZhcgHc76v1LsryxySUATpmNafOqDcUB6zo7ZTJ9DNxJ08FRJWUBS/s9YNeqara6hocjJRm5OLXFQ0wz/ZkR9yJcKJ13yD2EPc3vNw9Sl00GOw8QyHYG9Wzh2XO3ut0XgIYWhTaHMJa//IVDf21De5pm/DceJOYX9o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706978010; c=relaxed/simple; bh=USwZi+tenL+zWd7YTIE6nRVnYZIbj6mmBnK2ukvZmXo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DJf4CvGpWyrh5wg9ggBBvLzWifQmoCI7iQs/SQAkkdYRXlk2cWg06XzdM02uVkP5krJcGYSm8Xzlgef3N4J53uei26GEquRm9kOQt8bahzFd3HGnAV+96LHLf70h9ftnd2Wm3JSB1pzBzXeJOeU0KZSIPydxSwMXZ52TaTWJ3bE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=rUfkdcRq; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=Dku+vMvtmnMGHoYUlJi5yCzjF20d0vv8EAcUcglE/uo=; b=rUfkdcRqK1MFKlWfPmBRiw97rP 4H2AgjNN7ZfzBoore+qY8aMye9QASpSFoL09O/g0wvXKjiYo8RFT2pSbvXI31w8YZPUJ8PCy28Yqm pzkjax/zZ2wnl/NXyee1rOiNEBUnUm3pYSJ43I0f7/utE1XJrHEBAN9UZ6S4zKynEKMo=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rWIxD-006ugn-Tr; Sat, 03 Feb 2024 17:33:19 +0100 Date: Sat, 3 Feb 2024 17:33:19 +0100 From: Andrew Lunn To: Horatiu Vultur Cc: hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, UNGLinuxDriver@microchip.com Subject: Re: [PATCH net-next] net: micrel: Fix the frequency adjustments Message-ID: <5f123f39-efbd-44d6-b4cc-db33d175fa21@lunn.ch> References: <20240201204203.2691424-1-horatiu.vultur@microchip.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240201204203.2691424-1-horatiu.vultur@microchip.com> On Thu, Feb 01, 2024 at 09:42:03PM +0100, Horatiu Vultur wrote: > By default lan8841's 1588 clock frequency is 125MHz. But when adjusting > the frequency, it is using the 1PPM format of the lan8814. Which is the > wrong format as lan8814 has a 1588 clock frequency of 250MHz. So then > for each 1PPM adjustment would adjust less than expected. > Therefore fix this by using the correct 1PPM format for lan8841. > > Signed-off-by: Horatiu Vultur Reviewed-by: Andrew Lunn Andrew