Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp1529956rdb; Sat, 3 Feb 2024 09:58:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IGFoDfmcRSPkFcapTut4a8TcjrscrB8Lbn7W/eyNuQKYmQV5sPkiRJi4hQeBgBRlM/uW9BI X-Received: by 2002:a05:622a:50a5:b0:42c:f7b:dea6 with SMTP id fp37-20020a05622a50a500b0042c0f7bdea6mr2808184qtb.3.1706983122806; Sat, 03 Feb 2024 09:58:42 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706983122; cv=pass; d=google.com; s=arc-20160816; b=l1FjpTn7ptaBlezhUKnTALCXyMYBOB5y5O5hyMAH5jHKV2gqMj7rbkX9Ms+YchOCRb 6OC/n7RYWGpPi3HrDouEZ+VWbp04QwnzadmnkUn+I7Sm5Mps7iiFYe70PNMnO1NlSrMn WIQ/fDX1odGmYp3vE+fb/rBtMlK0GJrksek6f1cvSyNi/0NWYBrC2nNU6Kmbe2e4ozIW MzJQ14aZe2VWfQZiCHCWt3yyU9iThHnZlcL8m+u1dJSCfo8xlNFW1mVgTJ1lbjmjE09W SJrWMLgmU4JAHNG9sYFX8905QJmlnvCvT//2gVggFhvm2u1Jq5gE05p9CT18r78ytHOE WbDg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=h4uAO89DSf3RQZMzijlWW9jpjLoIfP0sKI92dPyza8I=; fh=nTBhcrFB1HBg2wDAPoC/gu/BJy8K5z0lY5Rq9w636CI=; b=VL5bSdSNutx9zkCACLEds97t/8BkNLJmUZEAhFbvc3oIaD00fFMvfnvKuveYyCMlJV Ttrkf50Rheq+olsFUvylviN4F8rrwo0QjngrAIlLxWQ1AUerYi18KRjDPXHoUZEr4Bma 4GN1cOhlJe41z9soTaDXSZ7RdwnGg9pGeO2gKrh0FvRFAPsip0kdvQEmEC6bnh1a4iLW eZVExtm7pVc3jeuDX0QHB4Bjkit66NWSKwCpYHYuNAdzJSjkKV8ci4oOAl9/OmlNrAr/ 7WkrmGZYdIRQfGmqai5Ywa3pe7BFd+metIR6YLYiu7nxHKTHFY+dDx+X2z7NRjKMmsYb OulQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@mit.edu header.s=outgoing header.b=O+nhKXjJ; arc=pass (i=1 spf=pass spfdomain=mit.edu dkim=pass dkdomain=mit.edu dmarc=pass fromdomain=mit.edu); spf=pass (google.com: domain of linux-kernel+bounces-51227-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-51227-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mit.edu X-Forwarded-Encrypted: i=1; AJvYcCUF6FpE4sF+dmipoupQq2mUDS7FugJw4XojzuadlfmR1Z5VIXn0IYuUMfjgInwRPGleuXiety6twmQP9aioh1XKRG/muAadJc+0A/SjzQ== Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id m10-20020a05622a054a00b0042bfbfef6e8si4649684qtx.553.2024.02.03.09.58.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Feb 2024 09:58:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-51227-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@mit.edu header.s=outgoing header.b=O+nhKXjJ; arc=pass (i=1 spf=pass spfdomain=mit.edu dkim=pass dkdomain=mit.edu dmarc=pass fromdomain=mit.edu); spf=pass (google.com: domain of linux-kernel+bounces-51227-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-51227-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mit.edu Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 8C86C1C21C0F for ; Sat, 3 Feb 2024 17:58:42 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7FA6C60B9B; Sat, 3 Feb 2024 17:57:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mit.edu header.i=@mit.edu header.b="O+nhKXjJ" Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33E6C604A0 for ; Sat, 3 Feb 2024 17:57:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=18.9.28.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706983054; cv=none; b=SfRazBvnpm7iQb9vhiTIPksFk34Ah/UxAfqMRS/SjdGV9AsOklP6lugufDN7JK8glphur0LPB+9jCpEK0NoScTyYDPmMyrRunPI1D8oU/oZb191M7b9P1FnH0U2cfUfgHynxDCwQcY3pzZUl5Hovdej2OIYGeowKYla0rTd2TCA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706983054; c=relaxed/simple; bh=Bo2J3ROwLIiapJHkN8vsfH6ZeYWG14rE5e/7F0cESvg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Uion1w4FcgNgj+0/F8QCamzRWY9eGTmIDE6ynn1Y2f8kaVk69KqQ/s4gKA+uWpBei4e7JwggM3tvlX5LUEQk6h05eOR4bopcm26u/Hew/QSZTDxMSW4lxaz0cJGEFeGsVIQXpYMS3/IH4r01+//VyJ5DAfBWwWr21BWUmz4hO9s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mit.edu; spf=pass smtp.mailfrom=mit.edu; dkim=pass (2048-bit key) header.d=mit.edu header.i=@mit.edu header.b=O+nhKXjJ; arc=none smtp.client-ip=18.9.28.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mit.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mit.edu Received: from cwcc.thunk.org (pool-173-48-82-236.bstnma.fios.verizon.net [173.48.82.236]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 413Huov7016901 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 3 Feb 2024 12:56:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1706983013; bh=h4uAO89DSf3RQZMzijlWW9jpjLoIfP0sKI92dPyza8I=; h=Date:From:Subject:Message-ID:MIME-Version:Content-Type; b=O+nhKXjJO4bVxPcA0+xDLeYyR/sqs8uuGW+TPaiaVDrNmVE3w+SM6deaXpmr50Ere FpiFxB9itIewMFM95qnTK+S2B6YA1YPY0Ny0klz9GmM26aR1z1E0rFzIEnJYq2H3me /LvNGIvOroh9UQca/+fn73vzUE8pqW7xsVofDlyItFWUjKqOFtzCp7/qubKcSTxewZ dDTTtGkBWmMJ459MV3miwJCllru6eUPdGei58Cmt8l7vRmrSMIG2/be8CKVh1FRrVh /+4szohXgISbQZXvji31sVZbvx0TVPNOTshSxJOoNGaNvu7gjFBJsPJuxauEnr/Y/A Jd5A8VC8RAMlA== Received: by cwcc.thunk.org (Postfix, from userid 15806) id 3261415C02FC; Sat, 3 Feb 2024 12:56:50 -0500 (EST) Date: Sat, 3 Feb 2024 12:56:50 -0500 From: "Theodore Ts'o" To: Zhang Yi Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, adilger.kernel@dilger.ca, jack@suse.cz, ritesh.list@gmail.com, hch@infradead.org, djwong@kernel.org, willy@infradead.org, zokeefe@google.com, yi.zhang@huawei.com, chengzhihao1@huawei.com, yukuai3@huawei.com, wangkefeng.wang@huawei.com Subject: Re: [PATCH v3 04/26] ext4: add a hole extent entry in cache after punch Message-ID: <20240203175650.GG36616@mit.edu> References: <20240127015825.1608160-1-yi.zhang@huaweicloud.com> <20240127015825.1608160-5-yi.zhang@huaweicloud.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240127015825.1608160-5-yi.zhang@huaweicloud.com> On Sat, Jan 27, 2024 at 09:58:03AM +0800, Zhang Yi wrote: > From: Zhang Yi > > In order to cache hole extents in the extent status tree and keep the > hole length as long as possible, re-add a hole entry to the cache just > after punching a hole. > > Signed-off-by: Zhang Yi > Reviewed-by: Jan Kara Thanks, applied.