Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp1691806rdb; Sat, 3 Feb 2024 19:00:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IHi8czG2yHysUcpxypN2xHHpFVrM7tsxLqLZdssYRM+8cIUfnd3wGPM0tL/Eqs9/gKD0t0u X-Received: by 2002:a05:6808:6407:b0:3bd:99e1:5826 with SMTP id fg7-20020a056808640700b003bd99e15826mr8018894oib.50.1707015646691; Sat, 03 Feb 2024 19:00:46 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707015646; cv=pass; d=google.com; s=arc-20160816; b=xwKTCaOnUwbovmk2c0KKe+THEyqHSZbdGjBskkThFck5O9d6kZtmXHsEZYLsM41H3j itmQ0/AzR29Gk0uso2uH+bwHuSMPxPC5lOEmB4BLhBLjS9Z5yFN2d7sFNF+ejnLqKJn8 ylIN0JtgeBc6Y4/yDTRzWGQGLwQMSI2c7/OI1OG+/Dd93NnBXDjL7UY/TC7/XAU75F7L imT5DivncLhsid6BiMOFAD9nWju7i1KmBrv84LYgPlUM9v03V02EbVW0MLZsvbwJyCIJ yZAsNMgGXCEQKArSfhXzQuYW9mTMfPisGsoyn3tsz56xDNDyUCLF1jmm1zCWZkPQykC6 FTLA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id; bh=jf7hzaHssjJ7jyzYdau/9V1eJyGAZ8MI6nPR82otjtA=; fh=NIBTYQ4QD+OR97bJo2wWIxPxxYtmCEvJv42yIzW2hMc=; b=W5Q09E/Mz6alBt8jJdlE88t5NP4jvLZU2hXKN5O6+qjaG6C5y7zyEsgIcgFFp9pHb4 qhwzDY+wy/48BUCJjNv6FMnwOIX5N7ZrhT3k8PpKBq+NYc1w0JM63QubVh4nA2GkZKZE iee6vKH9yf6LqW+KYMHcu8M8SKec7Rk9HYM/GGPFzdBxfD/tu9JNUJI7s8hl1v7uR9Te JWJW16rS2/Vnn8FuoI3kP1vw0fULQHLJOo1Nx3xUsXHlDpcUt+T4LzZ4itnB939Tw28f 73VgZsKEXA0tqoRs9kFp2UZDDwYUl3lOwwePfqBZixvOwz2Kq672O1yChJhH37RFzKvD Qg3g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=kylinos.cn); spf=pass (google.com: domain of linux-kernel+bounces-51387-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-51387-linux.lists.archive=gmail.com@vger.kernel.org" X-Forwarded-Encrypted: i=1; AJvYcCWfpyFZjZ3/JLx5c8O+IJzHI2VuyJotD351L1/MJzQSmGkayecTJb0msgEga4w/X4KLQQyVjvRye2NqPjKkcK3YR1FB8MoEyK10Y0mRwg== Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id o17-20020a63f151000000b005d8bed5ec84si3939179pgk.258.2024.02.03.19.00.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Feb 2024 19:00:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-51387-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=kylinos.cn); spf=pass (google.com: domain of linux-kernel+bounces-51387-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-51387-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 4C17B28371C for ; Sun, 4 Feb 2024 03:00:46 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3F0711869; Sun, 4 Feb 2024 03:00:37 +0000 (UTC) Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56EB88BF9; Sun, 4 Feb 2024 03:00:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=124.126.103.232 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707015636; cv=none; b=n2sNlze4/irYNZv4Ne0Sdhii0YsHq8qBI5X9bY5jmbl/YiER4JDOqjy0A6bAfei4t9yOFZ+mmdpr/baQVxgLJrNpfkmyXqv1i44FNqGXGsYbj+fagGTE154cLvyclXjrKu5EjDU8p1dXXQo7TPDal7eKtvQiz0hEjS1EhozYPio= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707015636; c=relaxed/simple; bh=dQ2sNktUa7lj6xnK2aY0LAZoG4fH5NYspNTxVsOhZiA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CsF5IIDAJ5gBacGBJEQhrM4N0OrkhbJoevNxABINPI2UAuZjitLVcheDS9pdtkJD//ydLCIhJEIZaqXjMvuEuNgSXvq9Gc//E99ihrb0nAnGbr4rtL5SN6jkU6/e8iBq29FqpTpb5ABqFTyRaEEyxZn6gkRWPKxKFf9FiiL8Ihs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn; spf=pass smtp.mailfrom=kylinos.cn; arc=none smtp.client-ip=124.126.103.232 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kylinos.cn X-UUID: 20d56d1a04a54032ba4b0001ffe4f5a8-20240204 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.35,REQID:4b3fb53d-48eb-493c-8dd1-13e2a1d25624,IP:10, URL:0,TC:0,Content:0,EDM:0,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTI ON:release,TS:-5 X-CID-INFO: VERSION:1.1.35,REQID:4b3fb53d-48eb-493c-8dd1-13e2a1d25624,IP:10,UR L:0,TC:0,Content:0,EDM:0,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:-5 X-CID-META: VersionHash:5d391d7,CLOUDID:f6029783-8d4f-477b-89d2-1e3bdbef96d1,B ulkID:240201204745Y4HHVX4X,BulkQuantity:18,Recheck:0,SF:64|66|24|17|19|44| 102,TC:nil,Content:0,EDM:-3,IP:-2,URL:0,File:nil,Bulk:40,QS:nil,BEC:nil,CO L:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_FAS,TF_CID_SPAM_FSD,TF_CID_SPAM_FSI,TF_CID_SPAM_OBB, TF_CID_SPAM_SNR X-UUID: 20d56d1a04a54032ba4b0001ffe4f5a8-20240204 Received: from mail.kylinos.cn [(39.156.73.10)] by mailgw (envelope-from ) (Generic MTA) with ESMTP id 1514006762; Sun, 04 Feb 2024 11:00:19 +0800 Received: from mail.kylinos.cn (localhost [127.0.0.1]) by mail.kylinos.cn (NSMail) with SMTP id 4FEC5E000EBC; Sun, 4 Feb 2024 11:00:19 +0800 (CST) X-ns-mid: postfix-65BEFDC3-240812241 Received: from [172.20.15.254] (unknown [172.20.15.254]) by mail.kylinos.cn (NSMail) with ESMTPA id 37BC8E000EBC; Sun, 4 Feb 2024 11:00:14 +0800 (CST) Message-ID: Date: Sun, 4 Feb 2024 11:00:14 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next] rxrpc: Simplify the allocation of slab caches To: Jiri Pirko Cc: dhowells@redhat.com, marc.dionne@auristor.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-afs@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240201100924.210298-1-chentao@kylinos.cn> <1706866812511330.14.seg@mailgw> <961cc4ad-0133-44ee-be22-ba2fbf4ebe12@kylinos.cn> Content-Language: en-US From: Kunwu Chan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2024/2/2 18:28, Jiri Pirko wrote: > Fri, Feb 02, 2024 at 10:46:33AM CET, chentao@kylinos.cn wrote: >> On 2024/2/1 20:47, Jiri Pirko wrote: >>> Thu, Feb 01, 2024 at 11:09:24AM CET, chentao@kylinos.cn wrote: >>>> Use the new KMEM_CACHE() macro instead of direct kmem_cache_create >>>> to simplify the creation of SLAB caches. >>>> >>>> Signed-off-by: Kunwu Chan >>> >>> Reviewed-by: Jiri Pirko >>> >>> btw, why don't you bulk these changes into patchsets of 15 patches? Or, >>> given the low complexicity of the patch, just merge multiple patches >>> that are changing similar locations togeter. >> Sorry, I haven't sent a patchset, I'm worried about messing up. >> I'll try to deal with these similar issues in the way you recommended in the >> future, thank you for the reminder. > > Also, please fix your email client. It breaks threads. Thanks for the reminder. Maybe it's my company email gateway that does something bad with email. The last email was quarantined, this one is the same. I asked the administrator to release it temporarily, and now it looks like there is still a problem with the gateway of my email. I'll try to use a new email. > >> -- >> Thanks, >> Kunwu >> -- Thanks, Kunwu