Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp1719857rdb; Sat, 3 Feb 2024 20:58:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IF3b3TNJulds0yWwld5SeoieYXcKu/gotRf1KVKdVMzFXoFi4GvKKRxwNIKEn7RGFqgVm9u X-Received: by 2002:a05:6512:1046:b0:510:1b51:e431 with SMTP id c6-20020a056512104600b005101b51e431mr7742007lfb.4.1707022709594; Sat, 03 Feb 2024 20:58:29 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707022709; cv=pass; d=google.com; s=arc-20160816; b=tqcgkT+AkIRKQMlz++flN/ArkIuxMle53H18nnVHj3zTf8qFYfeFEKL54Nq0ebZmEY hK7gM5GAMqHfA0Pu7wVNnvXqlHEwyzjAV3or0NdvqalWEsVpjpdXiiAvLm93gKOqucru zPIPwbeze1/2p0w6uzouHNAcPxwTFuLqK63GBPsePNI4mrWwKoEqfgmbw54DH84/mwb2 cJWc9VOWvKz4ufAgStXtB4cnhH2lqY3sE/Nev3RwRZCPRIQP4cloHK2TTYEnWt1UTu/F 9ETZsPt36rXPaBhZEtWwVlxkCxoI/qv21HcwzOr4GBskyq6e+DvlGjrucW4HVkc6VkM/ cI4g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=73nG5emiLho6o2L78eCep2kYVU6SzMamnnyIbcxLMfU=; fh=aFoyVYGwQ4fMBARInn2MOeJCsPfbcXH4m0Dul29LLJQ=; b=CCOurOE4lMERtNASe3KsQztioYbR/o/jlKmxIn8plVnn1ZlfEu2dnxXTn0IZ+KD8hA 4p2sduXhNJbmXa1QQ9isWXpLdCm5ctgd1MQBAJV8UYahBlVlmGpiNglLGKRlza+HOOqK sc5CtZL8KKH96SUs6zA4BpQFGTU5CLbKTRj/MJNV3uQm6I7Id/Il0e2f+wPJWklIcx2s YJLi/1LUXycYE0DcYwIIa6X4ZVfHvwP3yIuXT1W2u0xv4ea3NbbdRzpVJvQSdD219q22 6uQbUpLnc3Z4CPbo7658K6ahcduWiYJACCbGfuk2/jPku5anNpeGIVO8tT6KcZamQBgN Q1tw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@mit.edu header.s=outgoing header.b=TfEqg8zS; arc=pass (i=1 spf=pass spfdomain=mit.edu dkim=pass dkdomain=mit.edu dmarc=pass fromdomain=mit.edu); spf=pass (google.com: domain of linux-kernel+bounces-51432-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-51432-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mit.edu X-Forwarded-Encrypted: i=1; AJvYcCUB+vIQPyNUzXIIE+r4twZMFu/RkgAKOADmmfEn7p/Z8DXg4nJEiGmHkq53p8uBHu7tQaeyfPh1j2dtLRWuxPryP1GW3dAp9NyhTHJTxg== Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id l18-20020a170906079200b00a36cb79a69csi2484565ejc.782.2024.02.03.20.58.29 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Feb 2024 20:58:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-51432-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@mit.edu header.s=outgoing header.b=TfEqg8zS; arc=pass (i=1 spf=pass spfdomain=mit.edu dkim=pass dkdomain=mit.edu dmarc=pass fromdomain=mit.edu); spf=pass (google.com: domain of linux-kernel+bounces-51432-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-51432-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mit.edu Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 532FF1F22F53 for ; Sun, 4 Feb 2024 04:58:29 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 13A78611A; Sun, 4 Feb 2024 04:58:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mit.edu header.i=@mit.edu header.b="TfEqg8zS" Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 723C18C0B for ; Sun, 4 Feb 2024 04:58:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=18.9.28.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707022698; cv=none; b=pisPOgqZ5adb2s9nZVKX+C47GX+Mu1Zd3TZxSb5KMnlDrvOhI2f/ybwYgH91ttw/bGtXfctWkjVo0eFI4iTlRVUp+r5tZi3XvGZl+7njp9Ru+qWBPb6yeYbtVxPVMQyaRdaWbVKBJeE8lojKDtlJ8mIF4s2pfwz2ybUzUEsfUlw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707022698; c=relaxed/simple; bh=MM3MOto1zlu39y1jV9m4Xjz7/BS0oEHqaTOfKjIdVa0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=SvW+kMoQRvfuCJ4vzhKcAD1dGrXsAB3WSq6KoD3pQ1weIe9kYmvfSn/nDTjGMXHKHQIuZpgCIihmA2euW+kZAmAUPcNDG7QVGG6OPby9yQ33aBqwPVZOvSKKFHJPy3Y8c+wW0w82AaSAMKme74uoOyOiI1IwtXZunboUoBqwyec= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mit.edu; spf=pass smtp.mailfrom=mit.edu; dkim=pass (2048-bit key) header.d=mit.edu header.i=@mit.edu header.b=TfEqg8zS; arc=none smtp.client-ip=18.9.28.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mit.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mit.edu Received: from cwcc.thunk.org (pool-173-48-82-236.bstnma.fios.verizon.net [173.48.82.236]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 4144vfvf014319 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 3 Feb 2024 23:57:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1707022666; bh=73nG5emiLho6o2L78eCep2kYVU6SzMamnnyIbcxLMfU=; h=From:Subject:Date:Message-ID:MIME-Version:Content-Type; b=TfEqg8zSj4I9fkNQNMMHLcRFuRDfOnWoajgs92AHROByuHvtqK4jzjLEXN0SCR4BT /REqFRRKK/lHxUfr5g6VG5PFTMRt6D8Xt1g1y6tTUCzCPowMh82on2zw39AdExhT1T 51l/UFFq5xIsHwu92Jfk72gou94ChlUAGdxdNvrzNNn0u8d7TQQ63bYo3826Vst7+D eKFNaYIySzuY3mPNo/1asVYdwI8zU+PHyBia4QdZyJr1TB8d32gc7hYNq5Uty+UveB nhu35wIwYKj+waeEViLWHW0KgbtnMdnHG5hNbypfKKGuHo2eKUgwuDmnhQP7Yjbd8B jrTrydYkkbmSw== Received: by cwcc.thunk.org (Postfix, from userid 15806) id A656E15C02FD; Sat, 3 Feb 2024 23:57:41 -0500 (EST) From: "Theodore Ts'o" To: linux-ext4@vger.kernel.org, Baokun Li Cc: "Theodore Ts'o" , adilger.kernel@dilger.ca, jack@suse.cz, ritesh.list@gmail.com, linux-kernel@vger.kernel.org, yi.zhang@huawei.com, yangerkun@huawei.com, yukuai3@huawei.com Subject: Re: [PATCH v3 0/8] ext4: fix divide error in mb_update_avg_fragment_size() Date: Sat, 3 Feb 2024 23:57:36 -0500 Message-ID: <170702219298.205725.12570295713288350540.b4-ty@mit.edu> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240104142040.2835097-1-libaokun1@huawei.com> References: <20240104142040.2835097-1-libaokun1@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit On Thu, 04 Jan 2024 22:20:32 +0800, Baokun Li wrote: > V2->V3: > Replace patch 3's changelog with the one suggested by Jan Kara. > Refactor the code in patch 4 to make it more readable, as suggested by Jan Kara. > Patch 8 is adapted based on patch 4 after modification. > Add Reviewed-by tag. > > V1->V2: > Fixed some things pointed out by Jan Kara. > Fixed more cases where blocks could be allocated from corrupted groups. > > [...] Applied, thanks! [1/8] ext4: fix double-free of blocks due to wrong extents moved_len commit: 55583e899a53 [2/8] ext4: do not trim the group with corrupted block bitmap commit: 172202152a12 [3/8] ext4: regenerate buddy after block freeing failed if under fc replay commit: c9b528c35795 [4/8] ext4: avoid bb_free and bb_fragments inconsistency in mb_free_blocks() commit: 2331fd4a4986 [5/8] ext4: avoid dividing by 0 in mb_update_avg_fragment_size() when block bitmap corrupt commit: 993bf0f4c393 [6/8] ext4: avoid allocating blocks from corrupted group in ext4_mb_try_best_found() commit: 4530b3660d39 [7/8] ext4: avoid allocating blocks from corrupted group in ext4_mb_find_by_goal() commit: 832698373a25 [8/8] ext4: mark the group block bitmap as corrupted before reporting an error commit: c5f3a3821de4 Best regards, -- Theodore Ts'o