Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp1752496rdb; Sat, 3 Feb 2024 23:08:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IF+nMbhnpxls7YkHxRnS08NK1l7KyJukLxZImZFYslsdVDYIcDnY/ofV0+GWw0y3FiW93AZ X-Received: by 2002:a17:906:118e:b0:a35:a1dc:8920 with SMTP id n14-20020a170906118e00b00a35a1dc8920mr6540795eja.45.1707030527116; Sat, 03 Feb 2024 23:08:47 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707030527; cv=pass; d=google.com; s=arc-20160816; b=P/mvwDldy2ossbOtioT7x0XklvGoFR+KU19Q0pgeCUuA2MBPy3ka9N4IbfVSnuXKze PW2iA6f44jSqDWzUS6ZJAP9DK7bxdEe3bH8kaxqjLZMpbfmF8wLuftpqTJIkGy3z5Z2t /Su/LhACZWJuT/4WMqt3lXru3ANwy9KgEesz5xIddiM1MeAoHKBjZ8ia1+UuyVazMvx/ vrMbdsxLuw6Ae2aF7eEeCWz6QqGIAoV3VCYhDDiQ6hoGBhJCLi0XwKrpLbCzFPBP5s2m aAV2cqxCGY+D+/gDNDlvIL9akmnD3+lA1BGSoq/gWqXrfrR9YwepIrN09k1kHR9BiziX 2UPA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=RyFDdTZ65AbedsBJLL/BHCrODuLVGiyswQ+uy75XigA=; fh=YEMv/OhR7i1aisiea67+GxoZg/ynicqDAsElufGi65Q=; b=xX+OTmf8Xd8+tutVf2NlItFehLvrFqmsV6rczmjWs6rGJKADmPrt0LfsDssV0poP56 qgERBT+e+uilNh0NlTgMGFOiOIPKIqgw7mC3lCUNd9yB2e2G+ilN8ymiLi85TVNN1AI0 h+dJRVXgJae+bLGzXGDxnSagAwHmjNapNVaZC6hEDQMiEkjA4gHFrOUh+DVxoh7NFMfR Fu0eOF/UujhTT5BIg4evVf87zEmXnlH+uQdLaMVQ7Ozl3EKv4bVF3eC89kjSZiGQPZ0+ XK9MdvmZkqwWVV/Kfn8B4wqlJIeVE14uFPK7YqJ0810nTkkS3AQVZef5Hqr0jctEytW9 aQPg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ASaMiiWh; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-51481-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-51481-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=1; AJvYcCVR2lUa//3bXvUZ3C2YLFMC3y1cwdLac796NE7RML1u5kWbF7DFLloq8a0STPpTrpDp+aAOMFzjpKi+OA4fY+RgYZx5vljPYqBQ7Xu2sg== Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id kg3-20020a17090776e300b00a3609336f26si2707905ejc.685.2024.02.03.23.08.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Feb 2024 23:08:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-51481-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ASaMiiWh; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-51481-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-51481-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id D76FA1F226FC for ; Sun, 4 Feb 2024 07:08:46 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D9CDC8BE8; Sun, 4 Feb 2024 07:08:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ASaMiiWh" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EFE2C749C; Sun, 4 Feb 2024 07:08:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707030514; cv=none; b=B09DTstIsIYb/yR62CNLyonkLUg76U8H5j4Frn9hoGumLSgutwnwOurY2tr0U32BNLiCp6sP2C59tAT6ZiAkPo35wZJ5DNQXPA0XEQYjBQM/BZU/5nCT8rEpX/ukfqOBR24p73jqTR2hTiovOI9k8wKTChMLzM8oG1zECmpfFTE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707030514; c=relaxed/simple; bh=mqmUJhwMC+hGcCJ5oR07vsws9DjOZ4c7Y8U7ECmQp/M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kjFLajfv4fk/548Zxarpq7Lq358ysJVj1hC1GPksuGaDSVlWxi/YTJAMw2lyTvuytQ2IOlbr35LMGiXPHCOuEVN2RP/b9Qmp4Vaxf4MX2kaSbXnawXCFsN8z2qXlhrmtAqilvooysWDu1M+wpMcac55/2aFegjriE4257w+cWEA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ASaMiiWh; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 252B1C433C7; Sun, 4 Feb 2024 07:08:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707030513; bh=mqmUJhwMC+hGcCJ5oR07vsws9DjOZ4c7Y8U7ECmQp/M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ASaMiiWhSgJ2CqyvHxc9ihtjwFqfRghZNAxwiJDRhCqFqhM5Y4XxX+pSM55YgHRPU gjmi4ZnMtGXLjiIfLw2/V0TyCGdMOlMVXbunn7zQzEVZibyORaJ7ZSW2SFZMrpMsto TLQT7N8KZSY9MhNWZAkvjv2G/Kh/T7oKqDz3uaBbtnEVUpa6jPhr4bqxNBtajSnitY gSienoP7Rj6HOpU4BWsoJhWdHrE3gOO/qZJoabUG8y2APql/Z3lQXBPBnkUuzNeO5A 1d5j3KXJs+RQnST33R/H+JvNbTYp3FBB7e3Z57dH2jPTa1Ic7aGqaSqZUg15DMyliz RIgl3uhPFui0A== Date: Sun, 4 Feb 2024 00:08:31 -0700 From: Keith Busch To: Emily Deng Cc: amd-gfx@lists.freedesktop.org, bhelgaas@google.com, alex.williamson@redhat.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH] PCI: Add vf reset notification for pf Message-ID: References: <20240204061257.1408243-1-Emily.Deng@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240204061257.1408243-1-Emily.Deng@amd.com> On Sun, Feb 04, 2024 at 02:12:57PM +0800, Emily Deng wrote: > @@ -926,6 +926,7 @@ struct pci_driver { > int (*sriov_configure)(struct pci_dev *dev, int num_vfs); /* On PF */ > int (*sriov_set_msix_vec_count)(struct pci_dev *vf, int msix_vec_count); /* On PF */ > u32 (*sriov_get_vf_total_msix)(struct pci_dev *pf); > + void (*sriov_vf_reset_notification)(struct pci_dev *pf, struct pci_dev *vf); You've created a new callback, but there is no user. Could you resubmit this with an in-kernel use case?