Received-SPF: pass (google.com: domain of linux-kernel+bounces-51547-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Carlos Song <carlos.song@nxp.com>
To: Benjamin Bigler <benjamin@bigler.one>, "broonie@kernel.org"
	<broonie@kernel.org>, "shawnguo@kernel.org" <shawnguo@kernel.org>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>, "kernel@pengutronix.de"
	<kernel@pengutronix.de>, dl-linux-imx <linux-imx@nxp.com>,
	"stefanmoring@gmail.com" <stefanmoring@gmail.com>
CC: "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: RE: [EXT] Re: [PATCH v4] spi: imx: fix the burst length at DMA mode
 and CPU mode
Thread-Topic: [EXT] Re: [PATCH v4] spi: imx: fix the burst length at DMA mode
 and CPU mode
Thread-Index: AQHaVPwvL7F21UIX+Eu+WXSq/tBgQbD17JiAgAOBU2A=
Date: Sun, 4 Feb 2024 09:12:05 +0000
Message-ID:
 <DB7PR04MB50035B2C0BFCD427F280ECEEE8402@DB7PR04MB5003.eurprd04.prod.outlook.com>
References: <20240201105451.507005-1-carlos.song@nxp.com>
 <c7326b50ce3fe2a660638e1eb2c11519ad82feee.camel@bigler.one>
In-Reply-To: <c7326b50ce3fe2a660638e1eb2c11519ad82feee.camel@bigler.one>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?HGA5yXhdIWM9qMWVlagOKKfb1UWko15iyOdraicsQ39gXebRsaiAJgjbCaT8?=
 =?us-ascii?Q?abDnp9tIklT6AHaxtKB+78wZdu5+kUUBkVkx15HxzQ8mMWCZ1Y0WoqEORJgh?=
 =?us-ascii?Q?+M2B8RCjMD0KykPSogRfE1QzpHWc7grAyJqxDWq6HLML79PswPwmFndryhjr?=
 =?us-ascii?Q?IgQqaBOilx96pZx3vCsxyw9bmIZ12XgrlhKg1S6y7dNb5l/sacY32HykB91E?=
 =?us-ascii?Q?kDji9YS/g5WgBKRO1lVeKtAn8pKV4KEYGASMKjElD0Onh/Q2Euhdwc+AWru7?=
 =?us-ascii?Q?O+aKfIc73Aa0yvQVAd7v+0IKg5tEZu5ZTQbsbz+4OB/iAQ/iRgZNENNjIrMf?=
 =?us-ascii?Q?+FwwELo/MmZVuYgIlA+0k+CsGTMnd03l6DPfUK1z/OVd0j13u88UJsh4+GOh?=
 =?us-ascii?Q?0+RwBXisCdYqBhSGuqRlH0PK6bjzSiCDuXYuQBZg7Uw8/jS19kJ/+kZVXQU9?=
 =?us-ascii?Q?ZhPIsP02Az9wCU/6CvNHKxcLsfaP9DIaRksVmqbqIZKmWHSWiAuRRyji5h2m?=
 =?us-ascii?Q?icHBPQdv4WGLrFwMLQl+dl/J0TE89ThaHC1LlfllfLrtHQ8hhdwH5g6Qtuhc?=
 =?us-ascii?Q?FwWj4YJljsOyELC5s+HL7/pd12ftA//hE1MSvo7DgvovhFZtyHO4PjtmC5bW?=
 =?us-ascii?Q?PRd4JEZMkHwQo8xjQdAIXTqLpmbgTY0Ad7Cyc1j4oVDsfmiKt/E3HiL1gotJ?=
 =?us-ascii?Q?JIQE23JVBdxO3YBlTqGtORavF6YPFWzD6w57cuUE0qpGS8RVPbq4gfByXT55?=
 =?us-ascii?Q?5ve9k9S7ZCCTClobDdJ3nsWqT5WSa035m/upDE3CFKXQZnHwfB6T2MNfwxT9?=
 =?us-ascii?Q?o9oLXE3RXLyAm6ywMMBiUDwZehvUkTHAQm2YjVfIQeWCxh2FtwhNUS2MeC7w?=
 =?us-ascii?Q?BMFl5aczIhnbDX+xdXNW9eLvUQVoTMTbKLikP/o9GJT9NS09KnN0QHYW2Dst?=
 =?us-ascii?Q?5xY2Wc5w6BpYc8rafEmNaMAt050kkWNydsIPhl7dZgxQbzJFa5WY1e1SA5i8?=
 =?us-ascii?Q?8Uy2TsZpwSOIF1EghklDF57ikTIemg/W8462OdshA1DjVve+X4VpBVIAJ9ss?=
 =?us-ascii?Q?T5Rp3nGYUgyaKiNs1IZ7BQ+3WYbWM7+QqpJLo657BhwPss3dA9PYQhAgYG2S?=
 =?us-ascii?Q?gE8gANU8DPXxQ2wMktrtU8Opz+RssqsnaQrw+j+YFelBSw52so9Pyb+pUk7N?=
 =?us-ascii?Q?MfO+Xdr00SLyJLzAIVgpKeWAJ701hJIv+PXb1z+hG0aL4Ji4WZAdGMWL9bV7?=
 =?us-ascii?Q?azb1wcZ1mIkSztmDshIbw2bpgwSJyy/4NCwstIl/LbzbAKZttl9NiMd1ISRx?=
 =?us-ascii?Q?Tdk9Ti2xiamSES3Vto5Rdv9MlaGa4upkbGcXPCtgE4rJGdLxA3+Vn2YZg1eS?=
 =?us-ascii?Q?yW3pLyPF5EW87eURRmI9glgws02FerNrgbQ6tvyL4g0+85fZjBph/Mo9hc1l?=
 =?us-ascii?Q?6WEIreJsMX7Q3pwxEbQu9XiZCou4rLK9eWgKKrekJUNAOJq5Tm1VworJESwb?=
 =?us-ascii?Q?1XPvQooyBTKjdkmSzYqtqJ/rc3sQiKfHtCYCZMn2BNBHcoVRjgVkYFrkaSez?=
 =?us-ascii?Q?1EPhdXv1cY5+SwW2/o0=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DB7PR04MB5003.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f2cc70bf-3865-47bc-05a1-08dc25615ba1
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Feb 2024 09:12:05.8606
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: cN+f9gTk7pzu62K+rs/Dt9srQaoW4pfNPRr4aoZjSCsxvU8aEsS7AEsnLMVB+L6l2fXpz45adYZnWdZEBj38FA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8922


> -----Original Message-----
> From: Benjamin Bigler <benjamin@bigler.one>
> Sent: Friday, February 2, 2024 4:15 AM
> To: Carlos Song <carlos.song@nxp.com>; broonie@kernel.org;
> shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de;
> dl-linux-imx <linux-imx@nxp.com>; stefanmoring@gmail.com
> Cc: linux-spi@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> linux-kernel@vger.kernel.org
> Subject: [EXT] Re: [PATCH v4] spi: imx: fix the burst length at DMA mode =
and
> CPU mode
>
> Caution: This is an external email. Please take care when clicking links =
or
> opening attachments. When in doubt, report the message using the 'Report =
this
> email' button
>
>
> On Thu, 2024-02-01 at 18:54 +0800, carlos.song@nxp.com wrote:
> > From: Carlos Song <carlos.song@nxp.com>
> >
> > For DMA mode, the bus width of the DMA is equal to the size of data
> > word, so burst length should be configured as bits per word.
> >
> > For CPU mode, because of the spi transfer len is in byte, so burst
> > length should be configured as bits per byte * spi_imx->count.
> >
> > Signed-off-by: Carlos Song <carlos.song@nxp.com>
> > Reviewed-by: Clark Wang <xiaoning.wang@nxp.com>
> > Fixes: e9b220aeacf1 ("spi: spi-imx: correctly configure burst length
> > when using dma")
> > Fixes: 5f66db08cbd3 ("spi: imx: Take in account bits per word instead
> > of assuming 8-bits")
> > ---
> > Changes for V3:
> > - include <linux/bits.h>
> > Changes for V4:
> > - keep the includes sorted alphabetically.
> > ---
> >  drivers/spi/spi-imx.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c index
> > 546cdce525fc..f7990ac2c654 100644
> > --- a/drivers/spi/spi-imx.c
> > +++ b/drivers/spi/spi-imx.c
> > @@ -2,6 +2,7 @@
> >  // Copyright 2004-2007 Freescale Semiconductor, Inc. All Rights Reserv=
ed.
> >  // Copyright (C) 2008 Juergen Beisert
> >
> > +#include <linux/bits.h>
> >  #include <linux/clk.h>
> >  #include <linux/completion.h>
> >  #include <linux/delay.h>
> > @@ -660,15 +661,14 @@ static int mx51_ecspi_prepare_transfer(struct
> spi_imx_data *spi_imx,
> >                       << MX51_ECSPI_CTRL_BL_OFFSET;
> >       else {
> >               if (spi_imx->usedma) {
> > -                     ctrl |=3D (spi_imx->bits_per_word *
> > -
> spi_imx_bytes_per_word(spi_imx->bits_per_word) - 1)
> > +                     ctrl |=3D (spi_imx->bits_per_word - 1)
> >                               << MX51_ECSPI_CTRL_BL_OFFSET;
> >               } else {
> >                       if (spi_imx->count >=3D
> MX51_ECSPI_CTRL_MAX_BURST)
> > -                             ctrl |=3D (MX51_ECSPI_CTRL_MAX_BURST -
> 1)
> > +                             ctrl |=3D (MX51_ECSPI_CTRL_MAX_BURST *
> > + BITS_PER_BYTE - 1)
> >                                               <<
> MX51_ECSPI_CTRL_BL_OFFSET;
> >                       else
> > -                             ctrl |=3D (spi_imx->count *
> spi_imx->bits_per_word - 1)
> > +                             ctrl |=3D (spi_imx->count * BITS_PER_BYTE
> > + - 1)


Hi,

Thank you! You re right. I have get the patch history that spi->bits_per_wo=
rd =3D 9 will
break the driver, this is a special case.

So burst length should be calculated by the number of words, instead of the=
 number of bytes, otherwise the transmission of these non-byte-aligned word=
 will break the driver.

the burst length can be set by:
spi_imx->count/DIV_ROUND_UP(spi_imx->bits_per_word, BITS_PER_BYTE) * spi_im=
x->bits_per_word.

I will set V5 later.
> I think that will not work for drivers which dont use bits_per_word=3D8.
> https://lore.ker/
> nel.org%2Fall%2F20230917164037.29284-1-stefanmoring%40gmail.com%2F&
> data=3D05%7C02%7Ccarlos.song%40nxp.com%7C6f52557285a34b97c6f508dc2
> 3626f51%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638424152
> 883113184%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoi
> V2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=3D2RerZ6
> 2kHdgiwqi5yxnDPLwWViplttHA2E05WFZmTuw%3D&reserved=3D0
> >                                               <<
> MX51_ECSPI_CTRL_BL_OFFSET;
> >               }
> >       }
>
> Best regards,
> Benjamin Bigler