Received-SPF: pass (google.com: domain of linux-kernel+bounces-51555-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <82a0768e-95b0-4091-bdd1-14c3e893726b@web.de>
Date: Sun, 4 Feb 2024 10:24:18 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-GB
To: kernel-janitors@vger.kernel.org,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>,
 Bjorn Andersson <andersson@kernel.org>,
 David Collins <quic_collinsd@quicinc.com>, Fei Shao <fshao@chromium.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Peng Wu <wupeng58@huawei.com>, Stephen Boyd <sboyd@kernel.org>,
 Vinod Koul <vkoul@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
 Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
From: Markus Elfring <Markus.Elfring@web.de>
Subject: [PATCH] spmi: pmic-arb: Replace three IS_ERR() calls by null pointer
 checks in spmi_pmic_arb_probe()
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:vQncsZ5BOhQ=;t9WJT7hmIaKNMsh19fZe9gab+qf
 1bj5KEtNlM5jYr/VYMBeXzGe3Clz+1gBewcBuh9mIb1PdQ1RXJWcGgrg0J7fUVEkEQrQ16DID
 CWTjIxY6Z41Z6k42ccXpDGpq81LC6mJesscSkXEU6UUgSVgGcHg0HieV4Ydotl0Gq37qzCKw8
 6i8FGA5mAhkG7zk6O2IRnpjyV0omdioRfWbNxJRWPwvPumJpCwHM5KpRl9mA+jZJwFvg6Xrsn
 LCOJg4q5xMXbCgz3tQh+LV68BicXgog3kSeuJnaGQRcneIjaZNx+zACK2tay6tza0+NzsPb2l
 MVj5uRHmAo24oj4s4MCdraU7a1+VDTYYZe99rGxYZfbsJ65xwLz9jdJ5a5JPJwPYRCoHTPBRy
 sZhj3INglw9F8svsHFQI5pkyYkZjsA8ubIFIaPj+GQP0AD1a0JBtXMSMNqkobViGh++hHlhvc
 FwhJnUZgHMbtRuS4SLR0iX5Zhjn+n4IZFzeEuXzZRvvwP3j5UEzlrwbIBGKcjRcAoWlGEiwHm
 v/1zbykGKkp+ZjhOeN4AK0TDcmqkmdePk554eCT5MDA5rRSevoChrX5ITxsNZcMgmYAH25H9p
 OiLY9crNgPOaQAuSfeYVrl5gFh9hb5ZAoXapHNKmzappsCKGAkW9aWvU29UJqMpPLoSsdYp8v
 b+a+wbwWuwX00r4+DL5PJyloIkY9gOC+u1WWeq6RwEW9R+AsT1bBVj6pJ3UYTYPlNPLLSnM7g
 BOLcRbP3q1e/arVTusNNSJCe7aFgrnwjpS1J9H3fWffa+gWPegBQxsk90piiy40p3oXi5yS6i
 nAyoq2++deWVzBsJKr06XcbTTCMK0twU+WeXkaxD5NM5U=

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 4 Feb 2024 09:39:48 +0100

The devm_ioremap() function does not return error pointers.
It returns NULL on error.
This issue was detected once more also by using the Coccinelle software.

Update three checks (and corresponding error codes) for failed
function calls accordingly.

Fixes: ffdfbafdc4f4 ("spmi: Use devm_spmi_controller_alloc()")
Fixes: 231601cd22bd ("spmi: pmic-arb: Add support for PMIC v7")
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
=2D--

See also:
Suggestion by Peng Wu
[PATCH -next] spmi: pmic-arb: fix a NULL vs IS_ERR() check in spmi_pmic_ar=
b_probe()
https://lore.kernel.org/lkml/20221115090927.47143-1-wupeng58@huawei.com/
https://lkml.org/lkml/2022/11/15/197


 drivers/spmi/spmi-pmic-arb.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c
index 9ed1180fe31f..937c15324513 100644
=2D-- a/drivers/spmi/spmi-pmic-arb.c
+++ b/drivers/spmi/spmi-pmic-arb.c
@@ -1462,8 +1462,8 @@ static int spmi_pmic_arb_probe(struct platform_devic=
e *pdev)
 	 */
 	res =3D platform_get_resource_byname(pdev, IORESOURCE_MEM, "core");
 	core =3D devm_ioremap(&ctrl->dev, res->start, resource_size(res));
-	if (IS_ERR(core))
-		return PTR_ERR(core);
+	if (!core)
+		return -ENOMEM;

 	pmic_arb->core_size =3D resource_size(res);

@@ -1495,15 +1495,15 @@ static int spmi_pmic_arb_probe(struct platform_dev=
ice *pdev)
 						   "obsrvr");
 		pmic_arb->rd_base =3D devm_ioremap(&ctrl->dev, res->start,
 						 resource_size(res));
-		if (IS_ERR(pmic_arb->rd_base))
-			return PTR_ERR(pmic_arb->rd_base);
+		if (!pmic_arb->rd_base)
+			return -ENOMEM;

 		res =3D platform_get_resource_byname(pdev, IORESOURCE_MEM,
 						   "chnls");
 		pmic_arb->wr_base =3D devm_ioremap(&ctrl->dev, res->start,
 						 resource_size(res));
-		if (IS_ERR(pmic_arb->wr_base))
-			return PTR_ERR(pmic_arb->wr_base);
+		if (!pmic_arb->wr_base)
+			return -ENOMEM;
 	}

 	pmic_arb->max_periphs =3D PMIC_ARB_MAX_PERIPHS;
=2D-
2.43.0