Received-SPF: pass (google.com: domain of linux-kernel+bounces-51564-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Sun, 4 Feb 2024 11:44:46 +0200
From: Leon Romanovsky <leon@kernel.org>
To: Bart Van Assche <bvanassche@acm.org>
Cc: William Kucharski <william.kucharski@oracle.com>,
	Jason Gunthorpe <jgg@ziepe.ca>, linux-rdma@vger.kernel.org,
	target-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] RDMA/srpt: Do not register event handler until srpt
 device is fully setup
Message-ID: <20240204094446.GA5400@unreal>
References: <20240131062438.869370-1-william.kucharski@oracle.com>
 <20240131062438.869370-2-william.kucharski@oracle.com>
 <894db19d-5287-4ed8-a0d9-0211b365eafa@acm.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <894db19d-5287-4ed8-a0d9-0211b365eafa@acm.org>

On Thu, Feb 01, 2024 at 06:48:34AM -0800, Bart Van Assche wrote:
> On 1/30/24 22:24, William Kucharski wrote:
> > Upon rare occasions, KASAN reports a use-after-free Write
> > in srpt_refresh_port().
> > 
> > This seems to be because an event handler is registered before the
> > srpt device is fully setup and a race condition upon error may leave a
> > partially setup event handler in place.
> > 
> > Instead, only register the event handler after srpt device initialization
> > is complete.
> 
> A Fixes: tag is missing. Otherwise this patch looks good to me. Hence:

I added this line:
Fixes: a42d985bd5b2 ("ib_srpt: Initial SRP Target merge for v3.3-rc1")

> 
> Reviewed-by: Bart Van Assche <bvanassche@acm.org>

Thanks