Received-SPF: pass (google.com: domain of linux-kernel+bounces-51655-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Sun, 4 Feb 2024 13:06:00 +0000
From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Mike Looijmans <mike.looijmans@topic.nl>, devicetree@vger.kernel.org,
 linux-iio@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>, Haibo Chen
 <haibo.chen@nxp.com>, Hugo Villeneuve <hvilleneuve@dimonoff.com>,
 Lars-Peter Clausen <lars@metafoo.de>, Lee Jones <lee@kernel.org>, Leonard
 =?UTF-8?B?R8O2aHJz?= <l.goehrs@pengutronix.de>, Liam Beguin
 <liambeguin@gmail.com>, Liam Girdwood <lgirdwood@gmail.com>, Maksim Kiselev
 <bigunclemax@gmail.com>, Marcus Folkesson <marcus.folkesson@gmail.com>,
 Marius Cristea <marius.cristea@microchip.com>, Mark Brown
 <broonie@kernel.org>, Niklas Schnelle <schnelle@linux.ibm.com>, Okan Sahin
 <okan.sahin@analog.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] iio: adc: ti-ads1298: Add driver
Message-ID: <20240204130600.37083440@jic23-huawei>
In-Reply-To: <ZbuCqEWqpDadeF_v@smile.fi.intel.com>
References: <20231213094722.31547-1-mike.looijmans@topic.nl>
	<1b153bce-a66a-45ee-a5c6-963ea6fb1c82.949ef384-8293-46b8-903f-40a477c056ae.27993507-256d-4b05-88df-c8643e7f1a68@emailsignatures365.codetwo.com>
	<20231213094722.31547-2-mike.looijmans@topic.nl>
	<ZXnF72wJCAeYWA8X@smile.fi.intel.com>
	<406d445a-3ce3-4253-8966-de2dac6f7c23@topic.nl>
	<ZbuCqEWqpDadeF_v@smile.fi.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 1 Feb 2024 13:38:16 +0200
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> On Wed, Jan 31, 2024 at 05:10:08PM +0100, Mike Looijmans wrote:
> > On 13-12-2023 15:55, Andy Shevchenko wrote:  
> > > On Wed, Dec 13, 2023 at 10:47:22AM +0100, Mike Looijmans wrote:  
> 
> First of all, please remove unneeded context, don't make me waste time on doing
> that for you!
> 
> ...
> 
> > > 		*val = sign_extend32(get_unaligned_be24(priv->rx_buffer + chan->address),
> > > 				     23);  
> > 
> > Doesn't fit, first line is 83 characters by my count...  
> 
> Is it a problem?

To add a bit more info here. For IIO at least (and most of the rest of the kernel)
it's fine to go over 80 chars if there is a significant cost in readability to break
the line.  Here that is the case + you are only going 3 chars over so it's fine
to do so.

Jonathan

> 
>