Received-SPF: pass (google.com: domain of linux-kernel+bounces-51654-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Sun, 4 Feb 2024 13:04:15 +0000
From: Jonathan Cameron <jic23@kernel.org>
To: Alisa-Dariana Roman <alisadariana@gmail.com>
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>, Alisa-Dariana Roman
 <alisa.roman@analog.com>, linux-iio@vger.kernel.org,
 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Lars-Peter
 Clausen <lars@metafoo.de>, Michael Hennerich
 <Michael.Hennerich@analog.com>, Alexandru Tachici
 <alexandru.tachici@analog.com>, Peter Zijlstra <peterz@infradead.org>, Andy
 Shevchenko <andriy.shevchenko@linux.intel.com>, "Rafael J. Wysocki"
 <rafael@kernel.org>
Subject: Re: [PATCH v2 4/4] iio: adc: ad7192: Add AD7194 support
Message-ID: <20240204130415.56ca3c42@jic23-huawei>
In-Reply-To: <8c7839a9-b1f1-4e58-b35e-afdc8503c90f@gmail.com>
References: <20231114200533.137995-1-alisa.roman@analog.com>
	<20231114200533.137995-5-alisa.roman@analog.com>
	<20231126163426.66e51114@jic23-huawei>
	<8c7839a9-b1f1-4e58-b35e-afdc8503c90f@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 2 Feb 2024 16:32:14 +0200
Alisa-Dariana Roman <alisadariana@gmail.com> wrote:

> On 26.11.2023 18:34, Jonathan Cameron wrote:
> > On Tue, 14 Nov 2023 22:05:33 +0200
> > Alisa-Dariana Roman <alisadariana@gmail.com> wrote:
> >   
> >> Unlike the other AD719Xs, AD7194 has configurable differential
> >> channels. The default configuration for these channels can be changed
> >> from the devicetree.
> >>
> >> The default configuration is hardcoded in order to have a stable number
> >> of channels.
> >>
> >> Also modify config AD7192 description for better scaling.
> >>
> >> Signed-off-by: Alisa-Dariana Roman <alisa.roman@analog.com>  
> > 
> > Not directly related to this patch (which looks fine to me)
> > but any idea why 3db_frequency_available is not using read_avail?
> > 
> > Seems sensible to convert it over given all the other cases are using that
> > and it will allow dropping at least some of the attributes infrastructure
> > for some devices.  
> 
> Thank you very much for the feedback!
> 
> I actually tried then to use read_avail for the 3db frequencies, but it 
> required a greater rework. If I remember correctly, the four possible 
> frequency choices need to be stored in the ad7192_state for it to work. 
> Should I add a patch with these changes?
> 
If will end up a tiny bit more complex than currently because of the need
to stash them in an array rather than simply print the strings directly.
But not a lot and should allow you to get rid of a small amount of other code.

Not urgent, but I think this would be a nice change in the longer term

Thanks,

Jonathan