Received-SPF: pass (google.com: domain of linux-kernel+bounces-51670-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Sun, 4 Feb 2024 20:38:49 +0700
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Thorsten Blum <thorsten.blum@toblux.com>,
	Jonathan Corbet <corbet@lwn.net>
Cc: workflows@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Documentation: multiple .rst files: Fix grammar and more
 consistent formatting
Message-ID: <Zb-TaQYEVE29duCT@archie.me>
References: <20240203215345.4396-1-thorsten.blum@toblux.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="ClGYZWwBz0LpnQpN"
Content-Disposition: inline
In-Reply-To: <20240203215345.4396-1-thorsten.blum@toblux.com>


--ClGYZWwBz0LpnQpN
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Feb 03, 2024 at 10:53:45PM +0100, Thorsten Blum wrote:
> diff --git a/Documentation/doc-guide/sphinx.rst b/Documentation/doc-guide=
/sphinx.rst
> index 3d125fb4139d..2526811489bf 100644
> --- a/Documentation/doc-guide/sphinx.rst
> +++ b/Documentation/doc-guide/sphinx.rst
> @@ -63,8 +63,7 @@ Image output
>  ------------
> =20
>  The kernel documentation build system contains an extension that
> -handles images on both GraphViz and SVG formats (see
> -:ref:`sphinx_kfigure`).
> +handles images on both GraphViz and SVG formats (see :ref:`sphinx_kfigur=
e`).
> =20
>  For it to work, you need to install both GraphViz and ImageMagick
>  packages. If those packages are not installed, the build system will
> @@ -108,7 +107,7 @@ further info.
>  Checking for Sphinx dependencies
>  --------------------------------
> =20
> -There's a script that automatically check for Sphinx dependencies. If it=
 can
> +There's a script that automatically checks for Sphinx dependencies. If i=
t can
>  recognize your distribution, it will also give a hint about the install
>  command line options for your distro::
> =20
> @@ -283,7 +282,7 @@ Here are some specific guidelines for the kernel docu=
mentation:
>    from highlighting. For a short snippet of code embedded in the text, u=
se \`\`.
> =20
> =20
> -the C domain
> +The C domain
>  ------------
> =20
>  The **Sphinx C Domain** (name c) is suited for documentation of C API. E=
=2Eg. a
> diff --git a/Documentation/process/changes.rst b/Documentation/process/ch=
anges.rst
> index 50b3d1cb1115..4c1552160321 100644
> --- a/Documentation/process/changes.rst
> +++ b/Documentation/process/changes.rst
> @@ -144,8 +144,8 @@ Bison
>  Since Linux 4.16, the build system generates parsers
>  during build.  This requires bison 2.0 or later.
> =20
> -pahole:
> --------
> +pahole
> +------
> =20
>  Since Linux 5.2, if CONFIG_DEBUG_INFO_BTF is selected, the build system
>  generates BTF (BPF Type Format) from DWARF in vmlinux, a bit later from =
kernel
> diff --git a/Documentation/process/howto.rst b/Documentation/process/howt=
o.rst
> index 6c73889c98fc..eebda4910a88 100644
> --- a/Documentation/process/howto.rst
> +++ b/Documentation/process/howto.rst
> @@ -351,8 +351,8 @@ Managing bug reports
>  --------------------
> =20
>  One of the best ways to put into practice your hacking skills is by fixi=
ng
> -bugs reported by other people. Not only you will help to make the kernel
> -more stable, but you'll also learn to fix real world problems and you wi=
ll
> +bugs reported by other people. Not only will you help to make the kernel
> +more stable, but you'll also learn to fix real-world problems and you wi=
ll
>  improve your skills, and other developers will be aware of your presence.
>  Fixing bugs is one of the best ways to get merits among other developers,
>  because not many people like wasting time fixing other people's bugs.

LGTM, thanks!

Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>

--=20
An old man doll... just what I always wanted! - Clara

--ClGYZWwBz0LpnQpN
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCZb+TZAAKCRD2uYlJVVFO
o6LXAP9LER+inJkvJyemzh7msDV+3YcY/N8k8g0xva5rXFx9yAEAgNatOyWui6/R
+rGd8qwq9Ttely+TiOmq9W2oGAzapQE=
=OGPV
-----END PGP SIGNATURE-----

--ClGYZWwBz0LpnQpN--