Received-SPF: pass (google.com: domain of linux-kernel+bounces-51688-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Sun, 4 Feb 2024 14:03:26 +0000
From: Jonathan Cameron <jic23@kernel.org>
To: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: jikos@kernel.org, lars@metafoo.de, Basavaraj.Natikar@amd.com,
 linux-input@vger.kernel.org, linux-iio@vger.kernel.org,
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: hid-sensor-als: Return 0 for
 HID_USAGE_SENSOR_TIME_TIMESTAMP
Message-ID: <20240204140326.09a91224@jic23-huawei>
In-Reply-To: <20240204125617.2635574-1-srinivas.pandruvada@linux.intel.com>
References: <20240204125617.2635574-1-srinivas.pandruvada@linux.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Sun,  4 Feb 2024 04:56:17 -0800
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> wrote:

> When als_capture_sample() is called with usage ID
> HID_USAGE_SENSOR_TIME_TIMESTAMP, return 0. The HID sensor core ignores
> the return value for capture_sample() callback, so return value doesn't
> make difference. But correct the return value to return success instead
> of -EINVAL.
> 
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Applied and marked for stable.

Whilst this is the minimal fix (and so the right one!) it would be good
to change this as a follow up to just use direct returns as then this
sort of bug won't get reintroduced and the code will be a bit simpler.

Jonathan

> ---
> As part of review comments for series "Add support of color temperature
> and chromaticity". This is separate from the series as this is
> unrelated.
> 
>  drivers/iio/light/hid-sensor-als.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iio/light/hid-sensor-als.c b/drivers/iio/light/hid-sensor-als.c
> index 5cd27f04b45e..b6c4bef2a7bb 100644
> --- a/drivers/iio/light/hid-sensor-als.c
> +++ b/drivers/iio/light/hid-sensor-als.c
> @@ -226,6 +226,7 @@ static int als_capture_sample(struct hid_sensor_hub_device *hsdev,
>  	case HID_USAGE_SENSOR_TIME_TIMESTAMP:
>  		als_state->timestamp = hid_sensor_convert_timestamp(&als_state->common_attributes,
>  								    *(s64 *)raw_data);
> +		ret = 0;
>  		break;
>  	default:
>  		break;