Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp1915225rdb; Sun, 4 Feb 2024 06:50:10 -0800 (PST) X-Google-Smtp-Source: AGHT+IH1MNe1HftvLS6AE1a95Qaa4FAuDAeqt9GcQYhqnR11KfOprsZ5cmM4ry4sh80+GnL1U0tU X-Received: by 2002:a17:90a:fd93:b0:296:1127:ceca with SMTP id cx19-20020a17090afd9300b002961127cecamr9702480pjb.6.1707058210584; Sun, 04 Feb 2024 06:50:10 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707058210; cv=pass; d=google.com; s=arc-20160816; b=Vcsipnn9L1AQlu86Gq88kRULwbIUy+AOkMr/TUKT3STyc4DpU2sP3sDBsIEeXh7qJh M7o6YaJDJe/WRwq69UZM5l8wwGoN9amlFn7vUnzgeKgrCYkyL2hRX2eTEB9wv+60LlU1 bTiqbMRvu9uFsKCJ4XEXdHAmhwZiCD9/jqKk5L97YBrKOcdriajM6ailqMN7gN3We4GX nsWgl6aU/DYUBVSFsytXZ2kkqyA1ks47DXgpJ4N8oj6SMNBJFQVvgsfWQyShp5+qcwoG rwftqqGWwdBDkQtyeoEReYdlh6FljB+gzbPCUUkjPbZKbK3txOiVp7rkQKX1dS0MAH0k wtTQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:sender:dkim-signature; bh=Z+SGUHbr9Bwe1092OOL4Vmw2wvzHSTzn/lVZ6fgcAdk=; fh=SL1hfy0Zr7SIYm6DueXPT9vewH+rn7DWHJm6GSEfGm8=; b=oepFE+ZSRQj0sytBgTQ6Omst41sm1Khvd65V19ZcYI7D4SHsVELI+b7H6SdkDeZ2Ek rkEWz0EoSzYST4oqovYaBOXvnsSUOMBgH8x98m6t/oVvzpmEu4KX5vq5q5B9URP0N5wr 5KUMTVEJeHByukXPSjpBX5JoRfFcOV/mALl/szwq4yHFdjFWbpMTpjYJzRVE6t8pfPYr tTFOiAlvBdG+YEWEEzhpI0e55aMAVQ1SjjNIs7lnIV2XMFtkf9VJSp1/ECkogSLWmhsy Zg3GFcx6U9PLO/OBa2U1BkCEfL3wa3XV2rD+kIexuoGz7OFertb5cI2a8kDmULZzlH+W CK1w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=RXE9ZS7E; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-51725-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-51725-linux.lists.archive=gmail.com@vger.kernel.org" X-Forwarded-Encrypted: i=1; AJvYcCWVf3e95YZ0PBHKG/fCKGLE19fVZs39kOCilQByihsDK8LL+qOWSGze1tH9q2EyIvC8Io3Xf5bFRjfzfDYABjDaqWGq85jDYdBaak/S+w== Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id t1-20020a170902bc4100b001d9167b8e73si1383738plz.444.2024.02.04.06.50.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Feb 2024 06:50:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-51725-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=RXE9ZS7E; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-51725-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-51725-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id A4458B222A5 for ; Sun, 4 Feb 2024 14:49:44 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 408E422EF3; Sun, 4 Feb 2024 14:48:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RXE9ZS7E" Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED86C22EE9; Sun, 4 Feb 2024 14:48:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707058082; cv=none; b=AtgEJWTq+8c97lMIvYK3tk3nOE8Ukdx20UAlgJCqAHx1+Hpit3EjUinpJDbCdHDc/IIswLSsmvkAW0yscrPInt3uDG0RDJoAtl3K6oGhgiEa6kXeRXkFHtG9B/wnWNOdx3xJl7DZVkkgJwBwYDqKzdybqEtGY+sHpl+KxaoBB20= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707058082; c=relaxed/simple; bh=90KNTWxfgeziFDQ/3TZ0B5vtg7ngUvLnBCrxOucvty4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=g5bRrDhoH6eiT3zOPkPUzQvZed7/aF4wlcLu6cmVOOiAHvRGzVVocuAAoHfoBGbKU1oHJjnd3ZNduyP3m7c5bxbRW3LvqlHYdjQ2oX6Zlsh76z1RK2XDwIGgdN6X1ooEfVByujK40mIYNY5QLT1nLgyl9Ar33i7dQRQfnp8NlX4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RXE9ZS7E; arc=none smtp.client-ip=209.85.215.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-53fbf2c42bfso2997919a12.3; Sun, 04 Feb 2024 06:48:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707058080; x=1707662880; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=Z+SGUHbr9Bwe1092OOL4Vmw2wvzHSTzn/lVZ6fgcAdk=; b=RXE9ZS7E6Qqs7H3IGsJuEnsDw9Ffx94WjKYmvtKQr/NAjXdQmIBpoXC6cY7NG+QSOa 4hkOoRKWe3oLvAYBL/2RPuUoGtVVP/UShzMOVWFRn+S2N20v+aLV1LHMYTwkhU1ovs2M HzJB2FIQF41ryhyg/CMQonf6aQuH5CZCMoPQNhnvL8DsGoY5Ssi5AUiYFM/WbZq17a5a TudGOXi5vUuZO5fZYrXtW8C8WgnOMK5uaawxwY7PC9/EqEqyEZu6/71zont/VlOe8N+L CrgdRklOx5VDwyOcLxQ6X0vhlsJGTlN8d7Oes+lGmSP3L12XIaqgMzhK9uZGXz683iLI aryw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707058080; x=1707662880; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Z+SGUHbr9Bwe1092OOL4Vmw2wvzHSTzn/lVZ6fgcAdk=; b=tMWeP5ry61eYwMNtGychwgPsrX6HN+UezZCz7FBACbRJdMLHbPdqUx8P7ahNP7kCSl BSLC8ZZXfVMhwHR9c8rKqB0EkQsGzxBxFd633s2xsIeWA+CjoOhsNAbCN7noL4lr2+zo O4PZJozK6z48wepfjXx2hwVJG7hELn3SWmAa5rTK6olZGKcqXiWoQtAtCDgKCEjmCIay A25pBBMB/9BzJ5JFX2jZaQ4yngrAoFnAB5PW1qS8MWeVPDvsop44/pU5ks+za8QVaUu4 FwB9+9tSPvsfHTsvlyyc5iLkaixb67784rxoxYPOAnSb4RM70g46aNIBV+rkcRO+DMBe e2Lg== X-Gm-Message-State: AOJu0YywiVe8DBcSJnwQItwhRWjuBE9CRDzHRULYA7FePvfayhB9mvMK niR/sn2eKxXegEki7+RN05gmHi0ZlCBsVHW97LMOQ6DoCVm2P9Pfxw0delnX X-Received: by 2002:aa7:9836:0:b0:6de:1d46:1fa5 with SMTP id q22-20020aa79836000000b006de1d461fa5mr10660201pfl.13.1707058080198; Sun, 04 Feb 2024 06:48:00 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCWUAgaXESL9XM7mQry5j0qM6YMcVKNlkkdM6qLJu5roLhXds4kCzGYxMjEFEQwsn1jwPFlOcLJgS+IMVV+0qY872o2U4A5cH6XIfpTkGXHnOH1peZfWkMhmdy4hOqcJGV3pM/yuIARQtFrgtFN1blJekHo/ZOqmaYjpmhC1z3DG Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id y18-20020aa79e12000000b006e0418993cesm512599pfq.8.2024.02.04.06.47.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Feb 2024 06:47:59 -0800 (PST) Sender: Guenter Roeck Date: Sun, 4 Feb 2024 06:47:58 -0800 From: Guenter Roeck To: Zhang Rui Cc: jdelvare@suse.com, fenghua.yu@intel.com, linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2 08/11] hwmon: (coretemp) Abstract core_temp helpers Message-ID: <717bdf59-4556-49d7-8c73-5e02c0f3df90@roeck-us.net> References: <20240202092144.71180-1-rui.zhang@intel.com> <20240202092144.71180-9-rui.zhang@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240202092144.71180-9-rui.zhang@intel.com> On Fri, Feb 02, 2024 at 05:21:41PM +0800, Zhang Rui wrote: > coretemp driver has an obscure and fragile logic for handling package > and core temperature data. > > Place the logic in newly introduced helpers for further optimizations. > > No functional change. > > Signed-off-by: Zhang Rui Applied. Thanks, Guenter