Received-SPF: pass (google.com: domain of linux-kernel+bounces-51739-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Oleksandr Natalenko <oleksandr@natalenko.name>
To: rafael.j.wysocki@intel.com, Mario.Limonciello@amd.com,
 viresh.kumar@linaro.org, Ray.Huang@amd.com, gautham.shenoy@amd.com,
 Borislav.Petkov@amd.com, Perry Yuan <perry.yuan@amd.com>
Cc: Alexander.Deucher@amd.com, Xinmei.Huang@amd.com, Xiaojian.Du@amd.com,
 Li.Meng@amd.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject:
 Re: [PATCH v2 6/6] cpufreq: amd-pstate: remove legacy set_boost callback for
 passive mode
Date: Sun, 04 Feb 2024 15:57:17 +0100
Message-ID: <4896392.31r3eYUQgx@natalenko.name>
In-Reply-To:
 <e0746643c781f638c9e9cb8a6d2ceebeeb906f95.1707047943.git.perry.yuan@amd.com>
References:
 <cover.1707047943.git.perry.yuan@amd.com>
 <e0746643c781f638c9e9cb8a6d2ceebeeb906f95.1707047943.git.perry.yuan@amd.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="nextPart4545156.LvFx2qVVIh";
 micalg="pgp-sha256"; protocol="application/pgp-signature"

--nextPart4545156.LvFx2qVVIh
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"; protected-headers="v1"
From: Oleksandr Natalenko <oleksandr@natalenko.name>
Date: Sun, 04 Feb 2024 15:57:17 +0100
Message-ID: <4896392.31r3eYUQgx@natalenko.name>
MIME-Version: 1.0

Hello.

On ned=C4=9Ble 4. =C3=BAnora 2024 13:12:57 CET Perry Yuan wrote:
> With new freqency boost interface supported, legacy boost control
> doesn't make sense any more which only support passive mode.
> so it can remove the legacy set_boost interface from amd-pstate driver
> in case of there is conflict with new boost control logic.
>=20
> Signed-off-by: Perry Yuan <perry.yuan@amd.com>
> ---
>  drivers/cpufreq/amd-pstate.c | 1 -
>  include/linux/amd-pstate.h   | 1 -
>  2 files changed, 2 deletions(-)
>=20
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 02a76b8fb298..4e377efdd4ed 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -1492,7 +1492,6 @@ static struct cpufreq_driver amd_pstate_driver =3D {
>  	.exit		=3D amd_pstate_cpu_exit,
>  	.suspend	=3D amd_pstate_cpu_suspend,
>  	.resume		=3D amd_pstate_cpu_resume,
> -	.set_boost	=3D amd_pstate_set_boost,
>  	.name		=3D "amd-pstate",
>  	.attr		=3D amd_pstate_attr,
>  };
> diff --git a/include/linux/amd-pstate.h b/include/linux/amd-pstate.h
> index 446394f84606..66d939a344b1 100644
> --- a/include/linux/amd-pstate.h
> +++ b/include/linux/amd-pstate.h
> @@ -80,7 +80,6 @@ struct amd_cpudata {
>  	struct amd_aperf_mperf prev;
> =20
>  	u64	freq;
> -	bool	boost_supported;

This leaves amd_pstate_ut_check_freq() in drivers/cpufreq/amd-pstate-ut.c b=
roken. Likely, the whole `if (cpudata->boost_supported) {` hunk should be r=
emoved there too.

Also, in the header file, there's kernel-doc before `struct amd_cpudata`, w=
here boost_supported is mentioned. It should be removed too then.

> =20
>  	/* EPP feature related attributes*/
>  	s16	epp_policy;
>=20


=2D-=20
Oleksandr Natalenko (post-factum)
--nextPart4545156.LvFx2qVVIh
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEZUOOw5ESFLHZZtOKil/iNcg8M0sFAmW/pc0ACgkQil/iNcg8
M0urchAAvKYGEpxMWXdVRLbuUMR52vsR6OmsmlA21fkyGhmCg5Dckqxb1fdaXqQ2
Qz7M1GYLjEzXCxRzQi3IxPjNGp/0wtXycAO1DgvlgHexMydzVYLTsm7cdm29+/UV
N5SynY1bFiH6cvUEdYcg4Q2ZVorx20cNJ/Dfb8DsqzMBkHx+YWpllT6ZBdasX1Wr
5RRppw8VuunYXHugWexxXQMGRWC3IAjAj1EiJyswMZwGmiIqMuTUtv3y8ts+mK9w
7xLQ1lHUdY733C7NvzY0sRYKY1E1INhwX59zZrPUWgjgkGJEBBZIGBWbm6AeAKK0
SSL2pxyCYOYG/PuEfP20YcO5mL8Tb4Tjzd41sDMBADGAWmeBJnOC0hUrW9OGbu7N
KB04tSisT6uDgLTbIhaEPjGjhrpwwl0GqWXnHeEq8JGuqJtZwDCTpDd5waZpAD6O
nzRwZzwXjqR+8kf7vTl3kKRO5BguxnZcH1vS9krPc/2zh3FZeNY1Rau4s6IHTZh6
q62TkVr1iT3X8vG8Hy9OY+yUnLCylBQTPYVY7h7wgYKbEyhOt/YNRm5U000IeoRY
y1zxVPH+8N9O+zU9zpCIb5CqxOu9V5Rr/Dt6helF5j7Ebo5Nt7VUZ9E1mM5/56Uc
m04zzOYmqV2N4Z6haiao9dLRDHFmZS9EmheDARUS2ZXOOhzhkOk=
=3u7X
-----END PGP SIGNATURE-----

--nextPart4545156.LvFx2qVVIh--