Received-SPF: pass (google.com: domain of linux-kernel+bounces-51744-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Sun, 4 Feb 2024 15:08:43 +0000
From: Jonathan Cameron <jic23@kernel.org>
To: Nikita Mikhailevich <ermyril@gmail.com>
Cc: lars@metafoo.de, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: accel: mxc4005: new ACPI ID for the MXC6655
 accelerometer
Message-ID: <20240204150843.79f76071@jic23-huawei>
In-Reply-To: <20240201151848.1666245-1-ermyril@gmail.com>
References: <20240201151848.1666245-1-ermyril@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu,  1 Feb 2024 16:18:48 +0100
Nikita Mikhailevich <ermyril@gmail.com> wrote:

> New ID was introduced by Chuwi on Minibook X 2023.

So interestingly MDA is a valid PNP ID. But an old one from 1997 for
Media4 Inc. 

Let's hope they never used that device number in a way that will bite us.

Applied to the togreg branch of iio.git and pushed out as testing for 0-day
to play with it.

Note that if anyone has a path to Chuwi to educate them on how to do
ACPI ids correctly then feel free to pass it on!

The MXC ones are also invalid btw - in that case there is no such PNP
ID unless it's been very recently granted which seems unlikely.

Jonathan

> 
> Signed-off-by: Nikita Mikhailevich <ermyril@gmail.com>
> ---
>  drivers/iio/accel/mxc4005.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iio/accel/mxc4005.c b/drivers/iio/accel/mxc4005.c
> index 82e8d0b39..09764ef8b 100644
> --- a/drivers/iio/accel/mxc4005.c
> +++ b/drivers/iio/accel/mxc4005.c
> @@ -472,6 +472,7 @@ static int mxc4005_probe(struct i2c_client *client)
>  static const struct acpi_device_id mxc4005_acpi_match[] = {
>  	{"MXC4005",	0},
>  	{"MXC6655",	0},
> +	{"MDA6655",	0},
>  	{ },
>  };
>  MODULE_DEVICE_TABLE(acpi, mxc4005_acpi_match);
> --
> 2.43.0
>