Received-SPF: pass (google.com: domain of linux-kernel+bounces-51802-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: andy.shevchenko@gmail.com
Date: Sun, 4 Feb 2024 18:52:52 +0200
To: Nikita Shubin <nikita.shubin@maquefel.me>
Cc: Conor Dooley <conor.dooley@microchip.com>,
	Ulf Hansson <ulf.hansson@linaro.org>, Joel Stanley <joel@jms.id.au>,
	Linus Walleij <linus.walleij@linaro.org>,
	Wei Xu <xuwei5@hisilicon.com>, Huisong Li <lihuisong@huawei.com>,
	Walker Chen <walker.chen@starfivetech.com>,
	Jonathan =?iso-8859-1?Q?Neusch=E4fer?= <j.neuschaefer@gmx.net>,
	Arnd Bergmann <arnd@arndb.de>,
	Alexander Sverdlin <alexander.sverdlin@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 08/39] soc: Add SoC driver for Cirrus ep93xx
Message-ID: <Zb_A5H5kkxw1oiQv@surfacebook.localdomain>
References: <20240118-ep93xx-v7-0-d953846ae771@maquefel.me>
 <20240118-ep93xx-v7-8-d953846ae771@maquefel.me>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240118-ep93xx-v7-8-d953846ae771@maquefel.me>

Thu, Jan 18, 2024 at 11:20:51AM +0300, Nikita Shubin kirjoitti:
> Add an SoC driver for the ep93xx. Currently there is only one thing
> not fitting into any other framework, and that is the swlock setting.
> 
> Used for clock settings, pinctrl and restart.

..

> +static struct auxiliary_device *ep93xx_adev_alloc(struct device *parent, const char *name,
> +						  struct ep93xx_map_info *info)
> +{
> +	struct ep93xx_regmap_adev *rdev;
> +	struct auxiliary_device *adev;
> +	int ret;
> +
> +	rdev = kzalloc(sizeof(*rdev), GFP_KERNEL);
> +	if (!rdev)
> +		return ERR_PTR(-ENOMEM);

Use __free() ?
(You already included cleanup.h for other cases, why not using it here?)

> +	rdev->map = info->map;
> +	rdev->base = info->base;
> +	rdev->lock = &info->lock;
> +	rdev->write = ep93xx_regmap_write;
> +	rdev->update_bits = ep93xx_regmap_update_bits;
> +
> +	adev = &rdev->adev;
> +	adev->name = name;
> +	adev->dev.parent = parent;
> +	adev->dev.release = ep93xx_adev_release;
> +
> +	ret = auxiliary_device_init(adev);
> +	if (ret) {
> +		kfree(adev);
> +		return ERR_PTR(ret);
> +	}
> +
> +	return adev;
> +}

..

> +	model = (enum ep93xx_soc_model)(uintptr_t)of_device_get_match_data(dev);

I believe Rob wants to get rid of of_device.h or at least of this call (see his
patches to convert this API to use device_get_match_data() instead).

-- 
With Best Regards,
Andy Shevchenko