Received-SPF: pass (google.com: domain of linux-kernel+bounces-51804-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: andy.shevchenko@gmail.com
Date: Sun, 4 Feb 2024 18:56:54 +0200
To: Nikita Shubin <nikita.shubin@maquefel.me>
Cc: Linus Walleij <linus.walleij@linaro.org>, linux-kernel@vger.kernel.org,
	linux-gpio@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v7 05/39] pinctrl: add a Cirrus ep93xx SoC pin controller
Message-ID: <Zb_B1mpHrfAhL6Zl@surfacebook.localdomain>
References: <20240118-ep93xx-v7-0-d953846ae771@maquefel.me>
 <20240118-ep93xx-v7-5-d953846ae771@maquefel.me>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240118-ep93xx-v7-5-d953846ae771@maquefel.me>

Thu, Jan 18, 2024 at 11:20:48AM +0300, Nikita Shubin kirjoitti:
> Add a pin control (only multiplexing) driver for ep93xx SoC so
> we can fully convert ep93xx to device tree.
> 
> This driver is capable of muxing ep9301/ep9302/ep9307/ep9312/ep9315
> variants, this is chosen based on "compatible" in device tree.

..

> +static const unsigned int ide_9312_pins[] = {
> +	78, 301, 302, 321, 322, 342,
> +	257, 295, 296, 334,
> +	4, 24, 25, 45, 46, 66, 314, 333,
> +};

In other cases you locate 8 per each line, why this one is unaligned with that
pattern?

-- 
With Best Regards,
Andy Shevchenko