Received-SPF: pass (google.com: domain of linux-kernel+bounces-51862-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240204162106.1179621-1-andy.shevchenko@gmail.com> <20240204182417.jnw4iuqgghxynq3v@skbuf>
In-Reply-To: <20240204182417.jnw4iuqgghxynq3v@skbuf>
From: Andy Shevchenko <andy.shevchenko@gmail.com>
Date: Sun, 4 Feb 2024 21:55:43 +0200
Message-ID: <CAHp75VeKyvec=xpfmyNrpqg5szFjD6FfbQNUFXN2Y4__j1B_UQ@mail.gmail.com>
Subject: Re: [PATCH v1 1/1] spi: fsl-dspi: Unify error messaging in dspi_request_dma()
To: Vladimir Oltean <olteanv@gmail.com>
Cc: Mark Brown <broonie@kernel.org>, linux-spi@vger.kernel.org, 
	linux-kernel@vger.kernel.org, Minjie Du <duminjie@vivo.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, Feb 4, 2024 at 8:24=E2=80=AFPM Vladimir Oltean <olteanv@gmail.com> =
wrote:
> On Sun, Feb 04, 2024 at 06:21:06PM +0200, andy.shevchenko@gmail.com wrote=
:
> > Use `ret =3D dev_err_probe(...);` pattern for all messages in dspi_requ=
est_dma()
> > for the sake of uniforming them. While at it, fix indentation issue rep=
orted
> > by Vladimir Oltean.
>
> When did I do that? This is v1.

In the original submission (v2 of it to be precise) by Minjie.

..

> >       ret =3D dmaengine_slave_config(dma->chan_rx, &cfg);
> >       if (ret) {
> > -             dev_err(dev, "can't configure rx dma channel\n");
> > -             ret =3D -EINVAL;
> > +             ret =3D dev_err_probe(dev, -EINVAL, "can't configure rx d=
ma channel\n");
>
> Passing -EINVAL to dev_err_probe() here doesn't work. It overwrites the "=
ret"
> from dmaengine_slave_config().

True, but this patch doesn't change the behaviour.

..

> >       if (ret) {
> > -             dev_err(dev, "can't configure tx dma channel\n");
> > -             ret =3D -EINVAL;
> > +             ret =3D dev_err_probe(dev, -EINVAL, "can't configure tx d=
ma channel\n");
>
> Same here.

Same answer here.

> >               goto err_slave_config;
> >       }

--=20
With Best Regards,
Andy Shevchenko