Received-SPF: pass (google.com: domain of linux-kernel+bounces-51865-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240204162106.1179621-1-andy.shevchenko@gmail.com>
 <20240204182417.jnw4iuqgghxynq3v@skbuf> <20240204183130.r4rdggcqx6czuzoc@skbuf>
In-Reply-To: <20240204183130.r4rdggcqx6czuzoc@skbuf>
From: Andy Shevchenko <andy.shevchenko@gmail.com>
Date: Sun, 4 Feb 2024 21:56:34 +0200
Message-ID: <CAHp75VcLtzJ7heNxfEGxNJbkjbnHSLJTSHCcMnEQfLUTnbwkRw@mail.gmail.com>
Subject: Re: [PATCH v1 1/1] spi: fsl-dspi: Unify error messaging in dspi_request_dma()
To: Vladimir Oltean <olteanv@gmail.com>
Cc: Mark Brown <broonie@kernel.org>, linux-spi@vger.kernel.org, 
	linux-kernel@vger.kernel.org, Minjie Du <duminjie@vivo.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, Feb 4, 2024 at 8:31=E2=80=AFPM Vladimir Oltean <olteanv@gmail.com> =
wrote:
> On Sun, Feb 04, 2024 at 08:24:17PM +0200, Vladimir Oltean wrote:

..

> > Passing -EINVAL to dev_err_probe() here doesn't work. It overwrites the=
 "ret"
> > from dmaengine_slave_config().

> Ah, the original code also ignores the dmaengine_slave_config() return
> code and replaces it with -EINVAL? I wonder why that is... It doesn't
> appear to be a widespread pattern. Pretty arbitrary. Could you please
> make 2 patches, one which preserves the original return code and another
> which uses dev_err_probe()?

Sure.

--=20
With Best Regards,
Andy Shevchenko