Received-SPF: pass (google.com: domain of linux-kernel+bounces-51878-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <6a696340-b57c-4fa5-bb2e-b3a0257453bc@linux.intel.com>
Date: Sun, 4 Feb 2024 12:27:59 -0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1] efi/libstub: Add Confidential Computing (CC)
 measurement support
Content-Language: en-US
To: James Bottomley <James.Bottomley@HansenPartnership.com>,
 Ard Biesheuvel <ardb@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org,
 "Yao, Jiewen" <jiewen.yao@intel.com>, "Lu, Ken" <ken.lu@intel.com>
References: <20240203075736.3982371-1-sathyanarayanan.kuppuswamy@linux.intel.com>
 <82a84e769875c70279348179c1b2b63a16770c8e.camel@HansenPartnership.com>
From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
In-Reply-To: <82a84e769875c70279348179c1b2b63a16770c8e.camel@HansenPartnership.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

+Jiewen & Ken (RTMR firmware owner)

On 2/3/24 10:46 PM, James Bottomley wrote:
> On Sat, 2024-02-03 at 07:57 +0000, Kuppuswamy Sathyanarayanan wrote:
>> If the virtual firmware implements TPM support, TCG2 protocol will be
>> used for kernel measurements and event logging support. But in CC
>> environment, not all platforms support or enable the TPM feature.
>> UEFI specification [1] exposes protocol and interfaces used for
>> kernel measurements in CC platforms without TPM support.
>>
>> Currently, the efi-stub only supports the kernel related measurements
>> for the platform that supports TCG2 protocol. So, extend it add
>> CC measurement protocol (EFI_CC_MEASUREMENT_PROTOCOL) and event
>> logging support. Event logging format in the CC environment is the
>> same as TCG2.
> Why do we have to do this anymore?  Given that you're already pushing
> patches that map RTMRs to TPM PCRs:
>
> https://lore.kernel.org/lkml/20240128212532.2754325-4-sameo@rivosinc.com/

IMHO, I am not sure whether we need this mapping support . I have already
mentioned the same comment in [1]. If we support extension and logging
via configFS ABI, why again support PCR mapping?

https://lore.kernel.org/lkml/2bd7c80b-9cd8-4450-a410-c3739d224167@linux.intel.com/ [1]

>
> Can't you just add a stub TCG2 driver to EFI that exposes only the
> ability to log and measure using this mapping?  That way all our
> existing code will "just work" without the need to understand anything
> about confidential computing or add new code to do the measurement?

I am not familiar with the EFI implementation, but I think a new protocol
is added to handle future CC extensions (which could deviate from
TCG2) and to support platforms that does not support or enable TPM
feature. So modifying the TCG2 driver in EFI may not work for the
above-mentioned cases. I think the EFI driver part of this support
is already merged.

Jiewen/Ken may have more comments about this proposal.

>
> James
>
-- 
Sathyanarayanan Kuppuswamy
Linux Kernel Developer