Received-SPF: pass (google.com: domain of linux-kernel+bounces-51915-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Sun, 4 Feb 2024 22:29:51 +0100
From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To: "Ricardo B. Marliere" <ricardo@marliere.net>
Cc: Thorsten Scherer <t.scherer@eckelmann.de>, 
	Pengutronix Kernel Team <kernel@pengutronix.de>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, 
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] siox: make siox_bus_type const
Message-ID: <oixce2fflwe6rodxsv625ogbymqlblw7qvvbxmtp7tpgarqpju@ufnqi7j364md>
References: <20240204-bus_cleanup-siox-v1-1-2d12583d3a6c@marliere.net>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="4q3fuj3ylhholgv6"
Content-Disposition: inline
In-Reply-To: <20240204-bus_cleanup-siox-v1-1-2d12583d3a6c@marliere.net>


--4q3fuj3ylhholgv6
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello Ricardo,

On Sun, Feb 04, 2024 at 05:36:03PM -0300, Ricardo B. Marliere wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the siox_bus_type variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
>=20
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
> ---
>  drivers/siox/siox-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/siox/siox-core.c b/drivers/siox/siox-core.c
> index 561408583b2b..a1eda7bd76ed 100644
> --- a/drivers/siox/siox-core.c
> +++ b/drivers/siox/siox-core.c
> @@ -543,7 +543,7 @@ static void siox_shutdown(struct device *dev)
>  		sdriver->shutdown(sdevice);
>  }
> =20
> -static struct bus_type siox_bus_type =3D {
> +static const struct bus_type siox_bus_type =3D {
>  	.name =3D "siox",
>  	.match =3D siox_match,
>  	.probe =3D siox_probe,

while I like this change, I wonder about the "Now" in the commit log.
Doing the homework, this is about commit d492cc2573a0 ("driver core:
device.h: make struct bus_type a const *") which is in 6.4-rc1. Would
you please care to mention that commit as the one that makes this siox
change possible?

Thanks
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--4q3fuj3ylhholgv6
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmXAAc4ACgkQj4D7WH0S
/k4s9Af/QB+rLnHB02hNPhuBJli4ziKQC5YsDnKvHelaGTNXS/OT1Z6uP2deeQWT
8N6D1yWZvoLNjLzEdRmb+/aeNhB57stbASDom/+w/i5CV8pQNua8zRVOBixBFPiH
be5KQtdhtPbd7ga29mVjz9H2C2snppLKwHp75Gep3Ulb8xvtBGJE9lmQXRVc5d4f
T5ZkrfhPFa11tDlmKvMAQmPRUymTcCmoGg5gWRkYIa46sqHn2zCc+y34I7KO6M8S
VdGUQ9mjChb/e6IwV93op267Bv4dueFHas0sHh+NP9CUgnYb0P4EmyqJu9n+dhf/
t/qP2QokB3r7B5ueU5g5acYPa5ZLMg==
=YAp6
-----END PGP SIGNATURE-----

--4q3fuj3ylhholgv6--