Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp2072738rdb; Sun, 4 Feb 2024 13:57:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IGDx5sdsI+M9T9z0rQqrWRYoAFPacVmkSvwyyu4hp9HRc96aaj7WCeynQ6rT5PI6UtYWdJ7 X-Received: by 2002:a17:906:cecc:b0:a36:5b1c:fb4b with SMTP id si12-20020a170906cecc00b00a365b1cfb4bmr8165288ejb.13.1707083878489; Sun, 04 Feb 2024 13:57:58 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707083878; cv=pass; d=google.com; s=arc-20160816; b=oxR3QmXyy+82oXzZvHwtcd0MuCqfmTSJP//oabo59/k0JeTbUdW/1+IO3+u/xgAJC3 OKr6R46rCo44guVraPsCENkJGC+cDtQjobD0xM8/R3UvAKcpKXjZA/GVwJ/KTr4Pzle3 pB/T+Zl0/uie1SYjOZOAtj3MRgmisTyd6H0mejZEefb7QQQNj+YFMFs285uaCS1plu95 9boiOurKeIM7zzO1ssfwfL6UcFa7rRiRghao7rK38QUzVk7zlSmBbNuQxqq/fIwHibM6 w/JgW0nhVDAyQpmvVjo3eJmkzC/SGk/A9PNK8H7Y7RtlRQI3pCyJjh2z95B9bKDXPhid Y5tQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=g5AR9vZ9MNs+fUVCcwKiCmTaAON91kqW+QM/Uqs1wyI=; fh=ZAdyIUa/lzxLl9foH1W7imTzo+71OkrBQ/J9/bw2dDw=; b=IbcN2VxTH5MJhLhTO7NjVkCjFLN3YyGKSfbujOjuP/NaY/XDXVLBA2J5LArioiCUFl bs2ayXtOPytQMkxmZgXEw+nRpqW6ToSaGkHdiu0bQqJfptWKBVkH6ntyiA25eyoWqo91 qjaHwytrjeqaG8DoFhxaCZRhoyDdeJB8cmf+trR/1MLem8eQsg1xVDpCLQ2kQb13rVAo nMf6a7p9y3OXhW0VbvPOU3FVTfN72Y6ViIHdJDxlhLj+8NbUrYpYV1S70olJ59KwFLtU t6XBLZEC31cfUvnn88lOenCxA8o63ZzlTLxFZbEp0OVB4ynjSUa5pVDt7g9no/vAdaQx 5PUw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=nhEirLtN; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-51921-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-51921-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com X-Forwarded-Encrypted: i=1; AJvYcCUEkIv4VUn3lIrkgQ92brPL/+yKutUrYz1Vtp6ftRymSUfj9yJ1dFLO79ozyX++KkNHe1CKHJu7f0f4x4MUDcoVs70kAokCeWbbluTLTg== Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id kb12-20020a1709070f8c00b00a37261b23f1si2633798ejc.773.2024.02.04.13.57.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Feb 2024 13:57:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-51921-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=nhEirLtN; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-51921-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-51921-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 3D5BE1F22BED for ; Sun, 4 Feb 2024 21:57:58 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5376D2C698; Sun, 4 Feb 2024 21:57:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nhEirLtN" Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3ECF33990; Sun, 4 Feb 2024 21:57:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707083867; cv=none; b=G9GCx+oIs20Ngx26b7LA5WbGXFLevVsOD1+OiiikOb769WvzP+HBcQ9eBsPKsOWC5ZlIOj4Uo0V71OXkg5TtbpgnU+hm84RQutPJ/eekX0IcHq0/bYBCBXS8LAFZHPHi1moEusS5NHIAqnbImZk1XQYXWcpUwplicosd1rWZ4jQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707083867; c=relaxed/simple; bh=UZa7O+Vt6YTPtFIw0/mltBs3mvjXdlM94ZR4FrqYCOc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OPIoO14PupIr8ixYUG2GESUtS4pBkVQYiG0TOpXFoiqaPq4rKziw5v1tmjECp8H7emBkYWyEocsCrbOaJWgW0XVBO8F15DWXgT18z2QX6v6cUVnjFdv7J4IKaj/dganRzwE5/cydjZ5Wi9dt6qScN3+38tMzVcRHRLfYqPqvH0A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nhEirLtN; arc=none smtp.client-ip=209.85.167.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-5101cd91017so4850488e87.2; Sun, 04 Feb 2024 13:57:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707083864; x=1707688664; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=g5AR9vZ9MNs+fUVCcwKiCmTaAON91kqW+QM/Uqs1wyI=; b=nhEirLtNbEFRMnDXHnHsByj06wfcztVesvF9MIvcfl58Vs5AGwnwz4aw/OcY/wb/oa HqUhkhpQ4othyx4d80o+gU9BrKkDESYsFTMqduX6GMRBwyZnKElYrCr6fLND/yoKdt8I RxeOdAm8Dhyx/48PPavQT5tZo5BC8QtunIUiDaxHtALI8M+nu84i46YEplZD0SPBI//n 41BRoAcrcvxuilc43oMbQXxOdEGgO732EXC75klEb3VcGJcaSAUFk0xVNZ3YyGNQ6iI9 xostAgGSJSGGFLyUMDo1PqY2r/LJ7CLXR/usoUH5rai0vqRMv9h0eotnr+QgkDGYqIHj Ak4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707083864; x=1707688664; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=g5AR9vZ9MNs+fUVCcwKiCmTaAON91kqW+QM/Uqs1wyI=; b=V2UCJzPFJDJb9podwBaF3v4mOiXEq31d4G5oyqUTB5aIMlo5SjXO9uEMi8rp9OZZuT dK+4bUFdbiugmikr8tjN4QY0CVsp7mR7Yhn89fuxJHSdn21rp7PNL4J1DExiz7I2tQqT GFn61Pdc11hB/lgLseoBwQlTdY/yt4nBsymySOjQaYPniZ5ChgHrkh5RDXB/cLcsu04P e+/yRoHZZoCkkV3zOpQMbCHiQqeGIw2nu174bZIRfl2I8TfYVBkpIsiKjDiXP0iSfihG 7LUHxStvDTgkPJIK0gNongzFgk9nTRDl3Bc/U3LLGEzMUwKb36TriMYM2AoUr1b4nJyx 8NLA== X-Gm-Message-State: AOJu0YzogAcrEcZuIvqgP85vgHyyG4Zv9d+iwiC/MYKjkKM5BwIXCJlJ KKxiEaZLZGuu4ao5oWDl5jyBg4eJWrSwTGu5CRW1eU9oWtMGanKV X-Received: by 2002:a05:6512:3494:b0:511:530b:6026 with SMTP id v20-20020a056512349400b00511530b6026mr21364lfr.27.1707083863667; Sun, 04 Feb 2024 13:57:43 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCXBRAtN9GSeiBDQckUnGphVGWvCn2l9Y9cKU+i4cnBbRcfs8HCncIbZSWOmYnImQ7pSB29f2oA48BH8GVntfdsyCRYR8SEJ8GlQIkv5pLqST3yKGe/qK/76ABvwi5Gq2W0I47N77fE5uWPpfown4t1uWOFTUV+GjXbyzX4W8/9TFYiBdbLUDnpUUWsfMTbQZc8reC4eqamuJ9YdMcFS81CxFHJkX/ABnNWaXFPuLzZTlmfBmgUQFDhz9dt7HLElAc7Pl9CWUO/MOWS+SlNdN1IouxfBvv8swQcKJ0ltOIzfeE2I5zNt2PXjLX+nRn6WKFnnMCLtDG6x45VVMcCgEoxpFdiFplUasQhf/3FErMdYWsbVQJ/fZP+xocijIF2TRJk8k5dDqZGV5ZCHKU/H2lY9tm7sJV/fdpkijmHIMwnmpOnJ8Gae2JdlLrVZtVdg1H5SpCQUB6NSGi6srFR0e8yDWlv6+Ayb6oUXAi741i8byTtMXTynhjnpBRB7t+rs3hi6qV8tng== Received: from mobilestation ([95.79.203.166]) by smtp.gmail.com with ESMTPSA id w9-20020a19c509000000b0051134d5e187sm973863lfe.249.2024.02.04.13.57.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Feb 2024 13:57:43 -0800 (PST) Date: Mon, 5 Feb 2024 00:57:41 +0300 From: Serge Semin To: Furong Xu <0x1207@gmail.com> Cc: "David S. Miller" , Alexandre Torgue , Jose Abreu , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Joao Pinto , Simon Horman , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, xfr@outlook.com, rock.xu@nio.com Subject: Re: [PATCH net] net: stmmac: xgmac: fix a typo of register name in DPP safety handling Message-ID: References: <20240203053133.1129236-1-0x1207@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240203053133.1129236-1-0x1207@gmail.com> On Sat, Feb 03, 2024 at 01:31:33PM +0800, Furong Xu wrote: > DDPP is copied from Synopsys Data book: > > DDPP: Disable Data path Parity Protection. > When it is 0x0, Data path Parity Protection is enabled. > When it is 0x1, Data path Parity Protection is disabled. > > The macro name should be XGMAC_DPP_DISABLE. Thanks! Reviewed-by: Serge Semin -Serge(y) > > Fixes: 46eba193d04f ("net: stmmac: xgmac: fix handling of DPP safety error for DMA channels") > Signed-off-by: Furong Xu <0x1207@gmail.com> > --- > drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h | 2 +- > drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h > index 5c67a3f89f08..6a2c7d22df1e 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h > +++ b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h > @@ -304,7 +304,7 @@ > #define XGMAC_TXCEIE BIT(0) > #define XGMAC_MTL_ECC_INT_STATUS 0x000010cc > #define XGMAC_MTL_DPP_CONTROL 0x000010e0 > -#define XGMAC_DDPP_DISABLE BIT(0) > +#define XGMAC_DPP_DISABLE BIT(0) > #define XGMAC_MTL_TXQ_OPMODE(x) (0x00001100 + (0x80 * (x))) > #define XGMAC_TQS GENMASK(25, 16) > #define XGMAC_TQS_SHIFT 16 > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c > index 04d7c4dc2e35..323c57f03c93 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c > @@ -928,7 +928,7 @@ dwxgmac3_safety_feat_config(void __iomem *ioaddr, unsigned int asp, > /* 5. Enable Data Path Parity Protection */ > value = readl(ioaddr + XGMAC_MTL_DPP_CONTROL); > /* already enabled by default, explicit enable it again */ > - value &= ~XGMAC_DDPP_DISABLE; > + value &= ~XGMAC_DPP_DISABLE; > writel(value, ioaddr + XGMAC_MTL_DPP_CONTROL); > > return 0; > -- > 2.34.1 >