Received-SPF: pass (google.com: domain of linux-kernel+bounces-51846-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <20240204-bus_cleanup-gpio-v1-1-82d91b4ee1de@marliere.net>
In-Reply-To: <20240204-bus_cleanup-gpio-v1-1-82d91b4ee1de@marliere.net>
From: Bartosz Golaszewski <brgl@bgdev.pl>
Date: Sun, 4 Feb 2024 19:34:43 +0100
Message-ID: <CAMRc=MdSApjK2b66LxLE9XZufvT-+SThuqjdr+yG-hsKEb4sVw@mail.gmail.com>
Subject: Re: [PATCH] gpio: gpiolib: make gpio_bus_type const
To: "Ricardo B. Marliere" <ricardo@marliere.net>
Cc: Linus Walleij <linus.walleij@linaro.org>, linux-gpio@vger.kernel.org, 
	linux-kernel@vger.kernel.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, Feb 4, 2024 at 5:29=E2=80=AFPM Ricardo B. Marliere <ricardo@marlier=
e.net> wrote:
>
> Now that the driver core can properly handle constant struct bus_type,
> move the gpio_bus_type variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
> ---
>  drivers/gpio/gpiolib.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index d50a786f8176..24d046268a01 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -63,7 +63,7 @@ static int gpio_bus_match(struct device *dev, struct de=
vice_driver *drv)
>         return 1;
>  }
>
> -static struct bus_type gpio_bus_type =3D {
> +static const struct bus_type gpio_bus_type =3D {
>         .name =3D "gpio",
>         .match =3D gpio_bus_match,
>  };
>
> ---
> base-commit: 3eac8bbed22e940ac1645a884f221bef408f675c
> change-id: 20240204-bus_cleanup-gpio-57eea8d32a5a
>
> Best regards,
> --
> Ricardo B. Marliere <ricardo@marliere.net>
>

Ha! Does the same work now for struct device_type?

Because I just sent this:
https://lore.kernel.org/linux-gpio/20240201162758.50733-1-brgl@bgdev.pl/

And maybe I should make it const right away.

Bart