Received-SPF: pass (google.com: domain of linux-kernel+bounces-51988-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: "S.J. Wang" <shengjiu.wang@nxp.com>
To: Shawn Guo <shawn.gsc@gmail.com>
CC: "robh+dt@kernel.org" <robh+dt@kernel.org>,
	"krzysztof.kozlowski+dt@linaro.org" <krzysztof.kozlowski+dt@linaro.org>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>, "shawnguo@kernel.org"
	<shawnguo@kernel.org>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>, "festevam@gmail.com"
	<festevam@gmail.com>, dl-linux-imx <linux-imx@nxp.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] arm64: dts: imx8mm-evk: Add PDM micphone sound card
 support
Thread-Topic: [PATCH 1/2] arm64: dts: imx8mm-evk: Add PDM micphone sound card
 support
Thread-Index: AQHaV9oF61EbjuvISEaxhtAF2fceUw==
Date: Mon, 5 Feb 2024 02:21:26 +0000
Message-ID:
 <PA4PR04MB9248F03E085EDB1B1A5F414EE3472@PA4PR04MB9248.eurprd04.prod.outlook.com>
References: <1703136188-7222-1-git-send-email-shengjiu.wang@nxp.com>
 <20240204235134.GA804317@dragon>
In-Reply-To: <20240204235134.GA804317@dragon>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?YRWc9W7v3vjrGnWTLvbvFaMfJbDyIo9Sr5El6341kVdZFWPa7lqlx1/kveZI?=
 =?us-ascii?Q?4B8p69Pm+So2RHQScNZuDZ8gFRlglPg2iosJfscsshyixTce8DMkqQmA6+QC?=
 =?us-ascii?Q?0FkXb/HTlkoJnasDnD71YW7VBsf6NYJtEN2aP9AhAsidLOevhV25l6xCKI8q?=
 =?us-ascii?Q?c+cXqRvm7Ea0piFK9RZtPfYTuXnWMaNesVvFfUbxT+qsJJhrdmR23JzDcttY?=
 =?us-ascii?Q?uvOLQbMwBsQsiMCbvGHow+py9dG5GeHjVpRrKpma+UtgasUujDmsLZ/7iNtW?=
 =?us-ascii?Q?5Jba8bxUIPK/7Al4lnocanfUo49rNzDBMOQ8Pu75QBqVMdZyn0yz2dgZ3eqD?=
 =?us-ascii?Q?VEjEh5l6VuLobCn+FPXYHaRi2nDhoHZdpKeMrpjSzdYxDKzvV3pAYDKgdW0N?=
 =?us-ascii?Q?9Yiu6naMyxuVxCGQ29ePc4JYt6FLEzaOcptbGUpTpouYUUiBk8wx+IEtfo0o?=
 =?us-ascii?Q?xwk+JIZLmBvObuiSfdy/6x6OGk0hL8PMT67wyTeGejrLW6u6yjyskr8X4tcj?=
 =?us-ascii?Q?L1RDyydxHNSIhlDRky8tPRmLkYKCItrmbcHDfv2v3c2Aq2z3z1IVluKqHaa0?=
 =?us-ascii?Q?NethrayriDD7z7+Rb2TCwM6hA1ec1bbEQVzXdZSZM9ur7pEz7ZLmGo3YdcdQ?=
 =?us-ascii?Q?vVcHYeaEDUOeS48YCrbetYApRoLoR7Y32zujgTItpD5xVCEB2KF53SV6jiRg?=
 =?us-ascii?Q?hK+YMsXRagWN2BYhp9iVXJ9xVv7nMSfIQdgbltwPDyDxDTl9CGQlLw2ESnYy?=
 =?us-ascii?Q?9YaRu1zGF9CRubIv+lbpYmMxPDt8ek5AhDPBZ3uzqaVN8caMHrY96/O6iSRU?=
 =?us-ascii?Q?YyewuRVAFv4KazZJQSEIEZt74MxsbedLp/8LLlT5K8Skp9OAuuCKLBoqpcp4?=
 =?us-ascii?Q?Bx5Cv5gnsuKxTCUDpmalu7HDmWEqtiLrD++vfhLrmkBhNVoeoAqgO9LInMKK?=
 =?us-ascii?Q?4AxQHMSQzMQCvn6qweKWLslaZsXtIJUYX+5iMB5z5HK1jaDe0DX1Wvj0/LpH?=
 =?us-ascii?Q?W0Fkl9L1pp53UhO8k+hijbi3JJKoechcwWelOK/uXhpaKOe+2wgpqJz3PsGU?=
 =?us-ascii?Q?tqfSynmndmpuSJPMIS1zPX/7rOGKaXP20FP230wmO0SM9p2eOCtuT3koaoOg?=
 =?us-ascii?Q?vt66i4iJzW6oDJxPL973ep/Ne4Xyurqhaxtgqxcm13h7tt39n84RuGDgYriu?=
 =?us-ascii?Q?n7q7sH4mISpapOxakvVG8M8HCYNFKj2JVUiJ+3EGpPIQtUqt3yXtSHMY5V3i?=
 =?us-ascii?Q?bfK4b47XHrKJ0tXvQbnPI9fC/yM6A2DQvsBdpobXHc7KMe9+Hnashiz/jTee?=
 =?us-ascii?Q?KBMGMzn/kpsSrs30LjLQ0DjgUXLhmdNvFtSmliFhh8wZNntMxDGcqDwTTfD2?=
 =?us-ascii?Q?lE+I+wSwccHTQu0Sj7mwNOV4k+wEWQgqaI7V/xsMgg3y7vOJGhRZ5tAM268g?=
 =?us-ascii?Q?tkM291FOJQ3trGubRdfILSOQbceolawArU/Ogmy02/IMFi8y3QmfUDiVqdKv?=
 =?us-ascii?Q?/pnnTCFEPtQNjR9z7CPndUlsnCsVmu3IclZI6V3UgVpBtLFkRlCcOz87Mejx?=
 =?us-ascii?Q?OIF1OqN4uaFcNPt6fLd6g4lWrMyPQvFdHpAs3TxE?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR04MB9248.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6080f1db-6b88-4f8a-6b96-08dc25f1280b
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Feb 2024 02:21:26.8618
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: tirmy0/5iIBR9cke+aOVPr04U9cqetwYmLBqpK3ykZ6b3irQ3ZAHmTmjitOFMeQYSSlb3bA6crF6rv9Qrw0GRA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DUZPR04MB9947

> > Add PDM micphone sound card support, configure the pinmux.
> >
> > This sound card supports recording sound from PDM micphone and
> convert
> > the PDM format data to PCM data.
> >
> > Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> > ---
> >  arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 34
> > +++++++++++++++++++
> >  1 file changed, 34 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> > b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> > index b53104ed8919..9679786dac51 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> > @@ -151,6 +151,18 @@ simple-audio-card,codec {
> >                       clocks =3D <&clk IMX8MM_CLK_SAI3_ROOT>;
> >               };
> >       };
> > +
> > +     sound-micfil {
> > +             compatible =3D "fsl,imx-audio-card";
> > +             model =3D "micfil-audio";
>=20
> Have a newline between properties and child node.
>=20
> > +             pri-dai-link {
> > +                     link-name =3D "micfil hifi";
> > +                     format =3D "i2s";
>=20
> Ditto
>=20
Ok,  will update in v2.

Best regards
Wang shengjiu

> Shawn
>=20
> > +                     cpu {
> > +                             sound-dai =3D <&micfil>;
> > +                     };
> > +             };
> > +     };
> >  };
> >
> >  &A53_0 {
> > @@ -434,6 +446,16 @@ &lcdif {
> >       status =3D "okay";
> >  };
> >
> > +&micfil {
> > +     #sound-dai-cells =3D <0>;
> > +     pinctrl-names =3D "default";
> > +     pinctrl-0 =3D <&pinctrl_pdm>;
> > +     assigned-clocks =3D <&clk IMX8MM_CLK_PDM>;
> > +     assigned-clock-parents =3D <&clk IMX8MM_AUDIO_PLL1_OUT>;
> > +     assigned-clock-rates =3D <196608000>;
> > +     status =3D "okay";
> > +};
> > +
> >  &mipi_csi {
> >       status =3D "okay";
> >
> > @@ -636,6 +658,18 @@ MX8MM_IOMUXC_GPIO1_IO05_GPIO1_IO5
> 0x41
> >               >;
> >       };
> >
> > +     pinctrl_pdm: pdmgrp {
> > +             fsl,pins =3D <
> > +                     MX8MM_IOMUXC_SAI5_MCLK_SAI5_MCLK        0xd6
> > +                     MX8MM_IOMUXC_SAI5_RXC_PDM_CLK           0xd6
> > +                     MX8MM_IOMUXC_SAI5_RXFS_SAI5_RX_SYNC     0xd6
> > +                     MX8MM_IOMUXC_SAI5_RXD0_PDM_DATA0        0xd6
> > +                     MX8MM_IOMUXC_SAI5_RXD1_PDM_DATA1        0xd6
> > +                     MX8MM_IOMUXC_SAI5_RXD2_PDM_DATA2        0xd6
> > +                     MX8MM_IOMUXC_SAI5_RXD3_PDM_DATA3        0xd6
> > +             >;
> > +     };
> > +
> >       pinctrl_pmic: pmicirqgrp {
> >               fsl,pins =3D <
> >                       MX8MM_IOMUXC_GPIO1_IO03_GPIO1_IO3               0=
x141
> > --
> > 2.34.1
> >