Received-SPF: pass (google.com: domain of linux-kernel+bounces-51996-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <909cee7d-0201-4429-b85d-7d2662516e45@linux.alibaba.com>
Date: Mon, 5 Feb 2024 10:50:32 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [RFC PATCH] mm: hugetlb: remove __GFP_THISNODE flag when
 dissolving the old hugetlb
To: Michal Hocko <mhocko@suse.com>
Cc: akpm@linux-foundation.org, muchun.song@linux.dev, osalvador@suse.de,
 david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org
References: <6f26ce22d2fcd523418a085f2c588fe0776d46e7.1706794035.git.baolin.wang@linux.alibaba.com>
 <Zbu4cD1XLFLfKan8@tiehlicka>
 <3f31cd89-f349-4f9e-bc29-35f29f489633@linux.alibaba.com>
 <ZbylJr_bbWCUMjMl@tiehlicka>
 <f1606912-5bcc-46be-b4f4-666149eab7bd@linux.alibaba.com>
 <Zby7-dTtPIy2k5pj@tiehlicka>
From: Baolin Wang <baolin.wang@linux.alibaba.com>
In-Reply-To: <Zby7-dTtPIy2k5pj@tiehlicka>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 2/2/2024 5:55 PM, Michal Hocko wrote:
> On Fri 02-02-24 17:29:02, Baolin Wang wrote:
>> On 2/2/2024 4:17 PM, Michal Hocko wrote:
> [...]
>>>> Agree. So how about below changing?
>>>> (1) disallow fallbacking to other nodes when handing in-use hugetlb, which
>>>> can ensure consistent behavior in handling hugetlb.
>>>
>>> I can see two cases here. alloc_contig_range which is an internal kernel
>>> user and then we have memory offlining. The former shouldn't break the
>>> per-node hugetlb pool reservations, the latter might not have any other
>>> choice (the whole node could get offline and that resembles breaking cpu
>>> affininty if the cpu is gone).
>>
>> IMO, not always true for memory offlining, when handling a free hugetlb, it
>> disallows fallbacking, which is inconsistent.
> 
> It's been some time I've looked into that code so I am not 100% sure how
> the free pool is currently handled. The above is the way I _think_ it
> should work from the usability POV.

Please see alloc_and_dissolve_hugetlb_folio().

>> Not only memory offlining, but also the longterm pinning (in
>> migrate_longterm_unpinnable_pages()) and memory failure (in
>> soft_offline_in_use_page()) can also break the per-node hugetlb pool
>> reservations.
> 
> Bad
> 
>>> Now I can see how a hugetlb page sitting inside a CMA region breaks CMA
>>> users expectations but hugetlb migration already tries hard to allocate
>>> a replacement hugetlb so the system must be under a heavy memory
>>> pressure if that fails, right? Is it possible that the hugetlb
>>> reservation is just overshooted here? Maybe the memory is just terribly
>>> fragmented though?
>>>
>>> Could you be more specific about numbers in your failure case?
>>
>> Sure. Our customer's machine contains serveral numa nodes, and the system
>> reserves a large number of CMA memory occupied 50% of the total memory which
>> is used for the virtual machine, meanwhile it also reserves lots of hugetlb
>> which can occupy 50% of the CMA. So before starting the virtual machine, the
>> hugetlb can use 50% of the CMA, but when starting the virtual machine, the
>> CMA will be used by the virtual machine and the hugetlb should be migrated
>> from CMA.
> 
> Would it make more sense for hugetlb pages to _not_ use CMA in this
> case? I mean would be better off overall if the hugetlb pool was
> preallocated before the CMA is reserved? I do realize this is just
> working around the current limitations but it could be better than
> nothing.

In this case, the CMA area is large and occupies 50% of the total 
memory. The purpose is that, if no virtual machines are launched, then 
CMA memory can be used by hugetlb as much as possible. Once the virtual 
machines need to be launched, it is necessary to allocate CMA memory as 
much as possible, such as migrating hugetlb from CMA memory.

After more thinking, I think we should still drop the __GFP_THISNODE 
flag in alloc_and_dissolve_hugetlb_folio(). Firstly, not only it 
potentially cause CMA allocation to fail, but it might also cause memory 
offline to fail like I said in the commit message. Secondly, there have 
been no user reports complaining about breaking the per-node hugetlb 
pool, although longterm pinning, memory failure, and memory offline can 
potentially break the per-node hugetlb pool.

>> Due to several nodes in the system, one node's memory can be exhausted,
>> which will fail the hugetlb migration with __GFP_THISNODE flag.
> 
> Is the workload NUMA aware? I.e. do you bind virtual machines to
> specific nodes?

Yes, the VM can bind nodes.