Received-SPF: pass (google.com: domain of linux-kernel+bounces-52004-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Wu Bo <bo.wu@vivo.com>
To: Jaegeuk Kim <jaegeuk@kernel.org>,
	Chao Yu <chao@kernel.org>
Cc: linux-f2fs-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org,
	Wu Bo <wubo.oduw@gmail.com>,
	Wu Bo <bo.wu@vivo.com>,
	stable@vger.kernel.org
Subject: [PATCH] Revert "f2fs: stop allocating pinned sections if EAGAIN happens"
Date: Sun,  4 Feb 2024 20:14:15 -0700
Message-Id: <20240205031415.557879-1-bo.wu@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?4Qrd2WrLOGLBvPqKZ7oml2+fSDCK3zuvQzgUaj7pRcHeUOAOCyFuCJq+rkAo?=
 =?us-ascii?Q?t6uaOujlNegjw2FDcoCHlnnLyVLcec7ErbzzO0RDOVB9EZ7lGYqiAbtvQryC?=
 =?us-ascii?Q?Wz88JJ+eLe94XJx8kLbIKld0yxar141ksZ2Sg4jlt6grC/2MTafdRJR5zDAL?=
 =?us-ascii?Q?7I6fWHfY1qwypYZcQTUUM6XQuyGtKtmvJurdK0xkpG9aohHyhhNyu7ARWCA7?=
 =?us-ascii?Q?DWpgJ2HVDxwsE4a8Q56ombeF4pZiTPR5TZz3TL2poGI1KXmkkKJAKq2d9rKj?=
 =?us-ascii?Q?VWJUhCPB1DXdkVUo2eNP4Wkq4BMk7bjS46x3RFtr4WmcEvn+tm3NEDF7F9zL?=
 =?us-ascii?Q?blvsOoTgwphfvmDKzOCNxijF87yNlKytEzkwgdb6OSInOVDNIemsB4OWJJWy?=
 =?us-ascii?Q?C/hzr28qxnXRNvN7RhA5J8pRI1PMQl+hB/yinbp8Pqbw9YhDgmMHxz0CwEz0?=
 =?us-ascii?Q?U3QvNRbeiDWsfLEyKSLKAOF9H6GTx/fuA1UFLAyKIXM/b7X08fWnahqM3V7+?=
 =?us-ascii?Q?03WAAh9ZcVsBL95B1VQg4uPoXxB/L7vbKdfJevaplJkiEbeOhjIU02/bsstw?=
 =?us-ascii?Q?McR7OZBaz3Xt7LsOJvtHsmtBR2OLRMElKxfxxamgKDUmtfHhTiKFxB1HXStI?=
 =?us-ascii?Q?UBS0syW2+aDzS7NG0pfXr5zmg4FctRFIgIQwyiFt2WMFnkOODeJz5cE7jqu6?=
 =?us-ascii?Q?pc0pNHZU+OlnNo8MYnkIRrdKvGGuR4SZJI8eBaK3+mnu0BeUoIwQlRTnvK/C?=
 =?us-ascii?Q?hmLNnvkzDYTews98dxx8ldNdSVx+Vdw8nHX65LgzC6CFWJis06z/W2wYH4yx?=
 =?us-ascii?Q?WzZZPcOxji5xbizaja4Hr2uMVXlmttbMZRXqpYmDBJqmnFYT6jZ51lGclt1D?=
 =?us-ascii?Q?GETXWKMO0M1kt/gihgfWlcEFDqe6VNcTPm38zT8kQMflpY2FbT52qxkC079W?=
 =?us-ascii?Q?1c0QyI4QY4Lot4HDOTsxmtIZZQkauOYC4t3YCvkHrnQLEM3LuX8UWPMoKtus?=
 =?us-ascii?Q?3KBjfeU5S1iWwdVlv/rOAeJin7If0Y9vGfWU+naaZAA8OR4tcaTD6fiYi/Ey?=
 =?us-ascii?Q?rKUTcROPsJ5/PYYCoTGXcv/6vmvXw1eY0QXWr9uBxVrtuVIJgm4EF0lGrJeq?=
 =?us-ascii?Q?BL5dU7n0mfJJSJucsvL5zj7T1qwz9+Y4V6PMswmRe8aBHWVzo0kaliGHMluT?=
 =?us-ascii?Q?CvURLa+0fDNFLTbeK8bzJ4jsdFj52WE922Sun1aL9uAINV2TLQLnkHv7Jmc0?=
 =?us-ascii?Q?CgvoMd/nUkRkmg4wJGcfZWnR+V5j+xJQiBNkQFWzrSSl/8Tl3W1aCVBffSGQ?=
 =?us-ascii?Q?xBzqvEJcq15Nf2HKoTzEpWdim8IFAccl1MDtooeEUzXwJmvFa19Df4aBv6lF?=
 =?us-ascii?Q?Qf1sOgGptNq1IaKYHQTtNWRpzzUDamzKUcz3W9J8hTsXkfnfhd5iF74UwSVg?=
 =?us-ascii?Q?hVy5pr6U4Cfhn7DKA+HLxrwgAtBYaWtHCjg57lTV5nKuMhFbKPReQS4bcKP0?=
 =?us-ascii?Q?chFSbQY9JG4HV2dBgfKhmuPQYroYrV3kkocjv+UWbOkLGbexoSwEsIFIY/KK?=
 =?us-ascii?Q?b8N6jzvRbupomvnrNKjgOmR5lAs39AejLW3d7nB1?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5aa687d8-885e-43e6-2ce6-08dc25f6fc32
X-MS-Exchange-CrossTenant-AuthSource: PSAPR06MB4486.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2024 03:03:10.6119
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DHtb/8Qcbz822mZjZybMOZmHeA9khcG8wSJU/H/Kl2+aMfyzh/vot/NatHYSs2xx/1f4aKWNfE9CtcYo7tcH8Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB4159

This reverts commit 2e42b7f817acd6e8d78226445eb6fe44fe79c12a.

If the GC victim section has a pinned block when fallocate() trigger
FG_GC, the section is not able to be recycled. And this will return
-EAGAIN cause fallocate() failed, even though there are much spare space
as user see. As the GC policy prone to chose the same victim,
fallocate() may not successed at a long period.

This scenario has been found during Android OTA.

Link: https://lore.kernel.org/linux-f2fs-devel/20231030094024.263707-1-bo.wu@vivo.com/t/#u

CC: stable@vger.kernel.org
Signed-off-by: Wu Bo <bo.wu@vivo.com>
---
 fs/f2fs/file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index b58ab1157b7e..19915faccee9 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -1725,7 +1725,7 @@ static int f2fs_expand_inode_data(struct inode *inode, loff_t offset,
 			f2fs_down_write(&sbi->gc_lock);
 			stat_inc_gc_call_count(sbi, FOREGROUND);
 			err = f2fs_gc(sbi, &gc_control);
-			if (err && err != -ENODATA)
+			if (err && err != -ENODATA && err != -EAGAIN)
 				goto out_err;
 		}
 
-- 
2.25.1