Received-SPF: pass (google.com: domain of linux-kernel+bounces-52015-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Sun, 4 Feb 2024 21:28:01 -0600
From: Serge Hallyn <serge@hallyn.com>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Eric Biederman <ebiederm@xmission.com>,
	Kees Cook <keescook@chromium.org>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
	Paul Moore <paul@paul-moore.com>, James Morris <jmorris@namei.org>,
	linux-security-module <linux-security-module@vger.kernel.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 0/3] fs/exec: remove current->in_execve flag
Message-ID: <ZcBVwb/ILOH9Vwa/@serge-l-PF3DENS3>
References: <8fafb8e1-b6be-4d08-945f-b464e3a396c8@I-love.SAKURA.ne.jp>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8fafb8e1-b6be-4d08-945f-b464e3a396c8@I-love.SAKURA.ne.jp>

On Sat, Feb 03, 2024 at 07:52:24PM +0900, Tetsuo Handa wrote:
> This is a follow up series for removing current->in_execve flag.
> 
> https://lkml.kernel.org/r/b5a12ecd-468d-4b50-9f8c-17ae2a2560b4@I-love.SAKURA.ne.jp
> 
> [PATCH v2 1/3] LSM: add security_execve_abort() hook
> [PATCH v2 2/3] tomoyo: replace current->in_execve flag with security_execve_abort() hook
> [PATCH v2 3/3] fs/exec: remove current->in_execve flag
> 
>  fs/exec.c                     |    4 +---
>  include/linux/lsm_hook_defs.h |    1 +
>  include/linux/sched.h         |    3 ---
>  include/linux/security.h      |    5 +++++
>  security/security.c           |   11 +++++++++++
>  security/tomoyo/tomoyo.c      |   22 ++++++----------------
>  6 files changed, 24 insertions(+), 22 deletions(-)
> 
> Changes in v2:
> 
>   Replace security_bprm_aborting_creds(const struct linux_binprm *bprm) with
>   security_execve_abort(void), suggested by Eric W. Biederman.

It seems good to me, apart from the mistaken bprm arg mention in
tomoyo_execve_abort() comment in patch 2 which kernel-test-robot found.

Acked-by: Serge E. Hallyn <serge@hallyn.com>

thanks,
-serge