Received-SPF: pass (google.com: domain of linux-kernel+bounces-52024-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From: Hao Ge <gehao618@163.com>
Precedence: bulk
Mime-Version: 1.0 (1.0)
Subject: Re: [PATCH] fs/inode: Make too_many_isolated return bool
Date: Mon, 5 Feb 2024 12:23:32 +0800
Message-Id: <02CFAD55-0733-4765-9160-153409AE050F@163.com>
References: <20240205022825.99061-1-gehao@kylinos.cn>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
 linux-kernel@vger.kernel.org
In-Reply-To: <20240205022825.99061-1-gehao@kylinos.cn>
To: Hao Ge <gehao@kylinos.cn>

Sorry, please ignore this patch due to an incorrect title. I will resend the=
 correct one

> On Feb 5, 2024, at 10:28, Hao Ge <gehao@kylinos.cn> wrote:
>=20
> =EF=BB=BFtoo_many_isolated should return bool which with the same name and=

> similar functions in mm/compaction.c already returned bool
>=20
> Signed-off-by: Hao Ge <gehao@kylinos.cn>
> ---
> mm/vmscan.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>=20
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 4f9c854ce6cc..143e4b8e8821 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -1744,17 +1744,17 @@ bool folio_isolate_lru(struct folio *folio)
>  * the LRU list will go small and be scanned faster than necessary, leadin=
g to
>  * unnecessary swapping, thrashing and OOM.
>  */
> -static int too_many_isolated(struct pglist_data *pgdat, int file,
> +static bool too_many_isolated(struct pglist_data *pgdat, int file,
>        struct scan_control *sc)
> {
>    unsigned long inactive, isolated;
>    bool too_many;
>=20
>    if (current_is_kswapd())
> -        return 0;
> +        return false;
>=20
>    if (!writeback_throttling_sane(sc))
> -        return 0;
> +        return false;
>=20
>    if (file) {
>        inactive =3D node_page_state(pgdat, NR_INACTIVE_FILE);
> --
> 2.25.1