Date: Thu, 20 Dec 2007 15:29:06 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Yinghai Lu <Yinghai.Lu@Sun.COM>
Cc: Andrew Morton <akpm@linux-foundation.org>,
       LKML <linux-kernel@vger.kernel.org>, Mike Travis <travis@sgi.com>
Subject: Re: not needed patch
Message-ID: <20071220142906.GA20794@elte.hu>
References: <200712192057.02500.yinghai.lu@sun.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200712192057.02500.yinghai.lu@sun.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 924
Lines: 29


* Yinghai Lu <Yinghai.Lu@Sun.COM> wrote:

> Ingo.
> 
> commit fbdcf18df73758b2e187ab94678b30cd5f6ff9f9 is not needed. another 
> patch (by you !! commit 699d934d5f958d7944d195c03c334f28cc0b3669 x86: 
> fixup cpu_info array conversion) already removed clearing of 
> c->cpu_index. in identify_cpu
> also it is not consisent to smpboot_32.c. (it will assign id to 
> cpu_index right after
>
>  	*c = boot_cpu_data;
> )

well, it might in the worst-case be a superfluous change, but not cause 
any problems in 2.6.24, right?

> by revert commit fbdcf18df73758b2e187ab94678b30cd5f6ff9f9, we could 
> use c->cpu_index in identify_cpu.

but that's 2.6.25 stuff, right? Travis?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/