Received-SPF: pass (google.com: domain of linux-kernel+bounces-52087-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <86ad296c-7af0-49ba-a22b-9bcaf355311e@intel.com>
Date: Mon, 5 Feb 2024 14:44:51 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 3/4] x86/kexec(): Reset TDX private memory on platforms
 with TDX erratum
To: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC: "Gao, Chao" <chao.gao@intel.com>, "Hansen, Dave" <dave.hansen@intel.com>,
	"luto@kernel.org" <luto@kernel.org>, "bp@alien8.de" <bp@alien8.de>,
	"x86@kernel.org" <x86@kernel.org>, "peterz@infradead.org"
	<peterz@infradead.org>, "hpa@zytor.com" <hpa@zytor.com>, "mingo@redhat.com"
	<mingo@redhat.com>, "kirill.shutemov@linux.intel.com"
	<kirill.shutemov@linux.intel.com>, "tglx@linutronix.de" <tglx@linutronix.de>,
	"bhe@redhat.com" <bhe@redhat.com>, "thomas.lendacky@amd.com"
	<thomas.lendacky@amd.com>, "nik.borisov@suse.com" <nik.borisov@suse.com>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>
References: <cover.1706698706.git.kai.huang@intel.com>
 <b52ed259e0d487b3a968b98da91cb4f55a28ae82.1706698706.git.kai.huang@intel.com>
 <b083d901a8be0597e311d29fa6cc01046c37db69.camel@intel.com>
Content-Language: en-US
From: "Huang, Kai" <kai.huang@intel.com>
In-Reply-To: <b083d901a8be0597e311d29fa6cc01046c37db69.camel@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dW1pZkpHT09sWmQ5RjBFeUk5aUVtUGhoeXZJclBnd0xjYWIzVis1RElkZjli?=
 =?utf-8?B?dlJlTlp5d0dPWjg1Lys3d1VCUitFWU1qcWNLRzh5clpheHplK3dKZmFqRmcy?=
 =?utf-8?B?VllFOG5McHhGM21ybi9DWEkzeklkQlFtZDE1bEN1NU83SklqVVpic3dweGdY?=
 =?utf-8?B?TkVmSTdDbkZzQkFkU3VGalpwTDJ1Yk5qRTUyT09vVFJZNHhsaXpjalR3TXRZ?=
 =?utf-8?B?eldWUXpIVDRoWURlRXhPTGQrc1JJYzcxR0txRFZsUWJ2TE5LOWtBbStGaGhK?=
 =?utf-8?B?UjhGVjVHcE5TRjBRb2V2ZU9MOFBSSk1QYmVtQlJGRGMycWcvRThPeXJzREhQ?=
 =?utf-8?B?QUU2UEdYRFRnV2RCTkhIbjdscHQ4eWpIN085bjF3UmZpWHlsSFZQcVVkSTI2?=
 =?utf-8?B?eWdOeGFiS3FhVXg1RFF4YUNYTlFqY0FDM2xaR3NYTGRDSlZoTnpWcGlxaUJa?=
 =?utf-8?B?enlCMm1BNnRES3NJMTZsTEsrQ2cvRmFtblljTWlteHZPMkVIbFNUdkkrNnZh?=
 =?utf-8?B?bnBKMXRmVUlBeVBwSzRKcUo4dll3ejdZWE12N3l6NTc0ZElHSDBqb0s1MHU4?=
 =?utf-8?B?ODdiRkZFY3JvakFOR3IxNkF1dENiY2p2cFhoSHk4VEZoRE9pRVpsTnZEZ0l3?=
 =?utf-8?B?VFZ1U2hIRjRMMTRLY0JjRTJmT0R3bUZ2Q2dWeGljcmlhR1JUNldkRTFwa1dZ?=
 =?utf-8?B?ZUxrTVRsTXJzV01pSnA5L094bGRPeW1LK1d6TU5nZndCTzVkb0tMQUJQYTlP?=
 =?utf-8?B?WE1ndFNsa0hCNll0bXF5bFZkcWhlVUYva2ZEOGpjb1ovQm1KcC9ZSXZZU29S?=
 =?utf-8?B?UmFvYzE2YjZCeUxtWm93d2hkZGowQnY2ZUUweE5iOTEzTlFjMklxUTVnMVN4?=
 =?utf-8?B?Z3pScWNRbGZlNjJMSVVBeXpFL1pSU3FSN0tFQVdQMWlZaUY3VXAyV0pOa3hZ?=
 =?utf-8?B?aStRV1hPbHc3MURkcTBJVXprVkNNNjRmRFlrTkZndDZpOXREQUZJQm9SQU16?=
 =?utf-8?B?aGFIcFRXcXd1R3FYV3MwOEI4R1h1SWE0dWZDc2pWRS9DY1Z2bnQwMjdPTkVH?=
 =?utf-8?B?M2pTeW5SaStIWkFSa3V3OG10dDhHT05BRmxkeTdPTkkvMGNESDJ5NXdaS212?=
 =?utf-8?B?bWIyMDUwL2V0elp3SmtyUllPVHh1c3h3dGFpQnZFWUVuT0NjbXlqR2swV28v?=
 =?utf-8?B?UmN4anM3SmFBNEc5R0E5dndEa2hIek5TalN2RmJ2U1BBajVlejIwVFFGbkc3?=
 =?utf-8?B?eFN5STUvajJjVWZMN1I0dHJvclRBQk5uTGRZYVFuaEovaFZUdVVaL1JkSnBl?=
 =?utf-8?B?RWdka0NHZW83QXRUVlo5UUxGTEl1UGpZTWFSWmlNMk9sZ3YzL0RHeHVqNDFD?=
 =?utf-8?B?Q3NOY3ZEM2c4RFFYS0tkL3hQVWZ5SXFUMHExK1crNDFiTVhwL0czV1BtWjVE?=
 =?utf-8?B?UStwaGFZd29MTDZvVVZIY1FEbzJBeVFLb0hOenFXaThrb3JNWHc2bTlJSzhE?=
 =?utf-8?B?TmVreUxBaTB3ZVd4cmhLb3VjdkRaMjdpc2xuOGZCKzYrbmxFZlhsbkh1bzc4?=
 =?utf-8?B?d0k1V1JZQ1MyK1MxRGMxWlB5elBZREVwUncyWEVzWmw1bUl4OENlZXNMTWlo?=
 =?utf-8?B?UzdZVmo1VW8zQnpEcVZMdGJQY1ZJaWozcDdDT043ZHQ1ckNqdmRucElKZ0Ix?=
 =?utf-8?B?Q2NpM1didUJnaDN0U0VZUy9lYzc5akgwT1ZCbE5hSjdBTzBYM2NDaHp3YWZ5?=
 =?utf-8?B?Z3duVkNadmZpU3BseWZmYys3SU4yVk5DOHpOVUtDQTBKNVl4ekh0d3I5U2NE?=
 =?utf-8?B?Vk5UU0pyZGQ0YVhwQi9tdUZCT0hqQVFZNlk4Z0ZKNzE1dDVqcDFPczRMcTRs?=
 =?utf-8?B?NXJqd1pEbkdIdkd6bnY0QkwxV1NDS296N1F4UkJMaDRPSy9CT21PL0o0NFYy?=
 =?utf-8?B?MWZveWlkeGo0YmFuK2dlWTFseHFlaVVBSnk5MExwVGprMlVnczFnaVdqWVU3?=
 =?utf-8?B?YmQwTUhQZjZ4eFlMcFlTMlJPK2M2ZzY0UlVoSWpvQ2ZiS29IaXR0RXA4QndI?=
 =?utf-8?B?bDhZL0FSVVpzS0tlNjEvU1JGYVRrZlprRmNPclRRNUMzdWh5bmx5UXpiYklU?=
 =?utf-8?Q?Bo4sryDIcPRR+aWiyns42FjU5?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e765e653-3cc0-4751-f1e1-08dc2615fc9e
X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5978.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2024 06:45:06.3872
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2pSU6a5xRDJ56gsXJnM2r84yQH4HOTKPWfuoXw8HX2UtipvuyBzghd28t2A76Jj0ziRuBt+u6o5SnrnOM21ZMA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6034
X-OriginatorOrg: intel.com


On 2/02/2024 8:54 am, Edgecombe, Rick P wrote:
> On Wed, 2024-01-31 at 11:31 +0000, Huang, Kai wrote:
>> Note kexec() can happen at anytime, including when TDX module is
>> being
>> initialized.  Register TDX reboot notifier callback to stop further
>> TDX
>> module initialization.  If there's any ongoing module initialization,
>> wait until it finishes.  This makes sure the TDX module status is
>> stable
>> after the reboot notifier callback, and the later kexec() code can
>> read
>> module status to decide whether PAMTs are stable and available.
> 
> I don't see how this works with the crash kernel flavor of kexec. Did
> you look at that scenario?
> 
> 
Hmm right this doesn't work for crash kexec.  Thanks for pointing out.

We need a way that doesn't depend on the reboot notifier.  Previously we 
used a variable to indicate the point where it's possible to have any 
TDX private pages.  I'll switch back to use that.