Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp2233143rdb; Sun, 4 Feb 2024 22:57:44 -0800 (PST) X-Google-Smtp-Source: AGHT+IEcFcLrW4jRjFo4CycpoWCaLWxmDgWQL8zLwbEpRjYQjjD6MByd0H5h4vdgXxr7am3Qh2an X-Received: by 2002:a05:6a21:3282:b0:19c:9b38:f398 with SMTP id yt2-20020a056a21328200b0019c9b38f398mr14864713pzb.22.1707116263874; Sun, 04 Feb 2024 22:57:43 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707116263; cv=pass; d=google.com; s=arc-20160816; b=keovFqZbf0MZ15XUaVLU5rspEmxCu1dOZ71/Fa9zai8V/bE2BVNca4IazjQoDAjBbl sk4W+WAlBsSeMfH7ce61Slcn9KYnLsqv3OS3NNEB5NmPV/q/rnkqSXTk3OYkQ83x5iTV HX6nG93xmchYK9RYzkwfZwWYfy4peqT+FabuhjRhtfPzZCpSYX2X8i1S/JsOOrcwvCOO LDYEp23ys3DrdxfgbdhNinXxAJCN2hmwiHi07qncCqlwZ6MJFBjMm06LAUTkvkoRO1Oj lMLP/xnnRTgACz8n25/UrM7g+s5k6xVzK5RjmHcQ0vT6CI5b5bBci4AFu/zJ4BFH12BS SQ7Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=D503/AjxBwgTT+qoYJKIIUiW1y30Pd8so2kspwugprU=; fh=fGf6EG4w8wtxReRjVBdQbMFDeuytX0iNSstA/6Z0uME=; b=aakmtVQGdNjG2ZeTmhnCM2jXw5k/LLbrqgKPPWHSoOVa4kZaZUSx1fD24VcZj+dfHZ 7wrfMQ/+Pf/H0Mpif9h+9xMqP48OvmmZ8YqyGcI5hIXMa/ic+WmlkJH03IWy6AShzzww nRX51+4u58M+8G8OaJU7E2PbJJR3rceB4ew32YPmNZsmCkB9A1LA4cmvUgn7O3Ts0vJD NfFRD9XDQfHGSY6TdG0EDq674hg5YuIsbbiHt/BYVZhItr8XGLY5kpEtWZ8OIPZ9JWKd j4LOsz9yUW3r6kx4Nh8tZtONvktNdAS6fNhqCeyQ0dNbuHdnP2MUGfY5AXfdzSQdjP/h sETA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=CNnVZzDM; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-52098-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-52098-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev X-Forwarded-Encrypted: i=1; AJvYcCVqGC9nvctmcPnkTfCljD5WDXRbtrtBjasH+RR+7UZj08zhUcRFQu9nBF1QiR8zwGZSrera5yCDNaWN439WN8I6b1q/Q1M1Ap7ufr8lAA== Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id c14-20020a170902d48e00b001d75edd0af9si5964977plg.109.2024.02.04.22.57.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Feb 2024 22:57:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-52098-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=CNnVZzDM; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-52098-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-52098-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 831D6281571 for ; Mon, 5 Feb 2024 06:57:43 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E626711183; Mon, 5 Feb 2024 06:57:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="CNnVZzDM" Received: from out-173.mta0.migadu.com (out-173.mta0.migadu.com [91.218.175.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9E6411184 for ; Mon, 5 Feb 2024 06:57:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707116258; cv=none; b=rXne+y1vyPr9dAjg2QrGkiZhOLUKBDvFDEnH+CvERDWD8B5kMb/Bb8HMgei8ztQVkCxrzzGfQTSvH0R6IIiwB4FADzIPjy9dGOeVwOBiFCSyaUMZ4G0dN8Ef/kKt/vB5qia8ZzVToOdTinG076mYwPp7f7N9esx5oe3wXPSsZ3w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707116258; c=relaxed/simple; bh=D503/AjxBwgTT+qoYJKIIUiW1y30Pd8so2kspwugprU=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=ENsizQP8OIKi1kgKYJvTPwu1xbKeahtER7gTdYRGA568jdSrv7SbYnqbWMrMSD1qN6aWOY3J3IKOWat3iEQp5cwjK82DeH8RkjiN7LWJjtHJ6lm/LKy1cXu8YFPKq3neRZUMMmici8mAPdDNFs5WnN78zHl3zSJQtUsV2sQVj5U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=CNnVZzDM; arc=none smtp.client-ip=91.218.175.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1707116253; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D503/AjxBwgTT+qoYJKIIUiW1y30Pd8so2kspwugprU=; b=CNnVZzDM/YbUjKn8gIpgpk8IY8zGmVVPbiStfakFINLT/UN7vUHlp16trrIjio2UL1GAVz sBCEVy7f1QnM1Raykom7VqrGoht08yz7tLSVtMnja2iSu2DrfYUgwHkD2J8aWkarUCx2WU XukElD5CIWYIRuB/P3ozmX9qJoeJkoA= Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Subject: Re: [PATCH] mm: hugetlb: fix hugetlb allocation failure when handling freed or in-use hugetlb X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: Date: Mon, 5 Feb 2024 14:56:49 +0800 Cc: Andrew Morton , Oscar Salvador , David Hildenbrand , Michal Hocko , Linux-MM , linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: References: To: Baolin Wang X-Migadu-Flow: FLOW_OUT > On Feb 5, 2024, at 11:54, Baolin Wang = wrote: >=20 > When handling the freed hugetlb or in-use hugetlb, we should ignore = the > failure of alloc_buddy_hugetlb_folio() to dissolve the old hugetlb = successfully, > since we did not use the new allocated hugetlb in this 2 cases. >=20 > Signed-off-by: Baolin Wang OK. It is not a fix (I see a fix keyword in subject) but an optimization for unnecessary-allocation cases. Thanks. Reviewed-by: Muchun Song