Received-SPF: pass (google.com: domain of linux-kernel+bounces-52137-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: linux-arm-kernel@lists.infradead.org, Adam Ford <aford173@gmail.com>
Cc: marex@denx.de, frieder.schrempf@kontron.de, Lucas Stach <l.stach@pengutronix.de>, Adam Ford <aford173@gmail.com>, Andrzej Hajda <andrzej.hajda@intel.com>, Neil Armstrong <neil.armstrong@linaro.org>, Robert Foss <rfoss@kernel.org>, Laurent Pinchart <Laurent.pinchart@ideasonboard.com>, Jonas Karlman <jonas@kwiboo.se>, Jernej Skrabec <jernej.skrabec@gmail.com>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Pengutronix Kernel Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, NXP Linux Team <linux-imx@nxp.com>, Philipp Zabel <p.zabel@pengutronix.de>, Vinod Koul <vkoul@kernel.org>, Kishon Vijay Abraham I <kishon@kernel.org>,
  Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Liu Ying <victor.liu@nxp.com>, Ulf Hansson <ulf.hansson@linaro.org>, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH V8 05/12] arm64: dts: imx8mp: add HDMI power-domains
Date: Mon, 05 Feb 2024 08:26:12 +0100
Message-ID: <1880028.tdWV9SEqCh@steina-w>
Organization: TQ-Systems GmbH
In-Reply-To: <20240203165307.7806-6-aford173@gmail.com>
References: <20240203165307.7806-1-aford173@gmail.com> <20240203165307.7806-6-aford173@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"

Hi Adam,

thanks for working on this.

Am Samstag, 3. Februar 2024, 17:52:45 CET schrieb Adam Ford:
> From: Lucas Stach <l.stach@pengutronix.de>
>=20
> This adds the PGC and HDMI blk-ctrl nodes providing power control for
> HDMI subsystem peripherals.
>=20
> Signed-off-by: Adam Ford <aford173@gmail.com>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> V2:  Add missing power-domains hdcp and hrv
> ---
>  arch/arm64/boot/dts/freescale/imx8mp.dtsi | 38 +++++++++++++++++++++++
>  1 file changed, 38 insertions(+)
>=20
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mp.dtsi index
> 76c73daf546b..5c54073de615 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> @@ -836,6 +836,23 @@ pgc_mediamix: power-domain@10 {
>  							 <&clk=20
IMX8MP_CLK_MEDIA_APB_ROOT>;
>  					};
>=20
> +					pgc_hdmimix: power-
domains@14 {

As per Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml the node=
=20
should be called power-domain@.

> +						#power-domain-
cells =3D <0>;
> +						reg =3D=20
<IMX8MP_POWER_DOMAIN_HDMIMIX>;
> +						clocks =3D <&clk=20
IMX8MP_CLK_HDMI_ROOT>,
> +							 <&clk=20
IMX8MP_CLK_HDMI_APB>;
> +						assigned-clocks =3D=20
<&clk IMX8MP_CLK_HDMI_AXI>,
> +							=09
  <&clk IMX8MP_CLK_HDMI_APB>;
> +						assigned-clock-
parents =3D <&clk IMX8MP_SYS_PLL2_500M>,
> +							=09
	 <&clk IMX8MP_SYS_PLL1_133M>;
> +						assigned-clock-
rates =3D <500000000>, <133000000>;
> +					};
> +
> +					pgc_hdmi_phy: power-
domains@15 {

As per Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml the node=
=20
should be called power-domain@.

> +						#power-domain-
cells =3D <0>;
> +						reg =3D=20
<IMX8MP_POWER_DOMAIN_HDMI_PHY>;
> +					};
> +
>  					pgc_mipi_phy2: power-
domain@16 {
>  						#power-domain-
cells =3D <0>;
>  						reg =3D=20
<IMX8MP_POWER_DOMAIN_MIPI_PHY2>;
> @@ -1361,6 +1378,27 @@ eqos: ethernet@30bf0000 {
>  				intf_mode =3D <&gpr 0x4>;
>  				status =3D "disabled";
>  			};
> +
> +			hdmi_blk_ctrl: blk-ctrl@32fc0000 {
> +				compatible =3D "fsl,imx8mp-hdmi-blk-
ctrl", "syscon";
> +				reg =3D <0x32fc0000 0x23c>;
> +				clocks =3D <&clk IMX8MP_CLK_HDMI_APB>,
> +					 <&clk=20
IMX8MP_CLK_HDMI_ROOT>,
> +					 <&clk=20
IMX8MP_CLK_HDMI_REF_266M>,
> +					 <&clk IMX8MP_CLK_HDMI_24M>,
> +					 <&clk=20
IMX8MP_CLK_HDMI_FDCC_TST>;
> +				clock-names =3D "apb", "axi",=20
"ref_266m", "ref_24m", "fdcc";
> +				power-domains =3D <&pgc_hdmimix>,=20
<&pgc_hdmimix>,
> +						<&pgc_hdmimix>,=20
<&pgc_hdmimix>,
> +						<&pgc_hdmimix>,=20
<&pgc_hdmimix>,
> +						<&pgc_hdmimix>,=20
<&pgc_hdmi_phy>,
> +						<&pgc_hdmimix>,=20
<&pgc_hdmimix>;
> +				power-domain-names =3D "bus",=20
"irqsteer", "lcdif",
> +						     "pai", "pvi",=20
"trng",
> +						     "hdmi-tx",=20
"hdmi-tx-phy",
> +						     "hdcp",=20
"hrv";
> +				#power-domain-cells =3D <1>;
> +			};
>  		};
>=20

According to RM this block is part of AIPS4, so it should be below=20
hsio_blk_ctrl.

Best regards,
Alexander

>  		aips5: bus@30c00000 {


=2D-=20
TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht M=FCnchen, HRB 105018
Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider
http://www.tq-group.com/